From patchwork Thu Mar 15 06:03:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 131745 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp702601ljb; Wed, 14 Mar 2018 23:04:40 -0700 (PDT) X-Google-Smtp-Source: AG47ELuMug8CUw1roihEDP4DsEBewcWl27tDou7oKE7oeb59/ZfQqbGx15HCSSspVc+EgUz32zLw X-Received: by 2002:a17:902:7883:: with SMTP id q3-v6mr6579002pll.361.1521093880132; Wed, 14 Mar 2018 23:04:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521093880; cv=none; d=google.com; s=arc-20160816; b=jyBHvw/71thJR+hCK3y835mYNS+k7Oxr6YlSP8sbdNSGwRaYuEhdROcaFSGIS/aNpd y2D0q0NWU4KjPOtClWgnzpHEkw+1CZyVqEjLev7/GjsUHsfdbG7FGAJ+2qlDwghPPKld cVz7vwxQwnKwHJhiJkTyGIjTnJhLgZ4nObsrHVHFl1kJi/Y3oNBRcMB41pen6Oh1zbJe 0BONhhCqNAVjBQZO54dqUBV31Z8sCDNhO3yJ1nx/1HDXCTuM/JJJY0M1kc3R5PLBhkFw ePHHRLT6m/eQvLvSIQytZpP94NMQDy4dZTJF5N1Vqe7g/2T1gQ5ds51MHWA79H26dbEh AHcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=Urcnf6z/bkPCohTBbQKE7Oi9r77Q6KGzeDX4QdlVYrQ=; b=ssC/Hqd0udGyyWJvg7ysxTxSZOeUp2YQGy7yhz1RUSVLoxEff5q05c3DI950hgXMAG 3BkhaJrTdiEV6z7S2Czrf1Srsad98kKN/rA7/oqRkhctTKpEq6PExjyKELM4e9RG4bXG EGDx7S2ZXOsKRWjNyWnlTe5yrJYo0m0AirKlk63N07J3iUMydVu43XeAKo7sMXTgt6Z1 iddhtA2RQ046xVVEU6edokqvtQBxIb+JFHf+fSMAtmFNFFrSGcHyRoYzhsYzkvFCR1B1 jAS/rcVUxiZkBV5S7IpwKFQ9eIbv4w/bHTRVUdrwPbwasat3/W38I4ake9AklMfd9uzj K64w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Jayf8gfx; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id k8si2998206pgs.555.2018.03.14.23.04.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 23:04:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Jayf8gfx; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id EEA812202E495; Wed, 14 Mar 2018 22:58:14 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c05::243; helo=mail-pg0-x243.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A235021E08283 for ; Wed, 14 Mar 2018 22:58:13 -0700 (PDT) Received: by mail-pg0-x243.google.com with SMTP id x2so2392342pgo.9 for ; Wed, 14 Mar 2018 23:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=bYiYDreMxmpwWT/8L3SUhs53LHVzy6q8IR3q9ieY1eo=; b=Jayf8gfx6pP53q+rTTMqvf2n4ZsNIaklu2oSn8Ldrf+2LeNCagL2mw9ejUP/iYyVly BaSYT28BtuLGsPSvnQXDJYV/H2jvtbSrMVgYfdwzCTOgsVqfr3itgbPyha1MHkRIznmy qmqhqiMB+8CErZO1oroaB9BLLkSoi2WaoP6T4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bYiYDreMxmpwWT/8L3SUhs53LHVzy6q8IR3q9ieY1eo=; b=TVky5wVm3s7rHDwGvY8e0fpmyY9BH4cxxS+LbrBXinle46BAYGQgFeZ0/Mx4HIMocZ UUp616s1HaY+1oCEfc62x6DFZrBQrWVVqI+UklOv/NH7PhmrjtQ8mCgEAUb3tGGcv1vk buvTGw5nV8pQ52OywGKqBr8XJ3fSiGtd/9i45UCYyr3gqMKV+1y73t24aTaT6/b6evDv kROiMiSb+TDa+dBXK9PYRyQ800/hEBMsiPVecnw28yOIOkjxzFmI8H3coyAK1dYdqctf dR9y4po1gLKO9JBNXrsTrKozaUWc78Am5wzyJ7CUP/NZIthlaoeBf1fUKK9u76bcRM1+ ugOQ== X-Gm-Message-State: AElRT7FmAc06u7QEEdifTGXXh9Wa2nA8WWjEx2+hFhZGLBEoZCF7iy1k WPODklRZ1A1Hoi3bPsz4BS3oKsnCIdg= X-Received: by 10.98.131.4 with SMTP id h4mr6673887pfe.156.1521093876605; Wed, 14 Mar 2018 23:04:36 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id 70sm7436192pgb.86.2018.03.14.23.04.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Mar 2018 23:04:35 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Date: Thu, 15 Mar 2018 14:03:57 +0800 Message-Id: <1521093843-48615-1-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH v7 0/6] Add translation support to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Eric Dong , Ard Biesheuvel , Jordan Justen , Anthony Perard , Heyi Guo , Prince Agyeman , Michael D Kinney , Laszlo Ersek , Star Zeng MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Code can also be found here: https://github.com/iwishguo/edk2/tree/patch-pci-host-bridge-v7 v7: - Patch 4: implement 1 comments from Ray. v6: - Patch 1, 2: implement 3 comments from Laszlo. - Patch 4: implement 3 comments from Ray. Patch v5 inherits the code from RFC v4; we don't restart the version number for RFC to PATCH change. v5: - Patch 4/6: Modify the code according to the comments from Ray. - Patch 1/6 and 2/6 are totally new. They add initialization for all fields of PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE structure. - Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a prerequisite for patch 4/6, it does not change the code in PciHostBridge driver and won't cause any build failure or functional issue. v4: - Modify the code according to the comments from Ray, Laszlo and Ard (Please see the notes of Patch 1/3) - Ignore translation of bus in CreateRootBridge. v3: - Keep definition of Translation consistent in EDKII code: Translation = device address - host address. - Patch 2/2 is split into 2 patches (2/3 and 3/3). - Refine comments and commit messages to make the code easier to understand. v2: Changs are made according to the discussion on the mailing list, including: - PciRootBridgeIo->Configuration should return CPU view address, as well as PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view address - CPU view address. - Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. - PciHostBridge driver internally used Base Address is still based on PCI view address, and translation offset = CPU view - PCI view, which follows the definition in ACPI, and not the same as that in UEFI spec. Cc: Ruiyu Ni Cc: Ard Biesheuvel Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Michael D Kinney Cc: Maurice Ma Cc: Prince Agyeman Cc: Benjamin You Cc: Jordan Justen Cc: Anthony Perard Cc: Julien Grall Heyi Guo (6): CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init MdeModulePkg/PciHostBridgeLib.h: add address Translation MdeModulePkg/PciHostBridgeDxe: Add support for address translation MdeModulePkg/PciBus: convert host address to device address MdeModulePkg/PciBus: return CPU address for GetBarAttributes MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- 9 files changed, 306 insertions(+), 31 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel