From patchwork Thu Mar 15 04:00:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 131729 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp618204ljb; Wed, 14 Mar 2018 21:00:45 -0700 (PDT) X-Google-Smtp-Source: AG47ELulHykjrdNiZMXLTHTkod3DzFY+RBLuT9oVa/YqvynIkPBbWUcp4ES/XGHMl+AS3lhJUsbF X-Received: by 2002:a17:902:904b:: with SMTP id w11-v6mr6518162plz.11.1521086445827; Wed, 14 Mar 2018 21:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521086445; cv=none; d=google.com; s=arc-20160816; b=Lrwp8S4ZXPb+fOlnRVPqlL7D1G/DrpW2Gk9QGn9P8lRm/elh5yMb3D/RmLrCnhPptv b915x3ZmuGi3xmP0yrY1Rz0dxr0kKnDsbF9MkncsDWLKA5nUxTHsWIWR5onS3YCpt9gf F/HwIeGf78D8vnYLO+0fEo8UtjnIEqzrwyqYt5tQPLZ4XPrJY5pm9lhzLUL9OPae1f4P Pw23i+WfDyxTecKhDrIdI0VLHQcCVKuUUoUtOS+ZHU54Nn3BQ+KEfQ7mWsjHaUxH9Pmh 2H66uYZwqwjbZyFOAQWeANsE/nr47OodBkSRSt9u54hESd0Cy/QHWC4G1C1QQZ4uWSt8 /GFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=Aw7kNSzAw+mAyQ4nwiOQC3Knx5TBfhe7Dpobzcyr6Zs=; b=mLp7R01HeSxcTC+IsjsRkdnqRkTnuatb9Ng98dQvHGGwlfxc9o8+LpCIoLOvMLWQrh P8l2IjjmLW9Eev93jo65xDpIjs1hw9xbWKuhxzdnJ6ZWznJHeSWwTeAIdG2vXiENarMo imA2ZesXDFOGP3synuVL+1VF+C8Y2wty3UlxGCQsj65RCLJnJiSyAwn+IHz1tn+NwTjr 8P/ec3w+Bc6CinC0rjW97GO32PfshiRn+sONXmPxxgHc+tVOX/kc00UWiefggMRrg7iq qpPYnmyucgwpJS8MS9UfZlYRPlqAEPIGoS576zX6aP3lKp7wQfr0xVpMaEKkWyATjRvO l/7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CCLnpHfn; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id v5-v6si3171029plp.156.2018.03.14.21.00.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 21:00:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CCLnpHfn; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 44F922253FB60; Wed, 14 Mar 2018 20:54:21 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::241; helo=mail-pl0-x241.google.com; envelope-from=heyi.guo@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4CE3221E49032 for ; Wed, 14 Mar 2018 20:54:19 -0700 (PDT) Received: by mail-pl0-x241.google.com with SMTP id 9-v6so3005844ple.11 for ; Wed, 14 Mar 2018 21:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=X02UJ6u68kVQLz0KE+p4zk8e1aBWoo09Cf0yMWGGg2w=; b=CCLnpHfnEtGxCChLe1p9ePVxdqHDrGtFex4BtVs6zOHXMHA0khseffu5BU+dcDg8W6 Cwd/S2P2xmhmmh/6ERDHi+T6zo3N1zKERdRwjuOpo0FRnF+UVRm2Xe8Hr0+cRMFPwQN0 Zun5m3F66i8D/8FYPlAxZ05S6nzPyolPdlduw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=X02UJ6u68kVQLz0KE+p4zk8e1aBWoo09Cf0yMWGGg2w=; b=NO3+KDJxVrEwnR+FqJ8FF+S48yaAh8WSnjJrm9gn9D6m4RvHTBtThJG2OtcOwqQZM8 QNFapTqO0VwJqCJynHVTOphDgTdEoEjh98pzov+1UvsfosNFdrcCxEkTgedy9XR+XrHT jxpsLNbQR6Yzk0RvlvsveHurBOGFJ7uNXXEcxbplZwLjOm8Im7iZLB5Kz/J5hZJxK+Dg ruERoQO2M7bRQxA6PI7ldmoWTooE/xg9OcV/eO7jTJ8u4hCzLUGf+i9BhQJomRM4lpo9 IdXH8e6eSDJSQzuBfLwV0JBZ9r4Aow2yiiU4g9lnzAX8f7ofQe+NiSe3K2wBVbmzSIkE yabw== X-Gm-Message-State: AElRT7EHmvZclCERvLoD9XvJ3jJdcUobuETwaXcJSaYW7nETGOc7hA3H VX77RIUUggJDNKEn13zoqtn4RFvFXMY= X-Received: by 2002:a17:902:7142:: with SMTP id u2-v6mr6392102plm.257.1521086442473; Wed, 14 Mar 2018 21:00:42 -0700 (PDT) Received: from localhost.localdomain ([45.56.152.100]) by smtp.gmail.com with ESMTPSA id e4sm8107785pfa.166.2018.03.14.21.00.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Mar 2018 21:00:41 -0700 (PDT) From: Heyi Guo To: edk2-devel@lists.01.org Date: Thu, 15 Mar 2018 12:00:18 +0800 Message-Id: <1521086424-113954-1-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [edk2] [PATCH v6 0/6] Add translation support to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Eric Dong , Ard Biesheuvel , Jordan Justen , Anthony Perard , Heyi Guo , Prince Agyeman , Michael D Kinney , Laszlo Ersek , Star Zeng MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" v6: - Patch 1, 2: implement 3 comments from Laszlo. - Patch 4: implement 3 comments from Ray. Patch v5 inherits the code from RFC v4; we don't restart the version number for RFC to PATCH change. v5: - Patch 4/6: Modify the code according to the comments from Ray. - Patch 1/6 and 2/6 are totally new. They add initialization for all fields of PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE structure. - Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a prerequisite for patch 4/6, it does not change the code in PciHostBridge driver and won't cause any build failure or functional issue. v4: - Modify the code according to the comments from Ray, Laszlo and Ard (Please see the notes of Patch 1/3) - Ignore translation of bus in CreateRootBridge. v3: - Keep definition of Translation consistent in EDKII code: Translation = device address - host address. - Patch 2/2 is split into 2 patches (2/3 and 3/3). - Refine comments and commit messages to make the code easier to understand. v2: Changs are made according to the discussion on the mailing list, including: - PciRootBridgeIo->Configuration should return CPU view address, as well as PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view address - CPU view address. - Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. - PciHostBridge driver internally used Base Address is still based on PCI view address, and translation offset = CPU view - PCI view, which follows the definition in ACPI, and not the same as that in UEFI spec. Cc: Ruiyu Ni Cc: Ard Biesheuvel Cc: Star Zeng Cc: Eric Dong Cc: Laszlo Ersek Cc: Michael D Kinney Cc: Maurice Ma Cc: Prince Agyeman Cc: Benjamin You Cc: Jordan Justen Cc: Anthony Perard Cc: Julien Grall Heyi Guo (6): CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init MdeModulePkg/PciHostBridgeLib.h: add address Translation MdeModulePkg/PciHostBridgeDxe: Add support for address translation MdeModulePkg/PciBus: convert host address to device address MdeModulePkg/PciBus: return CPU address for GetBarAttributes MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- 9 files changed, 306 insertions(+), 31 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel