| Message ID | 1521086424-113954-1-git-send-email-heyi.guo@linaro.org |
|---|---|
| Headers | show |
| Series | Add translation support to generic PciHostBridge | expand |
On 3/15/2018 12:00 PM, Heyi Guo wrote: > v6: > - Patch 1, 2: implement 3 comments from Laszlo. > - Patch 4: implement 3 comments from Ray. > > Patch v5 inherits the code from RFC v4; we don't restart the version number for > RFC to PATCH change. > > v5: > - Patch 4/6: Modify the code according to the comments from Ray. > - Patch 1/6 and 2/6 are totally new. They add initialization for all fields of > PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so > that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE > structure. > - Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a > prerequisite for patch 4/6, it does not change the code in PciHostBridge > driver and won't cause any build failure or functional issue. > > > v4: > - Modify the code according to the comments from Ray, Laszlo and Ard (Please see > the notes of Patch 1/3) > - Ignore translation of bus in CreateRootBridge. > > > v3: > - Keep definition of Translation consistent in EDKII code: Translation = device > address - host address. > - Patch 2/2 is split into 2 patches (2/3 and 3/3). > - Refine comments and commit messages to make the code easier to understand. > > > v2: > Changs are made according to the discussion on the mailing list, including: > > - PciRootBridgeIo->Configuration should return CPU view address, as well as > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > address - CPU view address. > - Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. > - PciHostBridge driver internally used Base Address is still based on PCI view > address, and translation offset = CPU view - PCI view, which follows the > definition in ACPI, and not the same as that in UEFI spec. > > Cc: Ruiyu Ni <ruiyu.ni@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Star Zeng <star.zeng@intel.com> > Cc: Eric Dong <eric.dong@intel.com> > Cc: Laszlo Ersek <lersek@redhat.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Maurice Ma <maurice.ma@intel.com> > Cc: Prince Agyeman <prince.agyeman@intel.com> > Cc: Benjamin You <benjamin.you@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Anthony Perard <anthony.perard@citrix.com> > Cc: Julien Grall <julien.grall@linaro.org> > > > Heyi Guo (6): > CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init > OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init > MdeModulePkg/PciHostBridgeLib.h: add address Translation > MdeModulePkg/PciHostBridgeDxe: Add support for address translation > MdeModulePkg/PciBus: convert host address to device address > MdeModulePkg/PciBus: return CPU address for GetBarAttributes > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ > CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- > 9 files changed, 306 insertions(+), 31 deletions(-) > Heyi, I have given the Reviewed-by for the whole patch series. So please just add my R-b if you want to send further version of patches. I only have a minor comment for #4 patch. I don't think you need to send another version of #4 patch. You can just change the code when committing. Thanks, Ray -- Thanks, Ray _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Thu, Mar 15, 2018 at 01:27:59PM +0800, Ni, Ruiyu wrote: > On 3/15/2018 12:00 PM, Heyi Guo wrote: > >v6: > >- Patch 1, 2: implement 3 comments from Laszlo. > >- Patch 4: implement 3 comments from Ray. > > > >Patch v5 inherits the code from RFC v4; we don't restart the version number for > >RFC to PATCH change. > > > >v5: > >- Patch 4/6: Modify the code according to the comments from Ray. > >- Patch 1/6 and 2/6 are totally new. They add initialization for all fields of > > PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so > > that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE > > structure. > >- Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a > > prerequisite for patch 4/6, it does not change the code in PciHostBridge > > driver and won't cause any build failure or functional issue. > > > > > >v4: > >- Modify the code according to the comments from Ray, Laszlo and Ard (Please see > > the notes of Patch 1/3) > >- Ignore translation of bus in CreateRootBridge. > > > > > >v3: > >- Keep definition of Translation consistent in EDKII code: Translation = device > > address - host address. > >- Patch 2/2 is split into 2 patches (2/3 and 3/3). > >- Refine comments and commit messages to make the code easier to understand. > > > > > >v2: > >Changs are made according to the discussion on the mailing list, including: > > > >- PciRootBridgeIo->Configuration should return CPU view address, as well as > > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > > address - CPU view address. > >- Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. > >- PciHostBridge driver internally used Base Address is still based on PCI view > > address, and translation offset = CPU view - PCI view, which follows the > > definition in ACPI, and not the same as that in UEFI spec. > > > >Cc: Ruiyu Ni <ruiyu.ni@intel.com> > >Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >Cc: Star Zeng <star.zeng@intel.com> > >Cc: Eric Dong <eric.dong@intel.com> > >Cc: Laszlo Ersek <lersek@redhat.com> > >Cc: Michael D Kinney <michael.d.kinney@intel.com> > >Cc: Maurice Ma <maurice.ma@intel.com> > >Cc: Prince Agyeman <prince.agyeman@intel.com> > >Cc: Benjamin You <benjamin.you@intel.com> > >Cc: Jordan Justen <jordan.l.justen@intel.com> > >Cc: Anthony Perard <anthony.perard@citrix.com> > >Cc: Julien Grall <julien.grall@linaro.org> > > > > > >Heyi Guo (6): > > CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init > > OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init > > MdeModulePkg/PciHostBridgeLib.h: add address Translation > > MdeModulePkg/PciHostBridgeDxe: Add support for address translation > > MdeModulePkg/PciBus: convert host address to device address > > MdeModulePkg/PciBus: return CPU address for GetBarAttributes > > > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + > > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ > > CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- > > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + > > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- > > 9 files changed, 306 insertions(+), 31 deletions(-) > > > Heyi, > I have given the Reviewed-by for the whole patch series. So please just add > my R-b if you want to send further version of patches. > I only have a minor comment for #4 patch. I don't think you need to send > another version of #4 patch. You can just change the code when committing. Thanks, but I don't have commit privilege myself, so maybe a v7 is needed, and I will add your R-b for the whole series :) Regards, Heyi > Thanks, > Ray > > -- > Thanks, > Ray _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel