From patchwork Tue Nov 28 10:24:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 119829 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp2915460edl; Tue, 28 Nov 2017 02:34:23 -0800 (PST) X-Google-Smtp-Source: AGs4zMZxQQ5f+qDRmvwc7DfppdRHBJFBDffk7hLUwrj2s3mbCMQPR+jRiUmHkAGOTe6NkjGcE+6l X-Received: by 10.80.175.161 with SMTP id h30mr2027359edd.292.1511865263265; Tue, 28 Nov 2017 02:34:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511865263; cv=none; d=google.com; s=arc-20160816; b=pG/jYaZFN7jQChtk/ZJlIpRa7WFAse3TgH5frnMQ/Ty4yggKMVqh7sjQgTaGZNShdz uxtxTTLff8asCNC3pRdHbj077CbhD6AMRVVtq2MktzrjWkurhk/F9q0G53FFh6MqjFqa 1il5BVrgzJxQEReXfsgzhKOLC+zwcBVai+Dyb/f09bnVTOrauqSlVs58XTKggFL3uPzK X9rtQ6xfc6qwiT1nNZB+aXF5ht7/qixvbhU2XXGJwqrvRdAUQTP9bf80l2KoI0+4WhPl w9v0uBkZrM0XCJ9jhOS718vkmMCyb/RIVzjWWbeoTJ3RRiu7Chpj2w6JPxuKn63l3A3O jRMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=vlJz97NO5C1hqNTXuhAMZNb233r7m6C2DTP1UNV2uO4=; b=0GhmHbuKQyq/QUHZgMbB8JZeiG0FLOUMW5UaRp6l6niNSa91rqqopESFnUtEbMKoFo s5RS9xvWJuPykqSslk2c2u+tz1ZPM+fjZ4ZZq/CFossBhhiXE2oZ6ceM+gRAv2PJpYlL o1MFfxQs/HmY30ZGFzg791M/h13aRrtICLIP/qL1Lebs0Zg/hgQE3c1daOJ18rHqoChX PN4/Rqcu5xYVnkivXEM60/gtuTWKtodNGTn8zR98WuIQ2naskbbZCMFd0RXy6JghLrYC 80Fn3wi6cJDJxGijvKzaD3GmHPjWBZCgBhATjt91M2lU7+yRW7jVxBpjk5EoRazbhSnq GXyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id h9si5307073edf.446.2017.11.28.02.34.22; Tue, 28 Nov 2017 02:34:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id D4628C21E18; Tue, 28 Nov 2017 10:26:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E561BC21DF7; Tue, 28 Nov 2017 10:25:04 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 38245C21DF0; Tue, 28 Nov 2017 10:24:54 +0000 (UTC) Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by lists.denx.de (Postfix) with ESMTP id 78A47C21DA5 for ; Tue, 28 Nov 2017 10:24:54 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id CB9B420752; Tue, 28 Nov 2017 11:24:53 +0100 (CET) Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id A223920380; Tue, 28 Nov 2017 11:24:53 +0100 (CET) From: Maxime Ripard To: Tom Rini Date: Tue, 28 Nov 2017 11:24:39 +0100 Message-Id: X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: Cc: Thomas Petazzoni , u-boot@lists.denx.de, Andre Przywara , agraf@suse.de, Maxime Ripard , Jagan Teki Subject: [U-Boot] [PATCH 04/14] env: Make the env save message a bit more explicit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Since we'll soon have support for multiple environments, the environment saving message might end up being printed multiple times if the higher priority environment cannot be used. That might confuse the user, so let's make it explicit if the operation failed or not. Reviewed-by: Lukasz Majewski Signed-off-by: Maxime Ripard Reviewed-by: Andre Przywara Reviewed-by: Simon Glass --- env/env.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/env/env.c b/env/env.c index 673bfa6ba41b..1d13220aa79b 100644 --- a/env/env.c +++ b/env/env.c @@ -131,8 +131,9 @@ int env_save(void) if (!drv->save) continue; - printf("Saving Environment to %s...\n", drv->name); + printf("Saving Environment to %s... ", drv->name); ret = drv->save(); + printf("%s\n", ret ? "Failed" : "OK"); if (!ret) return 0;