| Message ID | bac19e70617e7728b1edaa690cca8d3cc624b072.1511864667.git-series.maxime.ripard@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | env: Multiple env support and env transition for sunxi | expand |
On 28/11/17 10:24, Maxime Ripard wrote: > Since we have global messages to indicate what's going on, the custom > messages in the environment drivers only make the output less readable. > > Make the common code play a little nicer by removing all the extra output > in the standard case. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> One nit below ... > --- > env/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/env/common.c b/env/common.c > index 70715bb6e756..fb66432bdc81 100644 > --- a/env/common.c > +++ b/env/common.c > @@ -78,7 +78,7 @@ void set_default_env(const char *s) > puts(s); > } > } else { > - puts("Using default environment\n\n"); > + debug("Using default environment\n\n"); Do we still need the extra empty line? Cheers, Andre > } > > if (himport_r(&env_htab, (char *)default_environment, >
diff --git a/env/common.c b/env/common.c index 70715bb6e756..fb66432bdc81 100644 --- a/env/common.c +++ b/env/common.c @@ -78,7 +78,7 @@ void set_default_env(const char *s) puts(s); } } else { - puts("Using default environment\n\n"); + debug("Using default environment\n\n"); } if (himport_r(&env_htab, (char *)default_environment,
Since we have global messages to indicate what's going on, the custom messages in the environment drivers only make the output less readable. Make the common code play a little nicer by removing all the extra output in the standard case. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- env/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)