diff mbox series

[v11,25/29] CI: add qemu_arm64_lwip to the test matrix

Message ID b7cc4bc4d5aea1310401c107f7836a9eadd6a493.1727968902.git.jerome.forissier@linaro.org
State New
Headers show
Series Introduce the lwIP network stack | expand

Commit Message

Jérôme Forissier Oct. 3, 2024, 3:46 p.m. UTC
Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight
IP (lwIP) implementation of the dhcp, tftpboot and ping commands.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 .azure-pipelines.yml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Ilias Apalodimas Oct. 4, 2024, 6:05 a.m. UTC | #1
On Thu, 3 Oct 2024 at 18:47, Jerome Forissier
<jerome.forissier@linaro.org> wrote:
>
> Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight
> IP (lwIP) implementation of the dhcp, tftpboot and ping commands.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  .azure-pipelines.yml | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> index 93111eb6127..59fddb96a48 100644
> --- a/.azure-pipelines.yml
> +++ b/.azure-pipelines.yml
> @@ -238,6 +238,10 @@ stages:
>            cd \${WORK_DIR}
>            git config --global --add safe.directory \${WORK_DIR}
>            git clone --depth=1 https://source.denx.de/u-boot/u-boot-test-hooks /tmp/uboot-test-hooks
> +          # qemu_arm64_lwip_defconfig is the same as qemu_arm64 but with NET_LWIP enabled.
> +          # The test config and the boardenv file from qemu_arm64 can be re-used so create symlinks
> +          ln -s conf.qemu_arm64_na /tmp/uboot-test-hooks/bin/travis-ci/conf.qemu_arm64_lwip_na
> +          ln -s u_boot_boardenv_qemu_arm64_na.py /tmp/uboot-test-hooks/py/travis-ci/u_boot_boardenv_qemu_arm64_lwip_na.py
>            ln -s travis-ci /tmp/uboot-test-hooks/bin/\`hostname\`
>            ln -s travis-ci /tmp/uboot-test-hooks/py/\`hostname\`
>            grub-mkimage --prefix=\"\" -o ~/grub_x86.efi -O i386-efi normal echo lsefimmap lsefi lsefisystab efinet tftp minicmd
> @@ -415,6 +419,9 @@ stages:
>          qemu_arm64:
>            TEST_PY_BD: "qemu_arm64"
>            TEST_PY_TEST_SPEC: "not sleep"
> +        qemu_arm64_lwip:
> +          TEST_PY_BD: "qemu_arm64_lwip"
> +          TEST_PY_TEST_SPEC: "test_net_dhcp or test_net_ping or test_net_tftpboot"
>          qemu_m68k:
>            TEST_PY_BD: "M5208EVBE"
>            TEST_PY_ID: "--id qemu"
> --
> 2.40.1
>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Tom Rini Oct. 4, 2024, 6:25 p.m. UTC | #2
On Thu, Oct 03, 2024 at 05:46:29PM +0200, Jerome Forissier wrote:
> Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight
> IP (lwIP) implementation of the dhcp, tftpboot and ping commands.
> 
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  .azure-pipelines.yml | 7 +++++++
>  1 file changed, 7 insertions(+)

This should be in .gitlab-ci.yml too. Generally it's close enough to get
without testing (and using the linter if needed), but I'm sure Ilias can
push something through the tpm tree for testing if you want, and we
should get you added to source.denx.de (please go sign up) and access to
the -net tree, really, anyhow.
Jérôme Forissier Oct. 7, 2024, 9 a.m. UTC | #3
On 10/4/24 20:25, Tom Rini wrote:
> On Thu, Oct 03, 2024 at 05:46:29PM +0200, Jerome Forissier wrote:
>> Build and run qemu_arm64_lwip_defconfig in CI. This tests the lightweight
>> IP (lwIP) implementation of the dhcp, tftpboot and ping commands.
>>
>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>> ---
>>  .azure-pipelines.yml | 7 +++++++
>>  1 file changed, 7 insertions(+)
> 
> This should be in .gitlab-ci.yml too.

Updated in v12.

> Generally it's close enough to get
> without testing (and using the linter if needed), but I'm sure Ilias can
> push something through the tpm tree for testing if you want, and we
> should get you added to source.denx.de (please go sign up) and access to
> the -net tree, really, anyhow.

I have registered on source.denx.de.

Thanks Tom,
diff mbox series

Patch

diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index 93111eb6127..59fddb96a48 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -238,6 +238,10 @@  stages:
           cd \${WORK_DIR}
           git config --global --add safe.directory \${WORK_DIR}
           git clone --depth=1 https://source.denx.de/u-boot/u-boot-test-hooks /tmp/uboot-test-hooks
+          # qemu_arm64_lwip_defconfig is the same as qemu_arm64 but with NET_LWIP enabled.
+          # The test config and the boardenv file from qemu_arm64 can be re-used so create symlinks
+          ln -s conf.qemu_arm64_na /tmp/uboot-test-hooks/bin/travis-ci/conf.qemu_arm64_lwip_na
+          ln -s u_boot_boardenv_qemu_arm64_na.py /tmp/uboot-test-hooks/py/travis-ci/u_boot_boardenv_qemu_arm64_lwip_na.py
           ln -s travis-ci /tmp/uboot-test-hooks/bin/\`hostname\`
           ln -s travis-ci /tmp/uboot-test-hooks/py/\`hostname\`
           grub-mkimage --prefix=\"\" -o ~/grub_x86.efi -O i386-efi normal echo lsefimmap lsefi lsefisystab efinet tftp minicmd
@@ -415,6 +419,9 @@  stages:
         qemu_arm64:
           TEST_PY_BD: "qemu_arm64"
           TEST_PY_TEST_SPEC: "not sleep"
+        qemu_arm64_lwip:
+          TEST_PY_BD: "qemu_arm64_lwip"
+          TEST_PY_TEST_SPEC: "test_net_dhcp or test_net_ping or test_net_tftpboot"
         qemu_m68k:
           TEST_PY_BD: "M5208EVBE"
           TEST_PY_ID: "--id qemu"