From patchwork Fri Aug 23 13:48:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Forissier X-Patchwork-Id: 821715 Delivered-To: patch@linaro.org Received: by 2002:adf:e044:0:b0:367:895a:4699 with SMTP id w4csp386847wrh; Fri, 23 Aug 2024 06:51:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVhZ8l2DxC3oWpz+14vs2c03puewUm6RMGpCt/CPCWBE+OhdJmR2PS8P96JuT1lPCrV32mGmQ==@linaro.org X-Google-Smtp-Source: AGHT+IGQVvl50ttAzFp0wvoJFooymBtdgNeMJc+gwNZq/YZN6+neTe1NzDm2NOXbm/uzr+wB2CIP X-Received: by 2002:a05:6000:18d:b0:368:3f04:d5b with SMTP id ffacd0b85a97d-3731185ae8cmr1261351f8f.25.1724421060360; Fri, 23 Aug 2024 06:51:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724421060; cv=none; d=google.com; s=arc-20160816; b=XpMF0e4hyCxuuVeREhYTNGzeyddm9b3PvtZWv8RxnsDnjMGJhHoY1Dr59slNmehx42 hiteqTG7E0W1XcjqwzhdEwh7oreQ53okQgV15k1BebksU2OYC5h8NHLHpMo3H1qicQBM +4syxjTySKib66gY9ZnLMQ6QrORzGWWp0giY4AgoZMoCZlqVvf9QrzVgpUqHf7+BhpuQ HN1MjYO+UpglbAj+e27Pa7K3oSatwWGp9xMgoJyFedTXhmTRGjCJD8VnjNGHpwoSPNDt NOGhz41kPLSJ2WaHs1OPNKutsIVxy893KP7fXzuteJiddVBKlN02POOq4Y0GiKRJtEGR u+Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Drt734jtNXjt1i15GA8hE9TCdNeg4g5UkVsQ668keI0=; fh=bDmf1hIB/fYfmYbF7FRerbBaeBT6RLqYlmYkTMiXYa0=; b=eAkJ8wesoa3c2TvmbntcrZTEyHh7ZTxepIi9a5YIe+DuqceT7UvK2s479fFkRmIdEa moPpUmM7Wql329iR8BQInNqUtBkGRtq2iu7rGGpU0sYy4bdAidrOTtiL3tO3COtrZVCa dHZdp8eWxpieRXYN8ntv4bPCpJ2iZYWX0Wpv1llAriGvyzo6ZG33wpB5Dq8F6vVlZ23P noEUw9HxKWOwQeBQV2Z+bt7ac4XRnrZ+TPo4kMHfvgDc9sxqVjeRbhyz7Fe/2ntA0fsT AWgEwR2/8nIXyFo21u3rdiRxvjF4a5zWj16qY8nn7SUBRWu2d6Q1QiiRrX+iEnFzEJv4 FP5g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qCQfOrGN; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id ffacd0b85a97d-3730811811esi1576208f8f.148.2024.08.23.06.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 06:51:00 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qCQfOrGN; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D3FBF88ABF; Fri, 23 Aug 2024 15:49:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qCQfOrGN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4BE49889EF; Fri, 23 Aug 2024 15:49:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 526D4886E7 for ; Fri, 23 Aug 2024 15:49:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jerome.forissier@linaro.org Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3718706cf8aso1014585f8f.3 for ; Fri, 23 Aug 2024 06:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724420960; x=1725025760; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Drt734jtNXjt1i15GA8hE9TCdNeg4g5UkVsQ668keI0=; b=qCQfOrGNufLPypM5XM1+per0euSg5Ln0VlqJoLkOTOUqvnfWnvhqCmgxNDYliSE9Yx UY2LslG1r8Xa683lTdHGYNooZQRu9rKBLPHMLs4rtKBeIrl6qvWD2edmxX70gJPXE1Mz jBmuL6cz5n+cmkwohqi4NNMVXnLI1cB9uInycl6789xF8XHs+cRKc74SzX2UUCUG07TC hmBHSw6Jv1MZQqEjUOgHJGS02lMX7pZCxkix5tWI0AnP1TYocq71Xn7p9UmmOI5XtAqG VdaCAtYM4sHLSmJqXyVMUdfYeX3bqtlzc3IzZ2E0vvLCRadBncsl62kSrh54tVdVP5ET tuYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724420960; x=1725025760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Drt734jtNXjt1i15GA8hE9TCdNeg4g5UkVsQ668keI0=; b=BNPpbs912aGtVbzLQaJuRFtBsbEti16ro71wadH/hmQvkNAC53PHcfPC1d/bZBH1Q0 qvv2LxLlULgAUWC6TxYZp5iwmhSlnGbk2n/SV2uLdn93zOErjzeh/itGIWmWk5dXB798 ebDvSr4tCrSrAVMhXYHntE9v4yk7lcuMhmTJaHGPSrTlcpbDDNg8H9EumUYEpvnr28TV vycAAsDgzhCahUaAawNny8IxGP36bnDg/C0F5NJ/xvxxT2gRaUm2+vrhleIVHOwKH1Y6 F7LjuhJ7ZKLTh7VlXLkqfWD4E2NGZoPfUpkx3XRyBh2ABhIHzZsNa0EjvOty3NQr4uYu FtXQ== X-Gm-Message-State: AOJu0YwApBsmiAa4fxTbM5v9wu4aWvT4pf5MFWA9MIS5pU3EEjFNGjLW H7UhSkgDUqwNMvZZRQcD+aTCYa/mWX62J3bxdshQX4vWRRleegX+Gy2VvNIBs5Le6G4mvgQiYaX FCApfxkre X-Received: by 2002:a5d:68cc:0:b0:371:8eea:24b4 with SMTP id ffacd0b85a97d-373118e4170mr1405025f8f.61.1724420960513; Fri, 23 Aug 2024 06:49:20 -0700 (PDT) Received: from builder.. ([2a01:e0a:3cb:7bb0:e668:dc94:35c7:8064]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-373081ffb40sm4201665f8f.76.2024.08.23.06.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2024 06:49:20 -0700 (PDT) From: Jerome Forissier To: u-boot@lists.denx.de Cc: Ilias Apalodimas , Javier Tia , Raymond Mao , Maxim Uvarov , Tim Harvey , Anton Antonov , Jerome Forissier , Fabio Estevam , Joe Hershberger , Ramon Fried , Tom Rini , Ye Li Subject: [PATCH v9 10/37] net: fec_mxc_init(): do not ignore return status of fec_open() Date: Fri, 23 Aug 2024 15:48:14 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The fec_mxc_init() function currently always returns 0. This does not allow the callers to detect when for instance the PHY initialization failed due to the port being unconnected. Fix that by returning the status of fec_open(). Signed-off-by: Jerome Forissier Reviewed-by: Fabio Estevam --- drivers/net/fec_mxc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 0a0d92bc2cd..2dc1364beec 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -615,8 +615,7 @@ static int fecmxc_init(struct udevice *dev) if (fec->xcv_type != SEVENWIRE) miiphy_restart_aneg(dev); #endif - fec_open(dev); - return 0; + return fec_open(dev); } /**