From patchwork Mon Dec 19 07:43:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 88429 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp1030547qgi; Sun, 18 Dec 2016 23:43:27 -0800 (PST) X-Received: by 10.28.184.88 with SMTP id i85mr11541670wmf.49.1482133407235; Sun, 18 Dec 2016 23:43:27 -0800 (PST) Return-Path: Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id jt9si17442807wjb.163.2016.12.18.23.43.26; Sun, 18 Dec 2016 23:43:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2B09BA75FD; Mon, 19 Dec 2016 08:43:26 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hHU6h5bJgurD; Mon, 19 Dec 2016 08:43:25 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 811AEA75C3; Mon, 19 Dec 2016 08:43:25 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 08ADAA75C3 for ; Mon, 19 Dec 2016 08:43:21 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xC4EcDsLhg4v for ; Mon, 19 Dec 2016 08:43:20 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by theia.denx.de (Postfix) with ESMTPS id 4C4F7A75BF for ; Mon, 19 Dec 2016 08:43:16 +0100 (CET) Received: from mail-yb0-f181.google.com (mail-yb0-f181.google.com [209.85.213.181]) (authenticated) by conssluserg-01.nifty.com with ESMTP id uBJ7h3NI005990 for ; Mon, 19 Dec 2016 16:43:04 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com uBJ7h3NI005990 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1482133384; bh=dhscLDxnD7SvgIzJ8/Q+xIIV7dstUtoja5L2t0GKHug=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=MAPCFDrQYla4caVcbawGDNbWYI9UCN2N1HxTVKYExuQ2I0WEj9nHxrWBHts5GSpbi 4kLHbS9uagdc4gOsJ7fCO3lLE7MjnGp8GKxkbAvkKncD6Ardg/l6fL/o+xajQV8fJh B2t3JgwYTRcsL2Khy5IkZ7atq4/TWTCdcTD0Jd72JxqqUdE6lwed9VVcBPza6DcnLx wLlLRMAa6ZfOSuQZv5ak0vYdIDm3BKo1psYBwyEHZ7lEjCH4LkEulztq4xwy0AOwz0 B4F+aLQxmr40ksN8gI4qKB6djPBAFcMZ1yNtRw/AtTr/NoR+5Rx8+TKtBBlrMDx4Bv 7XGpFO4mtVacw== X-Nifty-SrcIP: [209.85.213.181] Received: by mail-yb0-f181.google.com with SMTP id d59so55179432ybi.1 for ; Sun, 18 Dec 2016 23:43:04 -0800 (PST) X-Gm-Message-State: AIkVDXKLYCvUDJzVoz7OwK5S2ENT7ZGpNmCYC4M+T1a5FJqqLjAm+cQVA0Oh/UOmtzHNF2zMbxnqYtZ7bfICIw== X-Received: by 10.37.68.131 with SMTP id r125mr377872yba.7.1482133383000; Sun, 18 Dec 2016 23:43:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.108.196 with HTTP; Sun, 18 Dec 2016 23:43:02 -0800 (PST) In-Reply-To: <1479587152-25065-4-git-send-email-sjg@chromium.org> References: <1479587152-25065-1-git-send-email-sjg@chromium.org> <1479587152-25065-4-git-send-email-sjg@chromium.org> From: Masahiro Yamada Date: Mon, 19 Dec 2016 16:43:02 +0900 X-Gmail-Original-Message-ID: Message-ID: To: Simon Glass Cc: U-Boot Mailing List Subject: Re: [U-Boot] [PATCH v2 03/63] spl: Makefile: Define SPL_ earlier X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Hi Simon, 2016-11-20 5:24 GMT+09:00 Simon Glass : > This Makefile variable can be used in the architecture's main Makefile but > at present it is not set up until later. Set it just before this Makefile is > included. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > scripts/Makefile.spl | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > index 03a2f06..f490e29 100644 > --- a/scripts/Makefile.spl > +++ b/scripts/Makefile.spl > @@ -35,6 +35,12 @@ else > SPL_BIN := u-boot-spl > endif > > +ifdef CONFIG_SPL_BUILD > +SPL_ := SPL_ > +else > +SPL_ := > +endif > + > include $(srctree)/config.mk > include $(srctree)/arch/$(ARCH)/Makefile > In scripts/Makefile.spl, CONFIG_SPL_BUILD is always defined. So, I think your patch is equivalent to: > SPL_BIN := u-boot-spl > endif > > +SPL_ := SPL_ > + > include $(srctree)/config.mk > include $(srctree)/arch/$(ARCH)/Makefile But, more simply, does the following patch work for you? (just move Kbuild.include below autoconf.mk) -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index f379713..90fea0a 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -19,11 +19,11 @@ src := $(obj) # Create output directory if not already present _dummy := $(shell [ -d $(obj) ] || mkdir -p $(obj)) -include $(srctree)/scripts/Kbuild.include - -include include/config/auto.conf -include $(obj)/include/autoconf.mk +include $(srctree)/scripts/Kbuild.include + KBUILD_CPPFLAGS += -DCONFIG_SPL_BUILD ifeq ($(CONFIG_TPL_BUILD),y) KBUILD_CPPFLAGS += -DCONFIG_TPL_BUILD