diff mbox series

[07/13] net: phy: ncsi: depend on NET

Message ID 898bcb397c26f6eb7b0750b91c6c6ad2783d5195.1724846454.git.jerome.forissier@linaro.org
State Superseded
Headers show
Series Miscellaneous fixes | expand

Commit Message

Jerome Forissier Aug. 28, 2024, 12:10 p.m. UTC 
PHY_NCSI enables drivers/net/phy/ncsi.c which calls net_loop() and
net_set_timeout_handler(). That's the legacy NET stack (as opposed to
NET_LWIP). Therefore add the dependency to Kconfig.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 drivers/net/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Ilias Apalodimas Aug. 29, 2024, 7:33 a.m. UTC | #1 
On Wed, 28 Aug 2024 at 15:10, Jerome Forissier
<jerome.forissier@linaro.org> wrote:
>
> PHY_NCSI enables drivers/net/phy/ncsi.c which calls net_loop() and
> net_set_timeout_handler(). That's the legacy NET stack (as opposed to
> NET_LWIP). Therefore add the dependency to Kconfig.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  drivers/net/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index 73064b2af6..a9efc50981 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -368,6 +368,7 @@ config PHY_FIXED
>
>  config PHY_NCSI
>         bool "NC-SI based PHY"
> +       depends on NET
>
>  endif #PHYLIB
>
> --
> 2.40.1
>

This sounds like that should be fixed on the phy driver if we want to use LWIP
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 73064b2af6..a9efc50981 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -368,6 +368,7 @@  config PHY_FIXED
 
 config PHY_NCSI
 	bool "NC-SI based PHY"
+	depends on NET
 
 endif #PHYLIB