From patchwork Thu Jul 25 12:57:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Forissier X-Patchwork-Id: 814343 Delivered-To: patch@linaro.org Received: by 2002:adf:e641:0:b0:367:895a:4699 with SMTP id b1csp379162wrn; Thu, 25 Jul 2024 05:58:52 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXjYpF9apT7MptwOKZTCBEESSgANER1lxlCmNN1dDS0gnNlPru2AHivve3P/BgNAyWIN0e+Jca0g6zODehq6B7W X-Google-Smtp-Source: AGHT+IHFBT/87MEdwuhmmvOlPqP9R2U9W+7PjVJpH/TGPVWKDvgys86qEsPU9Hcg2NItEXaOSSOc X-Received: by 2002:a05:6512:3053:b0:52e:fd57:fd0e with SMTP id 2adb3069b0e04-52fd3efefd7mr1753577e87.17.1721912332176; Thu, 25 Jul 2024 05:58:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721912332; cv=none; d=google.com; s=arc-20160816; b=Rn5bshgGVjKAy7M8WS7qEEfXCBA/nJql9l6ppbenZrZMERMKgrbStAdhAlr+L1uBFQ 0h/ANDtwCTfS+fAHJKRhiYAFz5Ku81ZO+kSlOWROKWxknyMgKtsqfng9DuL/dfUr8RXi 8/6mpKlmeqN0abXk9hWDgAoH8YbPP8BcDAenzZVE0kBFk45j6i7HLhMRejFTrGHjBB55 OH1a8E2ueU/v2zFu6naFrSqPQst5oPBzl7davDczECzPRBPAFnPeyHvRZc4mWQ+dV1Bc udou3zI2URC7JRfgS1blaGfzPSubAgVDyjdOuQNx2hsIp6mxep85fmebLt/uwxiX5BU0 y34w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pDoaqxi/pyuwz1Jij51+SeQNLYun2RqMvJ8lA1MifIY=; fh=yDIGkzbfkFtsl+k0xrhkr0CCD90+NmK2KbH/nYMhrS8=; b=cOPNALPYd7R3CCmnivaTIbYGnjf9Z0hiS2GmTf3E+pZoBhpmS84VXyupCTB8dym/0m yBKYUZhwxuI+rSq0GoHgf6uAPJcE1mlAJV8pMoH6kknjhOTeogOMz7CAjacs91EPKJwW kuaKPozG3fmdSvMr4kT++p/qgwhED+Vw+V/JH/JqTTr/apcbSs86z6HM+CRuZnvTF0dv Mu6x5ctl35Gd+FL2tTJMHE0oZvmr1Q4e4yHcDBXLLJJtAwcvnuYxNDOCdHVSC0SnyS7E fWApjhRSNyQlVLNw0HmVOs5n5NouZ3h1nUtIrehwXm3e1xGbMwdbxf80Y5ShHxxcf/y8 NQ5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ac404qih; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id 2adb3069b0e04-52fd5c05e9asi452917e87.532.2024.07.25.05.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 05:58:52 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ac404qih; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 042F5880D1; Thu, 25 Jul 2024 14:58:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Ac404qih"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AFD21881C3; Thu, 25 Jul 2024 14:58:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59B17880DE for ; Thu, 25 Jul 2024 14:58:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jerome.forissier@linaro.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-427fc97a88cso7062615e9.0 for ; Thu, 25 Jul 2024 05:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721912324; x=1722517124; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pDoaqxi/pyuwz1Jij51+SeQNLYun2RqMvJ8lA1MifIY=; b=Ac404qihlR6H2yJ7CYLV+sdD0KAw/Y4IrxDtcahLwNR888OfcJvhI2TcycSOFURiHM EmGb/7SWaIZbVdhwaxEg3S5oM/6DPt+rzmp6NNquUwT0kPXJIVUp7Y6xF7pVfOlY7bZw zrI5X1/cZvCdJ++0wu/gQDvT4IDSIrEI1x58WFZaj99Qvn9fz3tbbpeu5zKBnA8/E/Jn C8ktxFST2Rjy0STzvDqyirakSsLTSePyZdNiab1mqqiXWyvdr6RD8Ag12RYtIoeegfTH 7jtXreUGGvTDHc8k2Nh9Iv440XQ51uElwkSPEFAfqBeFeoE5XEP0h7AscQn877VqKfoo sWJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721912324; x=1722517124; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pDoaqxi/pyuwz1Jij51+SeQNLYun2RqMvJ8lA1MifIY=; b=M/jQrjvyqH4ttjKMnxoCnS3wCSxSFkH2c441K1tAEaDZVRRfizfkaKMDP0HPKtmENL vBEbNCUim+xPGd1MGj+MlkJBK9bKqEdcZkIjAToyit267U0/tEJBnnBzlUb1mWZaZlpa Vwl1zczX8KNGWxq7YXpdTrrya7poqXOVVTxfEMSalbmssiYECMP6sbB/230FkxrWbhpJ 2IRKQYU/uIS8L4gJdSvFwZan4g0uikQWVh/+bKsBPHVQeW51LLajT6u8+n0tSxkQjSZX 9CRmDUc4m2nwAuXynddBtWv2DHBvPw8B+Jus+HHvOFAjMnkvNgCJWw1tq2BCWvI8PSLw bnOg== X-Gm-Message-State: AOJu0Yx3XpH91Iu3QK6OMwERYN0Q1LMt4LX4A0U/okDiPWL9BpuAwHtk SENanZ5BqUZDX3rKaAWP0i5sz57jeMjh/YRdZ4whN6yrcfEF0cYDzJzzEt87WKv6iizZstEUDPR itZUs4g== X-Received: by 2002:a05:600c:3591:b0:426:67ad:38e3 with SMTP id 5b1f17b1804b1-428055040abmr14082165e9.3.1721912324734; Thu, 25 Jul 2024 05:58:44 -0700 (PDT) Received: from builder.. ([2a01:e0a:3cb:7bb0:a701:ef5f:d613:3e14]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4280573fd83sm34765205e9.19.2024.07.25.05.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 05:58:44 -0700 (PDT) From: Jerome Forissier To: u-boot@lists.denx.de Cc: Ilias Apalodimas , Javier Tia , Raymond Mao , Maxim Uvarov , Jerome Forissier , Joe Hershberger , Ramon Fried , Tom Rini , Ye Li Subject: [PATCH v5 04/20] net: fec_mxc_init(): do not ignore return status of fec_open() Date: Thu, 25 Jul 2024 14:57:25 +0200 Message-Id: <7498fdd49878a29603e539354dad982a6fd3f049.1721910373.git.jerome.forissier@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The fec_mxc_init() function currently always returns 0. This does not allow the callers to detect when for instance the PHY initialization failed due to the port being unconnected. Fix that by returning the status of fec_open(). Signed-off-by: Jerome Forissier --- drivers/net/fec_mxc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 0a0d92bc2cd..2dc1364beec 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -615,8 +615,7 @@ static int fecmxc_init(struct udevice *dev) if (fec->xcv_type != SEVENWIRE) miiphy_restart_aneg(dev); #endif - fec_open(dev); - return 0; + return fec_open(dev); } /**