From patchwork Fri Aug 2 16:26:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Forissier X-Patchwork-Id: 816254 Delivered-To: patch@linaro.org Received: by 2002:adf:e00d:0:b0:367:895a:4699 with SMTP id s13csp351707wrh; Fri, 2 Aug 2024 09:28:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWZgCUitiqSOPSpXIlfs9xFh82vYS+p8RXaHVBqdTvBJziy9rCnqLvQrwjFVtiN3Z9fZLD2RNYtDlsc4aJwwnQt X-Google-Smtp-Source: AGHT+IG7aKAIBc5joaqQnHI/vFLkuPRVugGQbfhuZDSBqbebedNR1BuR+X4Xr+kfOQjL9o3zLEVH X-Received: by 2002:a05:6402:60f:b0:5b9:462d:c53b with SMTP id 4fb4d7f45d1cf-5b9462dc749mr600165a12.3.1722616098278; Fri, 02 Aug 2024 09:28:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1722616098; cv=none; d=google.com; s=arc-20160816; b=o8KxPDrGWAY+hBqlhVfW790zfeuzDUd5SaofjokJA12pEu/ubm1u/tPl3q6ZKYdP6j oSOCMJDQpETz9qDwsTZ6+kvGL8d+ThTEs9aLkHE980veLRnZ+kMyD482I09v1qRrV320 s5yZCqxM8bk/qHZvo62NeLT/ZIcwRDm/pJrwYkpBFmpVlx7nI9ZudjefvIGnRVCdykc0 b9xfNGJ89rLaeM0fmZHHLpYR9b5+x5rQjF0YwbiKdgSo44yMt/ERwuLpIq36VaPiptk4 6DmnTQeiDIdV2xHOGAwHbOiKQONjNc53f+Jk6M37NR0jliyNYAimwDp5/QtbnMo7PquH lJaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pDoaqxi/pyuwz1Jij51+SeQNLYun2RqMvJ8lA1MifIY=; fh=/pPnBeACjnr4SScD5apCjdqwBo6xUTZp8Ka5MMfU8gQ=; b=LLoxtIxUY2Ldoiv12O2T0Exz2RJCYdR0sGx1JJsNPzyIu8udJKcI3XNqrg3YkjBKkc /Y5tL73ffrStScHLAjnlNmoU39DmSOqswpJFnPMo7m+cpYm/0+zKGCGAqAdVU58LltYN CJjr2DKaEqCHyYtD3Ai88uBrrYnyQ92rM+oOloJno3buBXDIf5SS5r5eXxgBSQ36LTzs 6V1r8O3LUeK36o+mVJEbpOUvOwP2Fn2XuMTo5Hlh5X0oBFLva9yaB6KLn4QCpGPKIoyd dBIB+VHNtHRMn6+kGkgxa0B/3ywMVnFjO2H1qVj7NA7Z1J9Pyu7a7mS7tL+wJd8EFIED BE2w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gvcBd8Cz; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5b83cc17663si1232366a12.654.2024.08.02.09.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 09:28:18 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gvcBd8Cz; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D206788BCB; Fri, 2 Aug 2024 18:28:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="gvcBd8Cz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E54A88BDA; Fri, 2 Aug 2024 18:28:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81CC988BCC for ; Fri, 2 Aug 2024 18:28:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jerome.forissier@linaro.org Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-368f92df172so4181712f8f.2 for ; Fri, 02 Aug 2024 09:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722616089; x=1723220889; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pDoaqxi/pyuwz1Jij51+SeQNLYun2RqMvJ8lA1MifIY=; b=gvcBd8CzyKIzppqTpR6cQJu9gJ1056eCkvZB3KOOG+wZnuBACj0B5cefoH0ucP/Jhv +BbSF8pNCZsemjuWaDZkXsJlGQiWxsn+Sxv3iNVgBPiVG01jjTg6a3ME6HReaupo//t3 l7qDS4xSq3f7H+xyP+BigdBDQ4f93cpUvVlbAS8tsIXEjoCiPq+EbiCu+KweEfidAII2 qxMT14KLXMnivIMXvReD1r1CKHy2XsZYQpx3oVtTn81ojYxQ4Eew3g/FcadMP4Rypkx0 +m0mSi35LB8y2B0CGR4m6+YA2CUOeKVFZ//lLNOSxHXBsdJRXzr1eRJH+v+1G/DlZnse 7O7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722616089; x=1723220889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pDoaqxi/pyuwz1Jij51+SeQNLYun2RqMvJ8lA1MifIY=; b=xTW18MsPFEgmPHV8hPMKICPDRaUPXenw2A1OqN7jZA+vIcDJQJtXVdOFIBHFVp7Als ucJlprbZOfITvg9XVeM2TTS1e8dAPGrJHGP6HhpC+F3S2GzJBbFQ1eO3xE/ZrdK8nuno warBD+lj5S47/drmdfygsHBFuPBauurmZtQb8eyjC0daT78rlz9mtXDCCDXxCk6dYppY joROhdIOmjWK6G7xZlm2aflbtqJuicLwJqBsTUSwqBxguS7yBNL46491nNrx2vWUeMtP xp3qsoFap90S7A/2k70E87M8KNF7fXk+gYCWZEr+KxjMlnHfemMsSBpUEtzdp+mkt2Mx qb0g== X-Gm-Message-State: AOJu0YxohZnfpc3Zcgx5iibjPw5c9reng5qUHiTPu9j+cVHlyxwPug3v LCi9YyDUu/tg7JtU62u732ThaYkaQ5AjXiYzLZLyR9PLRFsMFQXqfqLxwBLE4q4mNt/lY93Vily IduzNfyas X-Received: by 2002:a5d:5101:0:b0:367:9575:2820 with SMTP id ffacd0b85a97d-36bbc14ada2mr2118112f8f.45.1722616089274; Fri, 02 Aug 2024 09:28:09 -0700 (PDT) Received: from builder.. ([2a01:e0a:3cb:7bb0:4fc9:a3ab:c134:cdf4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd01b5c4sm2297783f8f.42.2024.08.02.09.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 09:28:09 -0700 (PDT) From: Jerome Forissier To: u-boot@lists.denx.de Cc: Ilias Apalodimas , Javier Tia , Raymond Mao , Maxim Uvarov , Tim Harvey , Jerome Forissier , Joe Hershberger , Ramon Fried , Tom Rini , Ye Li Subject: [PATCH v7 04/20] net: fec_mxc_init(): do not ignore return status of fec_open() Date: Fri, 2 Aug 2024 18:26:31 +0200 Message-Id: <441dfcd637923a0b3f405db351ad0ddb4e7370f3.1722615735.git.jerome.forissier@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The fec_mxc_init() function currently always returns 0. This does not allow the callers to detect when for instance the PHY initialization failed due to the port being unconnected. Fix that by returning the status of fec_open(). Signed-off-by: Jerome Forissier --- drivers/net/fec_mxc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 0a0d92bc2cd..2dc1364beec 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -615,8 +615,7 @@ static int fecmxc_init(struct udevice *dev) if (fec->xcv_type != SEVENWIRE) miiphy_restart_aneg(dev); #endif - fec_open(dev); - return 0; + return fec_open(dev); } /**