[v2,02/14] usb: gadget: Document USBNET_DEVADDR

Message ID	43ab077d82b6e435211df18ccc9f36be24d795a1.1505242834.git-series.maxime.ripard@free-electrons.com
State	Accepted
Commit	74e7997c70d80e4b3de0622fbff3e75f72b8c1ce
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; From: Maxime Ripard <maxime.ripard@free-electrons.com> To: Tom Rini <trini@konsulko.com>, Jagan Teki <jagan@openedev.com> Date: Tue, 12 Sep 2017 21:01:30 +0200 Message-Id: <43ab077d82b6e435211df18ccc9f36be24d795a1.1505242834.git-series.maxime.ripard@free-electrons.com> In-Reply-To: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com> References: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com> In-Reply-To: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com> References: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, marex@denx.de, u-boot@lists.denx.de, Maxime Ripard <maxime.ripard@free-electrons.com> Subject: [U-Boot] [PATCH v2 02/14] usb: gadget: Document USBNET_DEVADDR Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	sunxi: convert musb to the device model and enable usb_ether \| expand [v2,00/14] sunxi: convert musb to the device model and enable usb_ether [v2,01/14] usb: gadget: Move USBNET_DEVADDR option out of g_dnl [v2,02/14] usb: gadget: Document USBNET_DEVADDR [v2,03/14] usb: gadget: Move USBNET_HOST_ADDR to Kconfig [v2,04/14] usb: gadget: Convert USB_ETHER to Kconfig [v2,05/14] usb: gadget: usb_ether: Move the interfaces to Kconfig [v2,06/14] usb: gadget: Make g_dnl USB settings common [v2,07/14] usb: gadget: usb_ether: Move settings to common [v2,08/14] sunxi: provide default USB gadget setup [v2,09/14] sunxi: imply USB_GADGET [v2,10/14] cmd: fastboot: Rework fastboot dependency [v2,11/14] musb: sunxi: switch to the device model [v2,12/14] sunxi: Register usb_ether [v2,13/14] sunxi: Imply USB_ETHER [v2,14/14] sunxi: sina33: Sync the device tree with the kernel

Message ID

43ab077d82b6e435211df18ccc9f36be24d795a1.1505242834.git-series.maxime.ripard@free-electrons.com

State

Accepted

Commit

74e7997c70d80e4b3de0622fbff3e75f72b8c1ce

Headers

Received-SPF: pass (google.com: best guess record for domain of
	u-boot-bounces@lists.denx.de designates 81.169.180.215 as
	permitted sender) client-ip=81.169.180.215; 
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Tom Rini <trini@konsulko.com>,
	Jagan Teki <jagan@openedev.com>
Date: Tue, 12 Sep 2017 21:01:30 +0200
Message-Id: <43ab077d82b6e435211df18ccc9f36be24d795a1.1505242834.git-series.maxime.ripard@free-electrons.com>
In-Reply-To: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com>
References: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com>
In-Reply-To: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com>
References: <cover.afe89ac52a0b82d1c12952c3cb82bb3762c85fa8.1505242834.git-series.maxime.ripard@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, marex@denx.de,
	u-boot@lists.denx.de, Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: [U-Boot] [PATCH v2 02/14] usb: gadget: Document USBNET_DEVADDR
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

sunxi: convert musb to the device model and enable usb_ether | expand

Add an help about the USBNET_DEVADDR Kconfig option to make it clearer what it's about. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/usb/gadget/Kconfig | 3 +++ 1 file changed, 3 insertions(+)

Comments

Simon Glass Sept. 13, 2017, 4:27 a.m. UTC | #1

On 12 September 2017 at 13:01, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Add an help about the USBNET_DEVADDR Kconfig option to make it clearer what
> it's about.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>  drivers/usb/gadget/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Lukasz Majewski Sept. 13, 2017, 10:37 a.m. UTC | #2

On 09/12/2017 09:01 PM, Maxime Ripard wrote:
> Add an help about the USBNET_DEVADDR Kconfig option to make it clearer what
> it's about.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>   drivers/usb/gadget/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index d52626908846..6dc9d177f5ad 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -124,5 +124,8 @@ endif # USB_GADGET_DOWNLOAD
>   config USBNET_DEVADDR
>   	string "USB Gadget Ethernet device mac address"
>   	default "de:ad:be:ef:00:01"
> +	help
> +	  Ethernet MAC address of the device-side (ie. local board's) MAC
> +	  address of the usb_ether interface
>   
>   endif # USB_GADGET
> 

Acked-by: Łukasz Majewski <lukma@denx.de>

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index d52626908846..6dc9d177f5ad 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -124,5 +124,8 @@  endif # USB_GADGET_DOWNLOAD
 config USBNET_DEVADDR
 	string "USB Gadget Ethernet device mac address"
 	default "de:ad:be:ef:00:01"
+	help
+	  Ethernet MAC address of the device-side (ie. local board's) MAC
+	  address of the usb_ether interface
 
 endif # USB_GADGET

[v2,02/14] usb: gadget: Document USBNET_DEVADDR

Commit Message

Comments

Patch