diff mbox series

[3/7] configs: e850-96: Enable more EFI features

Message ID 20250116230130.3337-4-semen.protsenko@linaro.org
State New
Headers show
Series board: samsung: e850-96: Enable Standard Boot | expand

Commit Message

Sam Protsenko Jan. 16, 2025, 11:01 p.m. UTC
The basic EFI support is already enabled by EFI_LOADER. Follow
SystemReady IR recommendations [1,2] for U-Boot and enable support for
more EFI features. That includes:

  - CONFIG_CMD_BOOTEFI_SELFTEST: support for "bootefi selftest" command
  - CONFIG_CMD_NVEDIT_EFI: support for "env -e" to explore EFI vars
  - CONFIG_CMD_EFIDEBUG: support for "efidebug" command

Also enable RTC support:

  - CONFIG_EFI_SET_TIME
  - CONFIG_CMD_RTC
  - CONFIG_DM_RTC
  - CONFIG_RTC_EMULATION

[1] https://developer.arm.com/documentation/DUI1101/1-1/Configure-U-Boot-for-SystemReady
[2] https://developer.arm.com/documentation/DUI1101/1-1/Test-SystemReady-IR

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 configs/e850-96_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Ilias Apalodimas Jan. 17, 2025, 7:17 a.m. UTC | #1
Hi Sam

On Fri, 17 Jan 2025 at 01:01, Sam Protsenko <semen.protsenko@linaro.org> wrote:
>
> The basic EFI support is already enabled by EFI_LOADER. Follow
> SystemReady IR recommendations [1,2] for U-Boot and enable support for
> more EFI features. That includes:
>
>   - CONFIG_CMD_BOOTEFI_SELFTEST: support for "bootefi selftest" command

I know that's on the Arm docs but not really a hard requirement. The
tests will pass without it.

>   - CONFIG_CMD_NVEDIT_EFI: support for "env -e" to explore EFI vars
>   - CONFIG_CMD_EFIDEBUG: support for "efidebug" command
>
> Also enable RTC support:
>
>   - CONFIG_EFI_SET_TIME
>   - CONFIG_CMD_RTC
>   - CONFIG_DM_RTC
>   - CONFIG_RTC_EMULATION
>
> [1] https://developer.arm.com/documentation/DUI1101/1-1/Configure-U-Boot-for-SystemReady
> [2] https://developer.arm.com/documentation/DUI1101/1-1/Test-SystemReady-IR
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
>  configs/e850-96_defconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/configs/e850-96_defconfig b/configs/e850-96_defconfig
> index d287018ec632..1cae252175be 100644
> --- a/configs/e850-96_defconfig
> +++ b/configs/e850-96_defconfig
> @@ -14,16 +14,22 @@ CONFIG_DEFAULT_DEVICE_TREE="exynos/exynos850-e850-96"
>  CONFIG_SYS_LOAD_ADDR=0x80000000
>  CONFIG_ENV_OFFSET_REDUND=0x10000
>  # CONFIG_PSCI_RESET is not set
> +CONFIG_EFI_SET_TIME=y
>  CONFIG_ANDROID_BOOT_IMAGE=y
>  # CONFIG_AUTOBOOT is not set
>  CONFIG_DEFAULT_FDT_FILE="exynos850-e850-96.dtb"
>  # CONFIG_DISPLAY_CPUINFO is not set
>  CONFIG_HUSH_PARSER=y
> +CONFIG_CMD_BOOTEFI_SELFTEST=y
>  CONFIG_CMD_ABOOTIMG=y
> +CONFIG_CMD_NVEDIT_EFI=y
>  CONFIG_CMD_CLK=y
>  CONFIG_CMD_GPT=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_PART=y
> +CONFIG_CMD_EFIDEBUG=y
> +# CONFIG_CMD_DATE is not set
> +CONFIG_CMD_RTC=y
>  CONFIG_CMD_TIME=y
>  CONFIG_CMD_RNG=y
>  CONFIG_PARTITION_TYPE_GUID=y
> @@ -36,6 +42,8 @@ CONFIG_NO_NET=y
>  CONFIG_CLK_EXYNOS850=y
>  CONFIG_SUPPORT_EMMC_BOOT=y
>  CONFIG_MMC_DW=y
> +CONFIG_DM_RTC=y
> +CONFIG_RTC_EMULATION=y
>  CONFIG_SOC_SAMSUNG=y
>  CONFIG_EXYNOS_PMU=y
>  CONFIG_EXYNOS_USI=y
> --
> 2.39.5
>

Up to you, but I'd remove CONFIG_CMD_BOOTEFI_SELFTEST
in any case
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/configs/e850-96_defconfig b/configs/e850-96_defconfig
index d287018ec632..1cae252175be 100644
--- a/configs/e850-96_defconfig
+++ b/configs/e850-96_defconfig
@@ -14,16 +14,22 @@  CONFIG_DEFAULT_DEVICE_TREE="exynos/exynos850-e850-96"
 CONFIG_SYS_LOAD_ADDR=0x80000000
 CONFIG_ENV_OFFSET_REDUND=0x10000
 # CONFIG_PSCI_RESET is not set
+CONFIG_EFI_SET_TIME=y
 CONFIG_ANDROID_BOOT_IMAGE=y
 # CONFIG_AUTOBOOT is not set
 CONFIG_DEFAULT_FDT_FILE="exynos850-e850-96.dtb"
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_HUSH_PARSER=y
+CONFIG_CMD_BOOTEFI_SELFTEST=y
 CONFIG_CMD_ABOOTIMG=y
+CONFIG_CMD_NVEDIT_EFI=y
 CONFIG_CMD_CLK=y
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_PART=y
+CONFIG_CMD_EFIDEBUG=y
+# CONFIG_CMD_DATE is not set
+CONFIG_CMD_RTC=y
 CONFIG_CMD_TIME=y
 CONFIG_CMD_RNG=y
 CONFIG_PARTITION_TYPE_GUID=y
@@ -36,6 +42,8 @@  CONFIG_NO_NET=y
 CONFIG_CLK_EXYNOS850=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_DW=y
+CONFIG_DM_RTC=y
+CONFIG_RTC_EMULATION=y
 CONFIG_SOC_SAMSUNG=y
 CONFIG_EXYNOS_PMU=y
 CONFIG_EXYNOS_USI=y