From patchwork Fri Aug 9 00:56:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 818106 Delivered-To: patch@linaro.org Received: by 2002:a5d:5711:0:b0:367:895a:4699 with SMTP id a17csp89602wrv; Thu, 8 Aug 2024 17:58:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW0ZNcn9h/XYgFXsM1u4tre9DXtvnH1Og6MYDLuqqUqpDmXmbNzumYuKayvvmJhkydc5yQnq0K6DO9v4CRb+6Df X-Google-Smtp-Source: AGHT+IH40IO4nBcNSUVbbkHCvko5mOGIUwvn/3k8Q3JV12FDFfn4dmBJu6j2RP8tqBWekgv3rnxX X-Received: by 2002:a2e:9813:0:b0:2ef:2f7d:c502 with SMTP id 38308e7fff4ca-2f1a6d66433mr248101fa.49.1723165094663; Thu, 08 Aug 2024 17:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1723165094; cv=none; d=google.com; s=arc-20160816; b=tloeQcflOOTNnbbHm1X/mv4o/yOfa+aU8P80TUfn1XPJ9LrO/PFam+XKR935UjYD6y fYK+v23k9G9PUyMQhbU9ryW7X6vTB5P74FUqvHKHTiH1lb7f9MorrG+Q72gj2GWy6O38 yXTbZiN4VtwoOJg1tTvevln/MSmD51ws7GhrTQhR6oOTDgSGCMtPjUaVwcGakACDPt/t l245uvDixw33JKY7Ghg1tFwHJH3BehmPA77hWXEYuRrsA9oiV1nyaTUKII3BskPmnFa0 N2VblXjmFCTpjnI6/toaf0HNHbFpY7XkqHDRw0/DWgA7HCDMCp65t05dm8JFq6UvVn1m yXug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=NdgpS2fGbKq3qCEqgboAL3IJ+7tYWgj1dTT5gC8wErI=; fh=4IHTmAhzBb/H3qKUTpFhBlkBFrzLWs3w49sASEQf2aw=; b=ww9bmK/HqdpVktA03ue3H33rWXh7i67hWweFUG0Lk5/DABETMDSbgjfBCoDure/eIO RK67PJZZ9WOR1AtaBHQOg5E87fX3ltBDACjf+QVzXoB2X/UA2zyUocC4ytcGjBN4GOnc zaXrP0RyoRroPkoL8TXYlNMiEUgjTKjbS+FdlFopgpwVwGBkxgEDB71MHGvtju4Yt+az fPnifCsJJHNPEvHDupPMndBvSQpe3nPlz7rihRtVBFVfQRMg/ATU8mrROEtft99AS4BG yxojiWLoCdwzUXLrjUHwAOg6lxDinajMCX7NSNkafR4KHzjCiPjaw1ecT5NP43J0cCST iEag==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E3xYWWda; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5bbb2d229bfsi1398346a12.414.2024.08.08.17.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 17:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E3xYWWda; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B605688C16; Fri, 9 Aug 2024 02:56:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="E3xYWWda"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BB02588BB0; Fri, 9 Aug 2024 02:56:43 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48DFF88C1F for ; Fri, 9 Aug 2024 02:56:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a6135dso2018925a12.1 for ; Thu, 08 Aug 2024 17:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723165001; x=1723769801; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NdgpS2fGbKq3qCEqgboAL3IJ+7tYWgj1dTT5gC8wErI=; b=E3xYWWda8ofIs9vd3xSQuLec/iYCkIEJ7sip9aqd5tN2a2XM8A3qfeVP7UnNM3KoyC OPrT9Ja8NO0fYG/BDTaf03S+2oZvH5fjxusehcuqAhGHe0gvudqtVL28dnCIFpH/uxK2 zSyZNysJEgu4ZBXW3tdcewR3GUqc08idpN/vTfAkxpNnPoA4wm3cxuxHVnWRDh0wAj+o llt+mxV5Dq2IDBpsnfZAF5DrawBLrVpAlHfC+1/1+CVHtH9Qd3mtt+8ikvh1v3aSJRR0 jvYMmuCyFvH97dIsGJvkbk9aUfgCqirb3R5sU4vtuQsld4crc9eqfBO10N6bj7WVvrwX fa9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723165001; x=1723769801; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NdgpS2fGbKq3qCEqgboAL3IJ+7tYWgj1dTT5gC8wErI=; b=KdJbhCgU5MqpBCxhYDSVNHr0g6hTbP/rxBYgo4EbBp9q9KEAstYOy2nMH2zfo+5XZX LKaPbZqLq30sj9QMtTZrb3lLoWtc+PYEWCKucLvwmYIDDrXOE1qhT82Gfn1yNwLNAihj w6wmrUOIBu98qWWT2atbVHS558F61hgWtczezry6MhEKhkzIMfXoJGT+4EusYmDt7PUD Date0AIr8fiZ3NQJyuK8+Rhb+ATwfKAVEHcDU8TRJQrcYNrJhzB7Mnp4K4bSkZ0R9Umk tDitrTiKgQ55qkofQb9XfdVELn6c6iUenY7W8yRyGOqb14yhAWUkvftR/JGmjwZtoGwy 78DA== X-Forwarded-Encrypted: i=1; AJvYcCVMBQbkYj0H2Lw1ivU0nqC7gb+WLIVfbYnhWvNq7syDdg3CyIRoAkPgaOR+YO951/SCXzsVFNxXIxjvcuqfpClLcoXy5g== X-Gm-Message-State: AOJu0Yx2i4E840wvvHiCY2ACFNRBVgPDQHhrZRCbQlfco7+dlHniAdfB xXTtvc9T0hOyZZqfqXwwvymmyhwuptuS6hvlNeqjE7/JMObUo7kVCGu4tDc1EQo= X-Received: by 2002:a17:906:eec1:b0:a77:c26c:a571 with SMTP id a640c23a62f3a-a80aa65ce27mr311666b.54.1723165000563; Thu, 08 Aug 2024 17:56:40 -0700 (PDT) Received: from [192.168.0.113] ([2a02:8109:aa0d:be00::7424]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9e80e54sm790680266b.167.2024.08.08.17.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 17:56:40 -0700 (PDT) From: Caleb Connolly Date: Fri, 09 Aug 2024 02:56:28 +0200 Subject: [PATCH v7 09/11] tools: mkeficapsule: support generating dynamic GUIDs MIME-Version: 1.0 Message-Id: <20240809-b4-dynamic-uuid-v7-9-8c44ab1f06a5@linaro.org> References: <20240809-b4-dynamic-uuid-v7-0-8c44ab1f06a5@linaro.org> In-Reply-To: <20240809-b4-dynamic-uuid-v7-0-8c44ab1f06a5@linaro.org> To: Tom Rini , Heinrich Schuchardt , Ilias Apalodimas , Simon Glass , Mario Six , Alper Nebi Yasak , Abdellatif El Khlifi Cc: Richard Hughes , u-boot@lists.denx.de, Caleb Connolly X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=8305; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=1ZmbfsFZL7+YgnLzHPJx2Z7jaIpmmM85jwfL28p3NJ8=; b=owEBbQKS/ZANAwAIAQWDMSsZX2S2AcsmYgBmtWk9+e44ZDR/tjb0sY3yVQwe/z0JgLSLI8Ljf 9e7is93fTiJAjMEAAEIAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZrVpPQAKCRAFgzErGV9k tkCOD/4uJVoaUhTAAtn4zYWI59uRDZa7deR2/Zm1/Hz7LRA+vNrLZMLEzaBDHYcYx4BJY9fNHhP jljrJu9ShAEldcdjwJL+8j9RTho4L8TFWELs54ZM5dcw76GZ71D3qA8Xu8hzSIDzjKATMymDmDV KozZGJftkARY/1uU47iNeJ9zePKZ/aPJRwuiAxE5Rg47vDloDb2p/Gja/Sr3tJhnI7/t/Bz9QDU rNTX+sTeXV1klSJY5vWIWqeXb3NPfDi1+nGbwxbnjCfmLHYoSysVCQ8xAi7l9h7ckqdaL3HQRVQ c4xLPFNYcvoU3+pPCL2CbxWUL5c4dTLKU1j/5ML9HPboS7HZe1KjrJ5wqqbz/XObyouChcCeiVf JnGWp1FYytZDFQCZsxNfqlIxKg+Q7ua6nszbfUHS8DdT4Bp74gQh94yIiHdxzqyxfkUQimyWu4e jBZs68//bnu7x8D+IqykriWEVIX5/RqLvYmhaAzcl2xsNEVlbvLR54N3QfQjS9Gzqk/uaZDZp3R VuoRZmJJnjib5d1mG8v57YLiY2In0HYL8Erd624NHsLh7k3S6bkT/u/KZDU4xyI+KWRuK+VlBqW 9ogC7eCVsY6kbll9geSNnDWfLuWmQN13bXm4DMLYzqgu2xFvxZhCyjDx4XtAVxh0QcwD6kjXjwX qBZ5YDklEJxGQqg== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Add support for generating GUIDs that match those generated internally by U-Boot for capsule update fw_images when using dynamic UUIDs. Dynamic UUIDs in U-Boot work by taking a namespace UUID and hashing it with the board compatible and fw_image name. This feature just provides a way to determine the UUIDs for a particular board without having to actually boot U-Boot on it. Signed-off-by: Caleb Connolly Acked-by: Ilias Apalodimas --- doc/mkeficapsule.1 | 23 ++++++++ tools/mkeficapsule.c | 156 +++++++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 174 insertions(+), 5 deletions(-) diff --git a/doc/mkeficapsule.1 b/doc/mkeficapsule.1 index c4c2057d5c7a..bf735295effa 100644 --- a/doc/mkeficapsule.1 +++ b/doc/mkeficapsule.1 @@ -9,8 +9,11 @@ mkeficapsule \- Generate EFI capsule file for U-Boot .SH SYNOPSIS .B mkeficapsule .RI [ options ] " " [ image-blob ] " " capsule-file +.B mkeficapsule +.RI guidgen " " [ GUID ] " " DTB " " IMAGE_NAME... + .SH "DESCRIPTION" The .B mkeficapsule command is used to create an EFI capsule file to be used by U-Boot for firmware @@ -41,8 +44,12 @@ format is the same as used in the new uImage format and allows for multiple binary blobs in a single capsule file. This type of image file can be generated by .BR mkimage . +mkeficapsule can also be used to simulate the dynamic GUID generation used to +identify firmware images in capsule updates by providing the namespace guid, dtb +for the board, and a list of firmware images. + .SH "OPTIONS" .TP .BI "-g\fR,\fB --guid " guid-string @@ -112,8 +119,24 @@ at every firmware update. .TP .B "-d\fR,\fB --dump_sig" Dump signature data into *.p7 file +.SH "GUIDGEN OPTIONS" + +.TP +.B "[GUID]" +The namespace/salt GUID, by default this is EFI_CAPSULE_NAMESPACE_GUID. +The format is: + xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx + +.TP +.B DTB +The device tree blob file for the board. + +.TP +.B IMAGE_NAME... +The names of the firmware images to generate GUIDs for. + .PP .SH FILES .TP .I /EFI/UpdateCapsule diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c index 54fb4dee3ee5..8dfc09ffaf4f 100644 --- a/tools/mkeficapsule.c +++ b/tools/mkeficapsule.c @@ -19,12 +19,16 @@ #include #include #include +#include #include #include "eficapsule.h" +// Matches CONFIG_EFI_CAPSULE_NAMESPACE_GUID +#define DEFAULT_NAMESPACE_GUID "8c9f137e-91dc-427b-b2d6-b420faebaf2a" + static const char *tool_name = "mkeficapsule"; efi_guid_t efi_guid_fm_capsule = EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID; efi_guid_t efi_guid_cert_type_pkcs7 = EFI_CERT_TYPE_PKCS7_GUID; @@ -53,11 +57,23 @@ static struct option options[] = { {"help", no_argument, NULL, 'h'}, {NULL, 0, NULL, 0}, }; -static void print_usage(void) + +static void print_usage_guidgen(void) { - fprintf(stderr, "Usage: %s [options] \n" + fprintf(stderr, "%s guidgen [GUID] DTB IMAGE_NAME...\n" + "Options:\n" + + "\tGUID Namespace GUID (default: %s)\n" + "\tDTB Device Tree Blob\n" + "\tIMAGE_NAME... One or more names of fw_images to generate GUIDs for\n", + tool_name, DEFAULT_NAMESPACE_GUID); +} + +static void print_usage_mkeficapsule(void) +{ + fprintf(stderr, "Usage: \n\n%s [options] \n" "Options:\n" "\t-g, --guid guid for image blob type\n" "\t-i, --index update image index\n" @@ -70,10 +86,11 @@ static void print_usage(void) "\t-A, --fw-accept firmware accept capsule, requires GUID, no image blob\n" "\t-R, --fw-revert firmware revert capsule, takes no GUID, no image blob\n" "\t-o, --capoemflag Capsule OEM Flag, an integer between 0x0000 and 0xffff\n" "\t-D, --dump-capsule dump the contents of the capsule headers\n" - "\t-h, --help print a help message\n", + "\t-h, --help print a help message\n\n", tool_name); + print_usage_guidgen(); } /** * auth_context - authentication context @@ -816,8 +833,130 @@ static void dump_capsule_contents(char *capsule_file) exit(EXIT_FAILURE); } } +static struct fdt_header *load_dtb(const char *path) +{ + struct fdt_header *dtb; + ssize_t dtb_size; + FILE *f; + + /* Open and parse DTB */ + f = fopen(path, "r"); + if (!f) { + fprintf(stderr, "Cannot open %s\n", path); + return NULL; + } + + if (fseek(f, 0, SEEK_END)) { + fprintf(stderr, "Cannot seek to the end of %s: %s\n", + path, strerror(errno)); + return NULL; + } + + dtb_size = ftell(f); + if (dtb_size < 0) { + fprintf(stderr, "Cannot ftell %s: %s\n", + path, strerror(errno)); + return NULL; + } + + fseek(f, 0, SEEK_SET); + + dtb = malloc(dtb_size); + if (!dtb) { + fprintf(stderr, "Can't allocated %ld\n", dtb_size); + return NULL; + } + + if (fread(dtb, dtb_size, 1, f) != 1) { + fprintf(stderr, "Can't read %ld bytes from %s\n", + dtb_size, path); + free(dtb); + return NULL; + } + + fclose(f); + + return dtb; +} + +#define MAX_IMAGE_NAME_LEN 128 +static int genguid(int argc, char **argv) +{ + int idx = 2, ret; + unsigned char namespace[16]; + struct efi_guid image_type_id; + const char *dtb_path; + struct fdt_header *dtb; + const char *compatible; + int compatlen, namelen; + uint16_t fw_image[MAX_IMAGE_NAME_LEN]; + + if (argc < 2) { + fprintf(stderr, "Usage: "); + print_usage_guidgen(); + return -1; + } + + if (uuid_str_to_bin(argv[1], namespace, UUID_STR_FORMAT_GUID)) { + uuid_str_to_bin(DEFAULT_NAMESPACE_GUID, namespace, UUID_STR_FORMAT_GUID); + dtb_path = argv[1]; + } else { + dtb_path = argv[2]; + idx = 3; + } + + if (idx == argc) { + fprintf(stderr, "Usage: "); + print_usage_guidgen(); + return -1; + } + + dtb = load_dtb(dtb_path); + if (!dtb) + return -1; + + if ((ret = fdt_check_header(dtb))) { + fprintf(stderr, "Invalid DTB header: %d\n", ret); + return -1; + } + + compatible = fdt_getprop(dtb, 0, "compatible", &compatlen); + if (!compatible) { + fprintf(stderr, "No compatible string found in DTB\n"); + return -1; + } + if (strnlen(compatible, compatlen) >= compatlen) { + fprintf(stderr, "Compatible string not null-terminated\n"); + return -1; + } + + printf("Generating GUIDs for %s with namespace %s:\n", + compatible, DEFAULT_NAMESPACE_GUID); + for (; idx < argc; idx++) { + memset(fw_image, 0, sizeof(fw_image)); + namelen = strlen(argv[idx]); + if (namelen > MAX_IMAGE_NAME_LEN) { + fprintf(stderr, "Image name too long: %s\n", argv[idx]); + return -1; + } + + for (int i = 0; i < namelen; i++) + fw_image[i] = (uint16_t)argv[idx][i]; + + gen_v5_guid((struct uuid *)&namespace, &image_type_id, + compatible, strlen(compatible), + fw_image, namelen * sizeof(uint16_t), + NULL); + + printf("%s: ", argv[idx]); + print_guid(&image_type_id); + } + + return 0; +} + /** * main - main entry function of mkeficapsule * @argc: Number of arguments * @argv: Array of pointers to arguments @@ -840,8 +979,15 @@ int main(int argc, char **argv) char *privkey_file, *cert_file; int c, idx; struct fmp_payload_header_params fmp_ph_params = { 0 }; + /* Generate dynamic GUIDs */ + if (argc > 1 && !strcmp(argv[1], "guidgen")) { + if (genguid(argc - 1, argv + 1)) + exit(EXIT_FAILURE); + exit(EXIT_SUCCESS); + } + guid = NULL; index = 0; instance = 0; mcount = 0; @@ -928,9 +1074,9 @@ int main(int argc, char **argv) case 'D': capsule_dump = true; break; default: - print_usage(); + print_usage_mkeficapsule(); exit(EXIT_SUCCESS); } } @@ -951,9 +1097,9 @@ int main(int argc, char **argv) (capsule_type != CAPSULE_NORMAL_BLOB && ((argc != optind + 1) || ((capsule_type == CAPSULE_ACCEPT) && !guid) || ((capsule_type == CAPSULE_REVERT) && guid)))) { - print_usage(); + print_usage_mkeficapsule(); exit(EXIT_FAILURE); } if (capsule_type != CAPSULE_NORMAL_BLOB) {