From patchwork Thu Jul 25 20:45:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 814396 Delivered-To: patch@linaro.org Received: by 2002:adf:e641:0:b0:367:895a:4699 with SMTP id b1csp567077wrn; Thu, 25 Jul 2024 13:48:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVAAepOcOol6Bbr9ht+Srd7CLRvoVlliL+ezuiksmZNOT+I9As2ZXpVcbojCQpzjSZf5lGr4nHDvHKSVbSfvvnG X-Google-Smtp-Source: AGHT+IEkImar5qvtIKkQXSnE7bbVnf6A13DXNmnvELotlxlGdHNx2ZZxAqOPJKtMveo2oX4SpW1A X-Received: by 2002:a2e:99c7:0:b0:2ef:205d:4847 with SMTP id 38308e7fff4ca-2f03dbf2cd8mr22005551fa.46.1721940528268; Thu, 25 Jul 2024 13:48:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721940528; cv=none; d=google.com; s=arc-20160816; b=JFLfeGUZT7wyYgJda/E6YPNMLYZyuPo1rYcyigRS+7AW9M6I46LWmL7vECxWrXfgb1 JeZZIarGOKZUDRyk6h+DGkEib2HK6SyixCnUNe/1ZHkQaIjvQrpvQmGzd4o9It8fwUGV QFVEoXZpTMtjLEQXhLJE3dZhgn0ORUPPhNTOAv19dtaNQORDU7iH6+SSMzuXneOI4BHl DuLG8AlpabkAZxC+c2gkkSs31QcdOig0m3XKzW4EWgRbDMtVI9pvVnsW3nkIvr3W1Z2x LuVbTRJzrN++AdiJQRAU348TUIFfpIZ+eCFwrOC6la5wWC93/Vo8sWMAToVuK3aiF9r1 3tkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZV+9/tuIYxOCUWV8xGDM20QwAQGvcpEliEOoPAYw3+k=; fh=pHSBvYO3kheOVOwnelT1WsOX9Cfrr2Ymt6ubUUDTrWY=; b=zNYJAIf2qPNczHaQww5OVtOzx5i/GMmGbJki5jnde+BJIxPtSnbWGTdLKyh58/2T4+ 5mRf4gKd8rFgUJ2xYuG5ChJLon/sHrAqaPwNEZblwdR9luvtByQbteARkgGpsolPboym o/nu+OwVlVFAJsJgXYdp8JJmAKOhTr4L/378GgE7QNIyJFdhucr8ycKHE/VwJPRTO9c6 tTs6ZwGCvDNDbSr66TTcdbiP7tcYUbEntyTNL3qDHV2RwIwW5UP/GgRcximKu/9LcrPL GLz2gAlUX5kpuyFQmPnRDiWkXykb572Yo1FTaCNsrJBMBACRy55R6Wpv8yixFMYL+F2F Q0NQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HEVZXp4f; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id 38308e7fff4ca-2f03d151f3bsi5974151fa.385.2024.07.25.13.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 13:48:48 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HEVZXp4f; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6829E88701; Thu, 25 Jul 2024 22:45:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="HEVZXp4f"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F0B65884A7; Thu, 25 Jul 2024 22:45:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 97C488859B for ; Thu, 25 Jul 2024 22:45:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=semen.protsenko@linaro.org Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-7044bda722fso184479a34.2 for ; Thu, 25 Jul 2024 13:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721940335; x=1722545135; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZV+9/tuIYxOCUWV8xGDM20QwAQGvcpEliEOoPAYw3+k=; b=HEVZXp4fWtYLn1Gtv5T/SHJl8wKxrh9UkgsT8Kp+K2+cupXxV5iSezq+CmLls3n+iv aMnyH8RnX0EgeS8tXxCRynCGEZvcvCA73gaG6XI3Zs19GiWeM9UqLTss9XzfCO0YR5iq 9mAGMep0lCc7934Qc2hls8Yxm462Mi1JKBEvlyC++Xy5JCOMkNbqwEXSQXP5ruptE5px cwz/o5AT59N3lUODuk+wnPV14HglUVd1twxujTwpPU6ESf+/uECHJvrTvCBr8BS2l2jq vzR4wgwqvKvUqizmsEd9eOBfpCsNY2hoABhkWehsn07L5UnXPH0pV1dfu22xoGjkuyQi vlvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721940335; x=1722545135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZV+9/tuIYxOCUWV8xGDM20QwAQGvcpEliEOoPAYw3+k=; b=WE6szn7ky7oHo4Mt/R4S/80SsxldHZg/kYNm1i8Wz0yXikN67tveMrjkmg95ML0YMW l651W0t3KaMVRdfX0T1jGfrNGYoBuhlKAM2FZCAhSZOloPGANIT0evNfkFmfhhJ8oHBm HXpvq2CFWJL2UsXdUAP34/XhReUDkyfDyjMDfHHlYvh7RxsiEcXmifPc/EK8YaKMSlfp ehrMmVglG/hU2Ytp4R/CclEXXUEVlW9e/MXQAyNbTLAT7ENsPyzpMKLEMiaOYvdDjz3g j5ClsF33OT81ay5R07oAgwtKHUdaQgAnGttmdBD1t3HhWZL5mfn8LAj0GSpJ+V2pH+Xq V+xA== X-Forwarded-Encrypted: i=1; AJvYcCWQPZOK2l/ua3i+qdisgDF4W8doH2vtiz+onq3KOonf9t8hjgJF5nKnq4zopOqAFqSX8GjXxF2v73yohzDM896Ao76QUw== X-Gm-Message-State: AOJu0YwclZVeGjTzABbQoozu/Fd3l15iFlK6UyLoHuyD0ReQp7+YzOYX JkWlw2/ErGOQNx5IXCBAYDbaDB+jH+tqO9ZCk6bb0WUK/pKACiWpaNnptTfqXuA= X-Received: by 2002:a05:6830:6286:b0:704:4d36:f450 with SMTP id 46e09a7af769-7092e6bcef8mr5031737a34.9.1721940335376; Thu, 25 Jul 2024 13:45:35 -0700 (PDT) Received: from localhost ([136.62.192.75]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7093050a657sm459573a34.13.2024.07.25.13.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 13:45:35 -0700 (PDT) From: Sam Protsenko To: Jaehoon Chung Cc: Minkyu Kang , Minkyu Kang , Tom Rini , Peng Fan , Simon Glass , Quentin Schulz , Philipp Tomsich , Kever Yang , Eugeniy Paltsev , Peter Robinson , Jonas Karlman , Yang Xiwen , Ferass El Hafidi , Sean Anderson , u-boot@lists.denx.de, uboot-snps-arc@synopsys.com Subject: [PATCH v4 19/38] mmc: exynos_dw_mmc: Don't call pinmux functions on ARM64 chips Date: Thu, 25 Jul 2024 15:45:01 -0500 Message-Id: <20240725204520.18134-20-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240725204520.18134-1-semen.protsenko@linaro.org> References: <20240725204520.18134-1-semen.protsenko@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Pinmux configuration on ARM64 platforms must be performed during startup in pinctrl driver using info from device tree. exynos_pinmux_config() and pinmux_decode_periph_id() are only available on ARM32 platforms, so don't call those functions on ARM64 platforms. Instead of the latter function, use "non-removable" property from device tree to derive the dev_index value. This fixes next linking errors on ARM64 platforms: ld: drivers/mmc/exynos_dw_mmc.o: in function `exynos_dwmci_get_config': undefined reference to `pinmux_decode_periph_id' ld: drivers/mmc/exynos_dw_mmc.o: in function `do_dwmci_init': undefined reference to `exynos_pinmux_config' Fixes: a082a2dde061 ("EXYNOS5: DWMMC: Added FDT support for DWMMC") Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - Replaced CONFIG_IS_ENABLED() with #ifdef drivers/mmc/exynos_dw_mmc.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c index aa542c13fea8..ed2752391603 100644 --- a/drivers/mmc/exynos_dw_mmc.c +++ b/drivers/mmc/exynos_dw_mmc.c @@ -144,6 +144,7 @@ static int exynos_dwmci_core_init(struct dwmci_host *host) static int do_dwmci_init(struct dwmci_host *host) { +#ifdef CONFIG_CPU_V7A int flag, err; flag = host->buswidth == 8 ? PINMUX_FLAG_8BIT_MODE : PINMUX_FLAG_NONE; @@ -152,6 +153,7 @@ static int do_dwmci_init(struct dwmci_host *host) printf("DWMMC%d not configure\n", host->dev_index); return err; } +#endif return exynos_dwmci_core_init(host); } @@ -163,6 +165,7 @@ static int exynos_dwmci_get_config(struct udevice *dev, const void *blob, int err = 0; u32 timing[3]; +#ifdef CONFIG_CPU_V7A /* Extract device id for each mmc channel */ host->dev_id = pinmux_decode_periph_id(blob, node); @@ -174,6 +177,12 @@ static int exynos_dwmci_get_config(struct udevice *dev, const void *blob, printf("DWMMC%d: Can't get the dev index\n", host->dev_index); return -EINVAL; } +#else + if (dev_read_bool(dev, "non-removable")) + host->dev_index = 0; /* eMMC */ + else + host->dev_index = 2; /* SD card */ +#endif /* Get the bus width from the device node (Default is 4bit buswidth) */ host->buswidth = fdtdec_get_int(blob, node, "samsung,bus-width", 4);