| Message ID | 20240528-topic-sm8x50-pinctrl-pinconf-v1-5-54d1e9ad7dfa@linaro.org |
|---|---|
| State | Accepted |
| Commit | c89ab4aa1732ae661c2c0cdccd27d1d3469aab00 |
| Headers | show |
| Series | pinctrl: qcom: allow setting pins configuration for sepcial pins | expand |
On Tue, 28 May 2024 at 14:02, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Add the special pins configuration data to allow setup the bias > of the UFS and SDCard pins on the SM8650 SoC. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-sm8650.c | 42 ++++++++++++++++++++++++++++------- > 1 file changed, 34 insertions(+), 8 deletions(-) > Reviewed-by: Sumit Garg <sumit.garg@linaro.org> -Sumit > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8650.c b/drivers/pinctrl/qcom/pinctrl-sm8650.c > index d6cc1bbdda8..58fc94e71ac 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8650.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8650.c > @@ -18,6 +18,37 @@ static const struct pinctrl_function msm_pinctrl_functions[] = { > {"gpio", 0}, > }; > > +#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv) \ > + { \ > + .name = pg_name, \ > + .ctl_reg = ctl, \ > + .io_reg = 0, \ > + .pull_bit = pull, \ > + .drv_bit = drv, \ > + .oe_bit = -1, \ > + .in_bit = -1, \ > + .out_bit = -1, \ > + } > + > +#define UFS_RESET(pg_name, ctl, io) \ > + { \ > + .name = pg_name, \ > + .ctl_reg = ctl, \ > + .io_reg = io, \ > + .pull_bit = 3, \ > + .drv_bit = 0, \ > + .oe_bit = -1, \ > + .in_bit = -1, \ > + .out_bit = 0, \ > + } > + > +static const struct msm_special_pin_data msm_special_pins_data[] = { > + [0] = UFS_RESET("ufs_reset", 0xde004, 0xdf000), > + [1] = SDC_QDSD_PINGROUP("sdc2_clk", 0xd6000, 14, 6), > + [2] = SDC_QDSD_PINGROUP("sdc2_cmd", 0xd6000, 11, 3), > + [3] = SDC_QDSD_PINGROUP("sdc2_data", 0xd6000, 9, 0), > +}; > + > static const char *sm8650_get_function_name(struct udevice *dev, > unsigned int selector) > { > @@ -27,15 +58,9 @@ static const char *sm8650_get_function_name(struct udevice *dev, > static const char *sm8650_get_pin_name(struct udevice *dev, > unsigned int selector) > { > - static const char *special_pins_names[] = { > - "ufs_reset", > - "sdc2_clk", > - "sdc2_cmd", > - "sdc2_data", > - }; > - > if (selector >= 210 && selector <= 213) > - snprintf(pin_name, MAX_PIN_NAME_LEN, special_pins_names[selector - 210]); > + snprintf(pin_name, MAX_PIN_NAME_LEN, > + msm_special_pins_data[selector - 210].name); > else > snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); > > @@ -52,6 +77,7 @@ static struct msm_pinctrl_data sm8650_data = { > .pin_data = { > .pin_count = 214, > .special_pins_start = 210, > + .special_pins_data = msm_special_pins_data, > }, > .functions_count = ARRAY_SIZE(msm_pinctrl_functions), > .get_function_name = sm8650_get_function_name, > > -- > 2.34.1 >
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8650.c b/drivers/pinctrl/qcom/pinctrl-sm8650.c index d6cc1bbdda8..58fc94e71ac 100644 --- a/drivers/pinctrl/qcom/pinctrl-sm8650.c +++ b/drivers/pinctrl/qcom/pinctrl-sm8650.c @@ -18,6 +18,37 @@ static const struct pinctrl_function msm_pinctrl_functions[] = { {"gpio", 0}, }; +#define SDC_QDSD_PINGROUP(pg_name, ctl, pull, drv) \ + { \ + .name = pg_name, \ + .ctl_reg = ctl, \ + .io_reg = 0, \ + .pull_bit = pull, \ + .drv_bit = drv, \ + .oe_bit = -1, \ + .in_bit = -1, \ + .out_bit = -1, \ + } + +#define UFS_RESET(pg_name, ctl, io) \ + { \ + .name = pg_name, \ + .ctl_reg = ctl, \ + .io_reg = io, \ + .pull_bit = 3, \ + .drv_bit = 0, \ + .oe_bit = -1, \ + .in_bit = -1, \ + .out_bit = 0, \ + } + +static const struct msm_special_pin_data msm_special_pins_data[] = { + [0] = UFS_RESET("ufs_reset", 0xde004, 0xdf000), + [1] = SDC_QDSD_PINGROUP("sdc2_clk", 0xd6000, 14, 6), + [2] = SDC_QDSD_PINGROUP("sdc2_cmd", 0xd6000, 11, 3), + [3] = SDC_QDSD_PINGROUP("sdc2_data", 0xd6000, 9, 0), +}; + static const char *sm8650_get_function_name(struct udevice *dev, unsigned int selector) { @@ -27,15 +58,9 @@ static const char *sm8650_get_function_name(struct udevice *dev, static const char *sm8650_get_pin_name(struct udevice *dev, unsigned int selector) { - static const char *special_pins_names[] = { - "ufs_reset", - "sdc2_clk", - "sdc2_cmd", - "sdc2_data", - }; - if (selector >= 210 && selector <= 213) - snprintf(pin_name, MAX_PIN_NAME_LEN, special_pins_names[selector - 210]); + snprintf(pin_name, MAX_PIN_NAME_LEN, + msm_special_pins_data[selector - 210].name); else snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); @@ -52,6 +77,7 @@ static struct msm_pinctrl_data sm8650_data = { .pin_data = { .pin_count = 214, .special_pins_start = 210, + .special_pins_data = msm_special_pins_data, }, .functions_count = ARRAY_SIZE(msm_pinctrl_functions), .get_function_name = sm8650_get_function_name,
Add the special pins configuration data to allow setup the bias of the UFS and SDCard pins on the SM8650 SoC. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/pinctrl/qcom/pinctrl-sm8650.c | 42 ++++++++++++++++++++++++++++------- 1 file changed, 34 insertions(+), 8 deletions(-)