From patchwork Tue Mar 12 07:03:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Garg X-Patchwork-Id: 779668 Delivered-To: patch@linaro.org Received: by 2002:a5d:604e:0:b0:33e:7753:30bd with SMTP id j14csp1884273wrt; Tue, 12 Mar 2024 00:04:49 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVSH0m+RibqqG3y+hLHEw8GA0G03dpA6mrpdXZOpYT1xidwc6XOrTYqdOl3vP8XrLfR53jTcHyveC59LwXyGH8q X-Google-Smtp-Source: AGHT+IEqkq3iP7Vr7X/2vJEo6OY0FjHGaugHSLTkuJ6uszrtljIrme7qJqoeiRQj9jYCp29yPsrv X-Received: by 2002:a5d:4491:0:b0:33e:73ea:39c2 with SMTP id j17-20020a5d4491000000b0033e73ea39c2mr6374235wrq.67.1710227088823; Tue, 12 Mar 2024 00:04:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710227088; cv=none; d=google.com; s=arc-20160816; b=id13K54RH758idxyH2e3Ugp8NriYJB5ArPp0jx+7lk3qDFnohNfClBmADzA0Lqz9Ai Rr3Sz3TJ3cY9Qg64W+yiFzY0l7K3Kc8R+PYlL+G0qOxUMcqHA0q7z9dR19nzJ7LqJeH/ oh3O9UDvzadB9UyTL8oHFFz1wcC3KzQyfOlDu0oR2Kn1T106LXk1alYVYcCOeBrOIEnu jFL1IdMEdYEIO1lNyML/iTFYNzo63j67wH0aXTwc9bXhu2kL6SeQkD0pD14cCt8gzLuj DWnppzlmsfm1xZSCigbbhLhp7NxN8VMqU+G8a73opkhhXenOtwLwmesoFZmbqn6A7dV9 Rlbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9oj8qHyuFviHCa6TWR44Xr5I2AslDRMVitg0k3m1MYQ=; fh=6MjRslvz5/5JIMg9K+TXvs6ucdDWrQK1JV5y67UPeIc=; b=XyqPNcgZVg7WMUP3/Nj1wsBLEseMrTxpWa9I8JEJbw8SNTS6rZCUfOxfupdrnJB1p8 QAbjIVcNqU9OWUIcTTr4NI+nvqLlQ6nmGni6fiGSka4tT1fx1UJN6PmX+JLpdkGA4Ips IQHciQ625KimOYoCbh9eiTVMKJKKZRFkqllGkszyTx3bT7JtTd7wVtjQ6A3LEPWG2ljD uf/VVdh2Ms61krNSrerJJNeFuuPJQEk+plGcfViGFym6kQZt6OTfoyKS0GLqaiUwAT8o Hcl26EH+/C2Gi/4AiI35eUFFsgrtfDzAzYSrRQHP9T0NkyHWrTAqYhVei0w84bC5AFzA jVaw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mk7QegPJ; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id g11-20020adfd1eb000000b0033e9febdb95si883819wrd.400.2024.03.12.00.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 00:04:48 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mk7QegPJ; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 41E8887DE6; Tue, 12 Mar 2024 08:04:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Mk7QegPJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1C72687DE3; Tue, 12 Mar 2024 08:04:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: * X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_SBL_CSS,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ED54C87F3B for ; Tue, 12 Mar 2024 08:04:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sumit.garg@linaro.org Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-5d8b70b39efso3139290a12.0 for ; Tue, 12 Mar 2024 00:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710227057; x=1710831857; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9oj8qHyuFviHCa6TWR44Xr5I2AslDRMVitg0k3m1MYQ=; b=Mk7QegPJTdZYDQ+65YE8e63T8sX4vt8Rtfnu9XYhwaAG82VyGg3OwN5Ayre+04UUC9 ewYOTxhTFLCO6DMPfihhdDbczK8sNt9Z5B8BmqmAEmyPJuCXPeHcp80ZmjM1tC/7PyK+ DTbbL2pJxwRnzCawjRiwnAgO0/4fAMdRqZmohOEB7hmGX2Fdb9sJPcJtoYKxKZ00Rlf/ XrNeBFWaIrUPVsx/CjbAgIE3R9+oi2YRbbJTP8bcQqmoCfGSTK9GmmW7NLoergZNUkW/ Cnw9IPAvrctUGaD6bHNS7vwC8wr54u3rDi4tIAnrmthKNnt81pLQgZK7bOcCZYB2thys sjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710227057; x=1710831857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9oj8qHyuFviHCa6TWR44Xr5I2AslDRMVitg0k3m1MYQ=; b=M382d5eC/o2bPPmmB4x/4pO47CRVKcfMIuglgoyjbKkar7Ilrnmoy1W3wi/BN3bJ98 HJqGokDWfvtwEBxZgjOzfvmCli3LCuemj95N6STM/Xoy9QTr15gveD3Tf8qIB+zH3746 mggx/tIT9cRSWGr6AXQt4APCBPJrvaZzVBVDLyUXOzvtaY5QSpAnlJVL76VZcVPS9gR1 mnwFWayk7eb3FVcfRA7xwx5/SxMFaQWHYBNNUXoF88xrVmUBapQ2fEBWPIhC5miMAMoA +6AanrUQaliuVPgJFgjbfCU+94j6E15+QjOYRiulB8/1G7xryVT76jvS9AeHfI2j46Kq ETow== X-Gm-Message-State: AOJu0Yz7OknYxRl0ldTgTl3RG7gbOgJZ4EuajnTeFOt8kmO8cEvii7Q1 JDMpvg5LBtOx4NU6KhRJaqxEIRsrduxnMrL/Sj4qQIB5TYlj4FW6tVSdZAtCWYWdKUZZwiSNaNT o X-Received: by 2002:a17:902:c947:b0:1dd:8daf:99b2 with SMTP id i7-20020a170902c94700b001dd8daf99b2mr6773397pla.13.1710227057081; Tue, 12 Mar 2024 00:04:17 -0700 (PDT) Received: from sumit-X1.. ([223.178.211.249]) by smtp.gmail.com with ESMTPSA id e13-20020a170902784d00b001dd0d0d26a4sm6045401pln.147.2024.03.12.00.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 00:04:16 -0700 (PDT) From: Sumit Garg To: u-boot@lists.denx.de Cc: trini@konsulko.com, tharvey@gateworks.com, marcel.ziswiler@toradex.com, francesco@dolcini.it, lukma@denx.de, seanga2@gmail.com, jh80.chung@samsung.com, sjg@chromium.org, festevam@denx.de, andrejs.cainikovs@toradex.com, peng.fan@nxp.com, aford173@gmail.com, marex@denx.de, ilias.apalodimas@linaro.org, sahaj.sarup@linaro.org, fathi.boudra@linaro.org, remi.duraffort@linaro.org, daniel.thompson@linaro.org, Sumit Garg Subject: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus Date: Tue, 12 Mar 2024 12:33:31 +0530 Message-Id: <20240312070338.86127-5-sumit.garg@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240312070338.86127-1-sumit.garg@linaro.org> References: <20240312070338.86127-1-sumit.garg@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean power_domain_on/off() isn't refcounted and power domain bus shouldn't be turned off for a single peripheral domain as it would negatively affect other peripheral domains. So lets just skip turning off bus power domain. Fixes: 898e7610c62a ("imx: power-domain: Add i.MX8MP HSIOMIX driver") Signed-off-by: Sumit Garg --- drivers/power/domain/imx8mp-hsiomix.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/power/domain/imx8mp-hsiomix.c b/drivers/power/domain/imx8mp-hsiomix.c index e2d772c5ec7..448746432a2 100644 --- a/drivers/power/domain/imx8mp-hsiomix.c +++ b/drivers/power/domain/imx8mp-hsiomix.c @@ -50,7 +50,7 @@ static int imx8mp_hsiomix_on(struct power_domain *power_domain) ret = power_domain_on(domain); if (ret) - goto err_pd; + return ret; ret = clk_enable(&priv->clk_usb); if (ret) @@ -63,8 +63,6 @@ static int imx8mp_hsiomix_on(struct power_domain *power_domain) err_clk: power_domain_off(domain); -err_pd: - power_domain_off(&priv->pd_bus); return ret; } @@ -85,8 +83,6 @@ static int imx8mp_hsiomix_off(struct power_domain *power_domain) else if (power_domain->id == IMX8MP_HSIOBLK_PD_USB_PHY2) power_domain_off(&priv->pd_usb_phy2); - power_domain_off(&priv->pd_bus); - return 0; }