From patchwork Mon Dec 25 15:39:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 758223 Delivered-To: patch@linaro.org Received: by 2002:a5d:67c6:0:b0:336:6142:bf13 with SMTP id n6csp2710040wrw; Mon, 25 Dec 2023 07:42:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrUsur7ziB9CUMLSSdTu6P62u0hAA4/hUQZ5YyZ55p1Alx7CBBHP75EMoIFjCfndE9jSEV X-Received: by 2002:a5d:5f4d:0:b0:336:c9a7:2e97 with SMTP id cm13-20020a5d5f4d000000b00336c9a72e97mr623082wrb.91.1703518958774; Mon, 25 Dec 2023 07:42:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703518958; cv=none; d=google.com; s=arc-20160816; b=C1jVl2m6FGw/Oo+RQ4aOSEHCtK+/huHIBWJ0xHV9icxdPlJ8hZy+UurCktE8l6kJfZ EpqfsBxWT5QJGiIvCmLOia6NlJG+09BNepvuPqZ8MkLxQxTS3N68k+OKCa3zVkdcqqWI 94g5qPHaIDHJXPLtyl/DhzsqLcHVTQYIps7pD0QXIIu+FR3mGAfHCkjd39WnADENdZmr 81kJ4Qzxe5Y9lJr1dO/lTk4XtBEfCUfvfpIvElEI7blmf1Lgvesclkn08EiHNxTsX9Zk pSfgyNBNn65HQKqih+LkKXjLlv9TN5dyrqyYaeF5APCESpizh4+wIgjMnCCMZ/FqPDJJ AwVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LnYpx4HXF0svwPxtFe6zqQqGLbu3MtOtMdMlY/7OJ0c=; fh=al8TO5kxNSCLdK6Wct4/S1Ky9QCKGaknFfrx/Rr/20U=; b=R+J9bA/YKP5R1iDdXdL74E7H7hVxmjnNEiaBWm6chttCfL6oW4K138ltuy4V6H7Trf spGSD+Vcg0556jJU6HctlHEQbTXGMVJ6qBgSIjayXeNpS0DGu0Lyznq6zm0jrDygmw7h Zgkq8gckjIKo02+P4PpUddcaqT4anT0pAh7Rw9+3OenIkEuvtRTyFVXAwW2fe+Awed5T BNsuEiGCiHkB52j6TYJx5R5thI6wqTz3j2LE2SOg1biz12V0TL537uwY6MXvn1fVDrlW 7J2srUBA0FXLoiRhwPYMVoAMKjdZ5I4/OO5th5J3M2oSyyUGf/KhZH+HdUQQywuq66QZ Casw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MkeUzDsd; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id e6-20020a056000120600b0033675614efasi4871131wrx.834.2023.12.25.07.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 07:42:38 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MkeUzDsd; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0374587805; Mon, 25 Dec 2023 16:42:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="MkeUzDsd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E556587805; Mon, 25 Dec 2023 16:42:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D31288744F for ; Mon, 25 Dec 2023 16:42:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maxim.uvarov@linaro.org Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50e49a0b5caso4171368e87.0 for ; Mon, 25 Dec 2023 07:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703518922; x=1704123722; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LnYpx4HXF0svwPxtFe6zqQqGLbu3MtOtMdMlY/7OJ0c=; b=MkeUzDsdOezZbPjP1Ofn/4+ZyQea9tlCpBmMSXToGh9ddE0PFtyB/NQUuViteEqO8D jbHlPFhQz3g3cmGs1Wl1II9lhXRhpze7vyAKFERHnzG+WeRKHeKHuEfnyLzHLbhftkcH Jap34OWDmmd5NvLjw2ZB6j8i/a+/dW/H17KtsaqMGrkwhnVVrat08pmP5nXAeclNhDAu VxLmEuqj0Ta5VW3frEgs3ymon+F08JfPAAYByYFzVoCwFl/wVswDGhebU3KyGgbf8X+S EoyDJGI1UTZlex069K7Fg5LjrowRWtgHbnnDd96Q8BMVgYciURk4uAgKgBkNDjB+07I/ IyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703518922; x=1704123722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LnYpx4HXF0svwPxtFe6zqQqGLbu3MtOtMdMlY/7OJ0c=; b=VkCDm3N4HPngc5VLc98kvnuYxcdwGKJv+Qi9jwL50UrTJKzAONPj2ZcJ5opmj0fH+7 TKI/GG+h9VYzzwNNICnwdvPJQB/K4bgECHQzPSTj1ypVlRJ65FAvO0WwvoJBBYf/AxnC 7zQhKGVTU77SbQxG1MnRhdPKv4wEFS9/b+LdbACcpp9cpg1MB5n5ZPTl3/W2yAQ3usN5 utN7ToPKfTXvIbbolmxTD6Am1QaYC3wINdEhQmH6La9AQGNIzgDZZ2C7QfVlVulSkHOg e8bAlA6dceYSGQ0+oG2ICW5Xlkj6yU7oJs5PwcUKpQNP8Ei8EK1jbmyoY+e/ML2fO7jC YA2Q== X-Gm-Message-State: AOJu0YxM6IrudCB4mLF+nIk74HatlGwA2cR/qaNnlnULmwdo5tDaodoD DbANdW12XDPcg6q1U8FrEzwGgsl/eIQbUzZPIT+FeGIYEAw= X-Received: by 2002:a05:651c:2059:b0:2cc:80ec:5dc5 with SMTP id t25-20020a05651c205900b002cc80ec5dc5mr2008424ljo.31.1703518922555; Mon, 25 Dec 2023 07:42:02 -0800 (PST) Received: from localhost.localdomain ([45.82.14.220]) by smtp.gmail.com with ESMTPSA id a17-20020a2ebe91000000b002cca6eafc44sm1425644ljr.113.2023.12.25.07.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 07:42:02 -0800 (PST) From: Maxim Uvarov To: u-boot@lists.denx.de Cc: simon.k.r.goldschmidt@gmail.com, tien.fong.chee@intel.com, sjg@chromium.org, joe.hershberger@ni.com, rfried.dev@gmail.com, bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, trini@konsulko.com, Maxim Uvarov Subject: [PATHv2 5/9] driver/net/rtl8139: remove debug print Date: Mon, 25 Dec 2023 21:39:25 +0600 Message-Id: <20231225153929.8284-6-maxim.uvarov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231225153929.8284-1-maxim.uvarov@linaro.org> References: <20231225153929.8284-1-maxim.uvarov@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean debug print delays reset of the driver. Finally I see bunch of "rx error FFFF" errors in the screen. CI can not handle many prints. While network works fine there Reproduced with: make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all qemu-system-sh4 -M r2d -nographic -serial null \ -serial mon:stdio -net user,tftp=`pwd` \ -net nic,model=rtl8139 -kernel ./u-boot.bin Signed-off-by: Maxim Uvarov Reviewed-by: Simon Glass --- drivers/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/rtl8139.c b/drivers/net/rtl8139.c index 106bc1c7ae..d8f24ec81a 100644 --- a/drivers/net/rtl8139.c +++ b/drivers/net/rtl8139.c @@ -453,7 +453,7 @@ static int rtl8139_recv_common(struct rtl8139_priv *priv, unsigned char *rxdata, RTL_STS_RXBADALIGN)) || (rx_size < ETH_ZLEN) || (rx_size > ETH_FRAME_LEN + 4)) { - printf("rx error %hX\n", rx_status); + debug("rx error %hX\n", rx_status); /* this clears all interrupts still pending */ rtl8139_reset(priv); return 0;