From patchwork Mon Dec 4 12:04:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 750020 Delivered-To: patch@linaro.org Received: by 2002:adf:9b9d:0:b0:333:3a04:f257 with SMTP id d29csp1087517wrc; Mon, 4 Dec 2023 04:08:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAJZuinzJRAxqN1xZJTnaQITH5ZQyWDwNteY92ZnMdNNJJmnL16gBwnTtRSNrfAfD+XL/f X-Received: by 2002:a05:6a20:3d13:b0:18c:177d:2122 with SMTP id y19-20020a056a203d1300b0018c177d2122mr1664372pzi.2.1701691700315; Mon, 04 Dec 2023 04:08:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701691700; cv=none; d=google.com; s=arc-20160816; b=RsAhIEm71sK7M+AVbK9yZsvZ4oUfmPweXeOf9zRhXELIRNY5hbGbzcrvVQybtBW/of UuCYYYKKYmSJMZIG/jgjYh2MdtoQbg3Sn586yuQ+SraJd5kMaqd0/hbktHX2txF1mNWj ObNY3ff7zgYgrZzwGYINbTvuTRYgXtvibRo4V7M3euK4sCf/ZJRqS/QF6niS/fGLVi0l PqTT4azr2g9CVMxixyPqUmbAO4RuH0drO0hk3kYxpVHVSvDa0bpcv8c/OKO7hcXzWesu 5+t46AG09pBfMlIJdnvXs5Yb6BKoVlhr7yxwS3t2DXAFHvCHN7mITkOpI/p4wqdUG7B9 vkOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LnYpx4HXF0svwPxtFe6zqQqGLbu3MtOtMdMlY/7OJ0c=; fh=al8TO5kxNSCLdK6Wct4/S1Ky9QCKGaknFfrx/Rr/20U=; b=aCTSvlXu0XKO5cBwOLnBTsgpCy1xhhzIo/BdsXFncS8KWqRhrX1mw2mEEE0+DOZC1U zYmNywX9Ye6LQ8dX57TqIsajJQeV663mQaGPrAjpLwd/zxtn9S3nk/4kwzfOpshbqSjp /N6EnW7+0lc47eCnRL5xBgQTx5bwsog1kM+sbaCwRVw/NVPAqaJkbn12seYZZbS0hjiF /PmQ4yTEae5tYorkee3IRe9l4f8H3tiRfPq4H2WQYnlBSwxfq+4b5Dmg1ppKpIEVnSPD EL489Mun09bRJgpAP9aa75y2/2ReqnV75AVr+O9AeXU9khqNRGbJ8IM1vOd8b/cDGfNd pe3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S2Cru77R; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id z9-20020aa78889000000b006ce61efad02si226883pfe.346.2023.12.04.04.08.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:08:20 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=S2Cru77R; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A761D87623; Mon, 4 Dec 2023 13:07:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="S2Cru77R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B98E87630; Mon, 4 Dec 2023 13:07:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 341BE87622 for ; Mon, 4 Dec 2023 13:07:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maxim.uvarov@linaro.org Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50bf7bc38c0so952340e87.2 for ; Mon, 04 Dec 2023 04:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701691640; x=1702296440; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LnYpx4HXF0svwPxtFe6zqQqGLbu3MtOtMdMlY/7OJ0c=; b=S2Cru77ReItMiGUnRhwW74ltvK45tGIw8vSzpUCpap38FkJEKPBQfyz3ZTW2mWXVNb rJJfWqGBNFUlc6E1LHZMjo4dPAcFYVrxZi/2c8GO+AUuXOPCJt7kiu12yNYveG7To/vd sJ7RGoCaa+G1vMyuzgMxgI+W6vU8LrScs61PJbbexpxtONFvw0Zn8KFngUHs7UoowpK6 rIqYNsi24dZdDR1Vp+UEFSy5XC/94g5+OZmDgjPMnvHDiqcWp4kKlqn5qtHdBcPeHSM9 q7IySkErAh4p/1mWaXI42x7rxMXRsopb2PJR/95vRNAC8am9UlU/CeAXNTwwaV9lwj7O P8+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701691640; x=1702296440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LnYpx4HXF0svwPxtFe6zqQqGLbu3MtOtMdMlY/7OJ0c=; b=sVTGe1lEYw71N6dR9cf4yhY9hKniqoZoSrX5I+I7M4wy9CIGFAGJf7bva2IyVKGi9Z s9B7WsfxsZLy83SxQYja5wVgvEFyGaZ225iG0W1ukCusMA6e6JLjhhEqHHbravPwHDYj H8x8H2ONdNfro3l5UNWP162nOEhZQNk1wRao5OW9NuirDIjmcPpqTfGaT9XafI5Dt4Pe PnRzI8bpNM6YrTFfGJrP/BAhHVlv8PrAy74DVFdpnVMN2k39xqYqQmGs//kvONEMDZ9+ aS/0UhjAXsNhT2g1iQwb/FmCCdftCaIbl7x0dhZzgBJq7YxgzNYkMUEcBWyzQKrWRPr1 voWQ== X-Gm-Message-State: AOJu0Yzj6b73c9iXrW0wnswz55KhOmG4V3Vgb7h6Y/nDecHXITRnIrXr bV8hUIAg0Lfm8PrDBoG82IViC+Zg/HRBS18FllR9MQ== X-Received: by 2002:ac2:5b5a:0:b0:50b:e5bf:cd08 with SMTP id i26-20020ac25b5a000000b0050be5bfcd08mr1499143lfp.0.1701691639850; Mon, 04 Dec 2023 04:07:19 -0800 (PST) Received: from localhost.localdomain ([45.82.14.220]) by smtp.gmail.com with ESMTPSA id g33-20020a0565123ba100b0050befebf0ccsm541675lfv.292.2023.12.04.04.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:07:19 -0800 (PST) From: Maxim Uvarov To: u-boot@lists.denx.de Cc: simon.k.r.goldschmidt@gmail.com, tien.fong.chee@intel.com, sjg@chromium.org, joe.hershberger@ni.com, rfried.dev@gmail.com, bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, trini@konsulko.com, Maxim Uvarov Subject: [PATHv1 5/9] driver/net/rtl8139: remove debug print Date: Mon, 4 Dec 2023 18:04:42 +0600 Message-Id: <20231204120446.3277-6-maxim.uvarov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231204120446.3277-1-maxim.uvarov@linaro.org> References: <20231204120446.3277-1-maxim.uvarov@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean debug print delays reset of the driver. Finally I see bunch of "rx error FFFF" errors in the screen. CI can not handle many prints. While network works fine there Reproduced with: make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all qemu-system-sh4 -M r2d -nographic -serial null \ -serial mon:stdio -net user,tftp=`pwd` \ -net nic,model=rtl8139 -kernel ./u-boot.bin Signed-off-by: Maxim Uvarov --- drivers/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/rtl8139.c b/drivers/net/rtl8139.c index 106bc1c7ae..d8f24ec81a 100644 --- a/drivers/net/rtl8139.c +++ b/drivers/net/rtl8139.c @@ -453,7 +453,7 @@ static int rtl8139_recv_common(struct rtl8139_priv *priv, unsigned char *rxdata, RTL_STS_RXBADALIGN)) || (rx_size < ETH_ZLEN) || (rx_size > ETH_FRAME_LEN + 4)) { - printf("rx error %hX\n", rx_status); + debug("rx error %hX\n", rx_status); /* this clears all interrupts still pending */ rtl8139_reset(priv); return 0;