From patchwork Wed Nov 8 16:20:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 742240 Delivered-To: patch@linaro.org Received: by 2002:ab3:760f:0:b0:23f:8cfb:5ad7 with SMTP id q15csp479900lte; Wed, 8 Nov 2023 08:22:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHS8I+8L5xOHQ2wSuuJYgVgQNhfXtrCvg+RVeE6GUAXp82RCNABhBIRIGeZl69LEGfp3SPQ X-Received: by 2002:a50:9e49:0:b0:543:4fdb:de84 with SMTP id z67-20020a509e49000000b005434fdbde84mr1944650ede.7.1699460542899; Wed, 08 Nov 2023 08:22:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699460542; cv=none; d=google.com; s=arc-20160816; b=K/NX/Mpgo59rf14X/B0tMmEZz9bIb7vut0WIMKTIfQ+5ncUs+iYTaBGpB78Dk6ZvFS x+uSI7rIMWC+GvRCLqiGmWRSPhCoP546lHMRBaJe/jgS041tpe7hDOVAD5rgXWkoEudf JhtBfAguIBW2ZcOBBwa8yOnaK/C4YbUSYt3bN0fMZ0RMat0+2oTHBvY15Q5HktLnHBmX ly7+FVCDKN4kNJd0of71Fp3LWdArN3nXIiULKB+d05aG1BfkFSEIQnBu7iOxRZ4+WBAh g7pxSGWrMVSSjz3qAEXUSrYx7mXd8dE1XGBogdBSjRnI5xxkGH90B9MfiQZsoNZWps4X +c1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=018DhIg4oU2avzPOOIk9IL8QILD9VZBX7XSKEIBDpeg=; fh=i7Y9asrausL8i9nH7n7DTaWvEmliXkHtoWPkbew9DMg=; b=vUYvIZZIVcyeJUf6LTZx9ptfqGv7Le57Ch58MC2+nSeZernfRiQW/6CcECN2N180y3 wF1rAp2DsRoiSwaTGIrB8uJHG2XwdKpA9ZVH+6F/S2gVG5By1hNUrvoXVj+Bi66+Lbv1 4QNtWAarQsEh5cl8uVNo6RI9+H9Dh55ef+fgmCmzIiT2dJSpNPUzkOK6JHrOVGYjh28w F4/Q/zu9uuhyrKmFxWAom4NT9sg4vdQkLRuyc+hT15MMQqzZF8teiJuxH1Ld6VCqeM0g oTy5J6IdPyrlns9b4qwW1VmHnTNbTEcKAc0Ab26jm4vNt/ISp8RH584JRs17lp/7x5VF 6YCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PeplDznr; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id r17-20020a05640251d100b0053dbb8a0740si6518326edd.417.2023.11.08.08.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 08:22:22 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PeplDznr; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4F45C87677; Wed, 8 Nov 2023 17:21:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="PeplDznr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B7BE887702; Wed, 8 Nov 2023 17:21:12 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 621B78755B for ; Wed, 8 Nov 2023 17:21:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-507a62d4788so9670691e87.0 for ; Wed, 08 Nov 2023 08:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699460466; x=1700065266; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=018DhIg4oU2avzPOOIk9IL8QILD9VZBX7XSKEIBDpeg=; b=PeplDznr4B8dqmYjOppuCIlSwv3SZLYaTWq6xAyAJgERRTvWyIcbXmBCPBgVeQIjDU 56YTXt4UPDUek5qXif31IwaUnZjPTrHfclaaU6mAa1bD6h72R0V3oCFeub7QSKPGGGHY S+yN6UzoPYZIZWHD5jsAWpbtB7PfKM0N9PXAfKJGw8oi+bfGjlrtoPUXc9mzRzkdjhSi G9IlMsvxuDD85fkr6gcDgg3OvRlEETBQoZtr2w7IG+W/rQuQQ1rxg31xv81g3MS//PTS Q+bLM+UUlrWgCU+t8QdP3cnYZLQtG07WXb6aMV3bx5r3tHTvRez+SnkkFYv93V81YLUZ t7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699460466; x=1700065266; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=018DhIg4oU2avzPOOIk9IL8QILD9VZBX7XSKEIBDpeg=; b=a4ZXQDbUBajL7QCWYsWEmiltMov3qAGpVvQyB81XAdBInmTvsw1UZbZv+uQcVUYFjY m/ALxmdhSPS1gTzVnrjPYECFg26R2W/O2yWmHUYGVQ13KB2aqeq/IQAQsejjE397ceGK 4qV8vy9ZvakAZ7hhbIeflYCP41gVp8ZubhvFQgapejBtfgY+m9mZ/WtCmvw2UWv6zAr5 4C5qdzmeT4JaOR2MQN5OBj1dcfmQNnrZCTiRiwqI/39jvbN3NSPrzU446Tlbhl1PxhVy 0Vvo9e3KAUWIOYjvzqqzg4MtslN0TskFNE/9StETKW5RVWcC7zTeoDnT7sckqdfklz0W ZXiw== X-Gm-Message-State: AOJu0YxdYAGQvUBhdybpSy8IolhPz4BcExsXuiDHgLjjsiMogfP/EWi4 qYkfplCbv+v0LHcEKTQtPFNVuQ== X-Received: by 2002:ac2:4a81:0:b0:507:a33f:135d with SMTP id l1-20020ac24a81000000b00507a33f135dmr1786038lfp.4.1699460466635; Wed, 08 Nov 2023 08:21:06 -0800 (PST) Received: from lion.localdomain (host-92-25-138-185.as13285.net. [92.25.138.185]) by smtp.gmail.com with ESMTPSA id n7-20020a5d6607000000b0032db1d741a6sm5273660wru.99.2023.11.08.08.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 08:21:06 -0800 (PST) From: Caleb Connolly Date: Wed, 08 Nov 2023 16:20:57 +0000 Subject: [PATCH v2 5/5] pmic: qcom: dont use dev_read_addr to get USID MIME-Version: 1.0 Message-Id: <20231108-b4-qcom-dt-compat-v2-5-713233c72948@linaro.org> References: <20231108-b4-qcom-dt-compat-v2-0-713233c72948@linaro.org> In-Reply-To: <20231108-b4-qcom-dt-compat-v2-0-713233c72948@linaro.org> To: Ramon Fried , Jorge Ramirez-Ortiz , Neil Armstrong , Sumit Garg , Mateusz Kulikowski , Jaehoon Chung , Dzmitry Sankouski , Caleb Connolly Cc: u-boot@lists.denx.de X-Mailer: b4 0.13-dev-4bd13 X-Developer-Signature: v=1; a=openpgp-sha256; l=1388; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=5K5TojjS22iKoGc3mT5WWQT3H8v2KeEZTGL2lkHxY9A=; b=owGbwMvMwCFYaeA6f6eBkTjjabUkhlTvrTktc8Q/+927cYjNynlZ9cRJRdJCVybyb9r5onLuy sVbzV4kdZSyMAhyMMiKKbKIn1hm2bT2sr3G9gUXYOawMoEMYeDiFICJdG5hZJj3fEfPgnm6JyNa i75Ii86SVvxiqn6patIrtQbnO1k2M7kY/icbHd6S98L5fpUYf9+eOea2d9dknN5Tc2bC0rBGjQK tJA4A X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Linux DTs stuff a value indicating if the USID is a USID or a GSID in the reg property, the Linux SPMI driver then reads the two address cells separately. U-boot's dev_read_addr() doesn't know how to handle this, so use ofnode_read_u32_index() to get just the USID. The Qcom pmic driver doesn't have support for GSID handling, so just ignore the second value for now. Signed-off-by: Caleb Connolly --- drivers/power/pmic/pmic_qcom.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/power/pmic/pmic_qcom.c b/drivers/power/pmic/pmic_qcom.c index ad8daf43f06f..f2ac6494811d 100644 --- a/drivers/power/pmic/pmic_qcom.c +++ b/drivers/power/pmic/pmic_qcom.c @@ -66,12 +66,19 @@ static const struct udevice_id pmic_qcom_ids[] = { static int pmic_qcom_probe(struct udevice *dev) { struct pmic_qcom_priv *priv = dev_get_priv(dev); + int ret; - priv->usid = dev_read_addr(dev); - - if (priv->usid == FDT_ADDR_T_NONE) + /* + * dev_read_addr() can't be used here because the reg property actually + * contains two discrete values, not a single 64-bit address. + * The address is the first value. + */ + ret = ofnode_read_u32_index(dev_ofnode(dev), "reg", 0, &priv->usid); + if (ret < 0) return -EINVAL; + debug("usid: %d\n", priv->usid); + return 0; }