From patchwork Mon Nov 6 20:57:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 741476 Delivered-To: patch@linaro.org Received: by 2002:adf:fd90:0:b0:32d:baff:b0ca with SMTP id d16csp1305046wrr; Mon, 6 Nov 2023 12:58:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrnYsD38KDU3o5tPBUMiVnOFuDtSFapzKL19JxG5b5C4xxUJyyP/X6MZnkkfv1ghDYiZ0U X-Received: by 2002:a17:907:25ca:b0:9e0:5d5c:aa6e with SMTP id ae10-20020a17090725ca00b009e05d5caa6emr3295110ejc.26.1699304327327; Mon, 06 Nov 2023 12:58:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699304327; cv=none; d=google.com; s=arc-20160816; b=mi70gfbwOrlZLjzy6indrSN5nKUUn49zR15Kfx69y6U+DEVA7HsuB7oqfkPPY+Ms+I RhAzhIH1UISQQItd2GTTx6GCRnBBR0F+fUI0/pLRCBxlr2fLQJKY+mFhB6XGIjQlWtjQ /x0xYYNzO0VajhK9dIWd8AgKLzMdh++QCPTb7C8ZlSOHZZyhxJq2aX9gJ03G6Zc2dyI7 UNvtBC33whdpd9+LB78RRD5APWfeOh1V3fPPEDiNsdhGGfmC27YMw20VC4lajdK2Kudw YmbdVti4Y8nGuQFJH6Fecjbcg/aPMTCNTGn2CJEM46Drm7nSvWIsF0FxH7MTAWn3bbSE 5DoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=018DhIg4oU2avzPOOIk9IL8QILD9VZBX7XSKEIBDpeg=; fh=ZD9xzrQlX6iMnsCMvknsFdBVrcKlSRYGoq0lz9tP0vE=; b=I50N2XJJPyb+/QpMHwp4utO4VsCWTbF0wLAHoYo+L4dF1yG6WTZykQoOy4kNCpG1Kc r7JQ61IiwFeSZ9BymaDFALVKEt4uIR0eIcbyGkjTk508mElNVNb5KEGXWFn8oMDxyIgy pDQ7IppukbAj7xb69JD4s2J/CoktvLLhLKdG+xNf1DH3y6sAeap7I2ckbnfA/ois/CjM Vq2M+hif2DKlibkf0BYB6Evd7HJ0cVF4L+a5TECIftDrrmfnDdkWzLDLDn7bqxtuJA2I thDSL6Vs09NCHLOVI7xB7U4klXKjkUGwFo+HNGZAn1udDC87oKjj5wCgJkSt6aT7+Sn2 WjWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZRWoOAoO; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id ht14-20020a170907608e00b009c761be2c39si259664ejc.779.2023.11.06.12.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 12:58:47 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZRWoOAoO; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F1D0F87136; Mon, 6 Nov 2023 21:58:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZRWoOAoO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EEBE3870ED; Mon, 6 Nov 2023 21:57:59 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F36FE86F5D for ; Mon, 6 Nov 2023 21:57:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-507adc3381cso6338228e87.3 for ; Mon, 06 Nov 2023 12:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699304277; x=1699909077; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=018DhIg4oU2avzPOOIk9IL8QILD9VZBX7XSKEIBDpeg=; b=ZRWoOAoOROC8df2HGJVVOFRYWo4p4/tN9tMQqa2w6XkSFKj7b0/4FxMgu2oMhI6zKP B69ztqoU7BvOwrEuE46oW3gJSgiJyj/cu9HTGn1eIxba09oFP9Slr2wO7ug5BLHSlZtx 95cCah/rORcMp77ggPKqu4sEAkfzH7t8Pmf32l2mUY5D76m949qn0m+1MPS8OGnauoQX oCwKYKXp7fl4nBkhpBjeXvfp3We1r7Lhg/QU1Sv3RmpgXDR6Qq4JHY8UjwyKRD3q4Ce9 jSxZkH/YurgSd1Xm4TTb/6b1Wsgwobei8RXM6ER1nWjZMalzgagCIGaR31W/zvLPAc/w ehVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699304277; x=1699909077; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=018DhIg4oU2avzPOOIk9IL8QILD9VZBX7XSKEIBDpeg=; b=gLx8+Jkfd9s6sbRO6WL2hXHZam00S+WttxHMcHl4gaU+LGkNmh/V52cgqeAExuvStu nXTMIwB4n86CADJcWZ9OXmvMmli5FjQyq4eEXxgsigMQnFJVmaB6KTQwKQQwf5+hAxwM PpGCdOsm2vKf2har4Mp2qL5ZioyIbjI5U1embX09mGtaHUr+g2/sSV3gt2ry0M0mS0gI qzxnpdYfSEvqWXPatdSAVqwKjPaG/GIW8za7s12eV1OuNPixw/6PpOXmo3E9mYpmpytl Sm+Fvj8KZqcHkE8+JHvefaqGMLFv3SR8lb//qPBJ/AlBRdVAZYdFYdzzNMqmNHM2OE4R hrOA== X-Gm-Message-State: AOJu0YwqsLBVphpgdegByk6G9D+JieCHkRdpr3zKKsTYS+dQXeLIRZPR EBAjB4g6LjzlYoPqKMQWdo186w== X-Received: by 2002:ac2:504d:0:b0:509:4a02:49f7 with SMTP id a13-20020ac2504d000000b005094a0249f7mr10295381lfm.44.1699304277349; Mon, 06 Nov 2023 12:57:57 -0800 (PST) Received: from lion.localdomain (host-92-25-138-185.as13285.net. [92.25.138.185]) by smtp.gmail.com with ESMTPSA id n11-20020a5d4c4b000000b0032f7d1e2c7csm511210wrt.95.2023.11.06.12.57.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 12:57:56 -0800 (PST) From: Caleb Connolly Date: Mon, 06 Nov 2023 20:57:33 +0000 Subject: [PATCH 5/5] pmic: qcom: dont use dev_read_addr to get USID MIME-Version: 1.0 Message-Id: <20231106-b4-qcom-dt-compat-v1-5-0ccbb7841241@linaro.org> References: <20231106-b4-qcom-dt-compat-v1-0-0ccbb7841241@linaro.org> In-Reply-To: <20231106-b4-qcom-dt-compat-v1-0-0ccbb7841241@linaro.org> To: Ramon Fried , Jorge Ramirez-Ortiz , Neil Armstrong , Sumit Garg , Mateusz Kulikowski , Jaehoon Chung , Caleb Connolly Cc: u-boot@lists.denx.de X-Mailer: b4 0.13-dev-4bd13 X-Developer-Signature: v=1; a=openpgp-sha256; l=1388; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=5K5TojjS22iKoGc3mT5WWQT3H8v2KeEZTGL2lkHxY9A=; b=owGbwMvMwCFYaeA6f6eBkTjjabUkhlTPYP863ofa5rPevJcNqdxfktGwn2Uh94E7Sbax5xUev JldGXKxo5SFQZCDQVZMkUX8xDLLprWX7TW2L7gAM4eVCWQIAxenAEzk80WG/yXRmx+Fe6mlSLT9 1m+XPNn6INpp66wT3W3vOr/I+FwV+8Hw3yfut4L17UIu0etTl6ssXBi67OqhW2vFD+/U5vMS3Vw ikgQA X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Linux DTs stuff a value indicating if the USID is a USID or a GSID in the reg property, the Linux SPMI driver then reads the two address cells separately. U-boot's dev_read_addr() doesn't know how to handle this, so use ofnode_read_u32_index() to get just the USID. The Qcom pmic driver doesn't have support for GSID handling, so just ignore the second value for now. Signed-off-by: Caleb Connolly --- drivers/power/pmic/pmic_qcom.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/power/pmic/pmic_qcom.c b/drivers/power/pmic/pmic_qcom.c index ad8daf43f06f..f2ac6494811d 100644 --- a/drivers/power/pmic/pmic_qcom.c +++ b/drivers/power/pmic/pmic_qcom.c @@ -66,12 +66,19 @@ static const struct udevice_id pmic_qcom_ids[] = { static int pmic_qcom_probe(struct udevice *dev) { struct pmic_qcom_priv *priv = dev_get_priv(dev); + int ret; - priv->usid = dev_read_addr(dev); - - if (priv->usid == FDT_ADDR_T_NONE) + /* + * dev_read_addr() can't be used here because the reg property actually + * contains two discrete values, not a single 64-bit address. + * The address is the first value. + */ + ret = ofnode_read_u32_index(dev_ofnode(dev), "reg", 0, &priv->usid); + if (ret < 0) return -EINVAL; + debug("usid: %d\n", priv->usid); + return 0; }