From patchwork Wed Sep 6 02:40:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 720396 Delivered-To: patch@linaro.org Received: by 2002:adf:d08b:0:b0:31d:da82:a3b4 with SMTP id y11csp2461555wrh; Tue, 5 Sep 2023 19:41:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFNlA7Ziti6ZTN/3YrxjwyqM9dictNhrJngN8baLoS/CUSVKsONL7RqADGFvgd9rb7+zhW X-Received: by 2002:adf:e2c8:0:b0:319:6e71:d1dd with SMTP id d8-20020adfe2c8000000b003196e71d1ddmr1195967wrj.12.1693968071810; Tue, 05 Sep 2023 19:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693968071; cv=none; d=google.com; s=arc-20160816; b=Ciqcg7n/KwZJ493x3pesopPiMplzMJWrbFzMNV1I8S9FodVsAxErn73LQ6AFBJcVwM biJw8B6pMEaZHx1QvE7E3gwQ0Br2p0TnwWGEvYCaFJbqf/DyaFHRW7fe/eP9Rmjyz0Yf 0E4OJhRP+o/YClPNWZxPGg71aBd32x78s6Kp1EMHR1ltB8UE4ltfcHETjq4y/VYnUJq3 VdLLOFDBysxaRsWsZjqEOLJYBVnzUq3iNLNssKfE9UFSDgyWoAKJPSFlR3TBPlLFjCyQ DLd5bZamwPpIwf5C4OzI6/nZ/Wy7V11yNLagf9149vfqkorqWbQzTouALmnbNbOd/DBN nlog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=efrPIYuVGbqbaZHIcWjhNXthVhwrIIYknB2a7MQG9ew=; fh=Yz321xYbZlOZFLAVVWewQ+h9487s8fAdGcGeu++kLX8=; b=VAIUgMmMvTrhGwcwpT4J1LpAQZJVEp9jwCOHBJkgPb3nX+rCocBRIvRqAabREby06V /WqyecciRPieE/hTqWWkhisGhZI6TiUkoroZ6avaZubyVpk7XKGsqTUKn9E5Rxf/8hKB C4BEjPjwywhLrcKxxS9I77MqB3B7hHdHkITctUWvgJoxFP63YVutPUDNPeroFvTlkWoh o55+iv2Logg5AB2NGo+EszXyRgQrMPqXQq1qfFIkt5OvsFzDq8DdAAW5HGdgs67eQIrm eWKU7EFv5eQjksELyAEsqGKRYYTSqWzLtC54D8m3Lj06D/NsBTTVgK4jmxhx+oYobaQL jSIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KlVdTSS1; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id r7-20020a5d6947000000b0031dcd537556si6454866wrw.68.2023.09.05.19.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 19:41:11 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KlVdTSS1; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D85108667A; Wed, 6 Sep 2023 04:41:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="KlVdTSS1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D1CD286667; Wed, 6 Sep 2023 04:41:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1034586591 for ; Wed, 6 Sep 2023 04:41:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-68cc1b70e05so607869b3a.1 for ; Tue, 05 Sep 2023 19:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693968059; x=1694572859; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=efrPIYuVGbqbaZHIcWjhNXthVhwrIIYknB2a7MQG9ew=; b=KlVdTSS1wD7AfajaGrPHv6eEtFUZOqEbv3hHQfbCSlHzbt/a2dV+WQlywAaL5AYgtG JS17RT4XgJhpsUBNXRCc1dniuL4EGnXrqVp+/bnEkuFlsNqj1ZDFxBjkU/kWKJ8AHojv cm+F/DhuS653DJ+vloetcsrTaTuqv7NPnVICe1061xg0WNVZdpTmhXpnv60tCXnL+jX5 NSGCsyZCTF1U6W3x47Lsq0tYaFNku2ZMslAbZ9gt9srG+t4WCleoPRm7Dae6X4+iWOhI D3lhlrecFs8BtVX3+99GOaqaZrrI8cSrpLyyJduI7ixynQ9UsB1PMD1DTHJS8yRrsDAi DJ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693968059; x=1694572859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=efrPIYuVGbqbaZHIcWjhNXthVhwrIIYknB2a7MQG9ew=; b=BPLDg+kvdlXOeD9iDU4lUURgzaJowUffq53UBKyeCfHo1zD0OWdEpDzqFY+7h+SZUq mqRxraTo3J5GNFX//dEHtnHjE+5868hgNarPeHUmBTGrMlPfjaKXkPwO0jMKpXSm66WJ /YtLih5dYPS79CEY4xt2JF6FSVCojqEnsvs+ZSay7RpwDv4Ix0HLfQfUUvb5XdFCnU9u FACmOLBpb4w7HJegEWQ5w6H5yQGVW7NfXoNH6T9AFNjyEFvVT5A4C6UIva3kxGAhfE8Z 1jowlKRh091kpJSo7QFdn6cltpJvi1QCOVeCRZBfwLgZgkjEg7nzVXkpo/EjFZsHsNdC Hcrw== X-Gm-Message-State: AOJu0Yw6a/UI/0QLi9s+iVwtK2aZ5DtZyq04LKl5rVeDIIHgQlp2fQBs kcRfyPp/pbWKy6JNLBCAe/7bNZ3YWeMzhf/+YG9+vg== X-Received: by 2002:a05:6a20:8f15:b0:13d:7aa3:aa6c with SMTP id b21-20020a056a208f1500b0013d7aa3aa6cmr19774235pzk.0.1693968059271; Tue, 05 Sep 2023 19:40:59 -0700 (PDT) Received: from octopus.. ([2400:4050:c3e1:100:8294:a07d:b7e9:4033]) by smtp.gmail.com with ESMTPSA id c5-20020a6566c5000000b0056428865aadsm9145378pgw.82.2023.09.05.19.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 19:40:58 -0700 (PDT) From: AKASHI Takahiro To: u-boot@lists.denx.de Cc: etienne.carriere@st.com, michal.simek@amd.com, sjg@chromium.org, linus.walleij@linaro.org, Oleksii_Moisieiev@epam.com, AKASHI Takahiro Subject: [RFC 1/6] firmware: scmi: fix protocol enumeration logic Date: Wed, 6 Sep 2023 11:40:06 +0900 Message-Id: <20230906024011.17488-2-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230906024011.17488-1-takahiro.akashi@linaro.org> References: <20230906024011.17488-1-takahiro.akashi@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The original logic in enumerating all the protocols accidentally modifies a *loop* variable, node, at Voltage domain protocol. So subsequent protocol nodes in a device tree won't be detected. Signed-off-by: AKASHI Takahiro --- drivers/firmware/scmi/scmi_agent-uclass.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c b/drivers/firmware/scmi/scmi_agent-uclass.c index 46a2933d51a4..79584c00a066 100644 --- a/drivers/firmware/scmi/scmi_agent-uclass.c +++ b/drivers/firmware/scmi/scmi_agent-uclass.c @@ -422,8 +422,11 @@ static int scmi_bind_protocols(struct udevice *dev) case SCMI_PROTOCOL_ID_VOLTAGE_DOMAIN: if (IS_ENABLED(CONFIG_DM_REGULATOR_SCMI) && scmi_protocol_is_supported(dev, protocol_id)) { - node = ofnode_find_subnode(node, "regulators"); - if (!ofnode_valid(node)) { + ofnode sub_node; + + sub_node = ofnode_find_subnode(node, + "regulators"); + if (!ofnode_valid(sub_node)) { dev_err(dev, "no regulators node\n"); return -ENXIO; }