| Message ID | 20230308202653.1926303-2-ralph.siemsen@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Renesas RZ/N1 SoC initial support | expand |
On 3/8/23 21:26, Ralph Siemsen wrote: > Commit 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") > added SPL_ARMV7_SET_CORTEX_SMPEN to enable setting SMP bit. For > platforms not using SPL boot, add the corresponding non-SPL config, > so that CONFIG_IS_ENABLED(ARMV7_SET_CORTEX_SMPEN) works as expected. > > Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org> You could send this patch as a separate one.
On Mon, Apr 17, 2023 at 07:04:15PM +0200, Marek Vasut wrote: >On 3/8/23 21:26, Ralph Siemsen wrote: >>Commit 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") >>added SPL_ARMV7_SET_CORTEX_SMPEN to enable setting SMP bit. For >>platforms not using SPL boot, add the corresponding non-SPL config, >>so that CONFIG_IS_ENABLED(ARMV7_SET_CORTEX_SMPEN) works as expected. >> >>Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> > >Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > >You could send this patch as a separate one. In fact I did that almost a year ago: https://lore.kernel.org/u-boot/20220421175202.2614945-1-ralph.siemsen@linaro.org/T/#u Ralph
On 4/17/23 20:26, Ralph Siemsen wrote: > On Mon, Apr 17, 2023 at 07:04:15PM +0200, Marek Vasut wrote: >> On 3/8/23 21:26, Ralph Siemsen wrote: >>> Commit 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") >>> added SPL_ARMV7_SET_CORTEX_SMPEN to enable setting SMP bit. For >>> platforms not using SPL boot, add the corresponding non-SPL config, >>> so that CONFIG_IS_ENABLED(ARMV7_SET_CORTEX_SMPEN) works as expected. >>> >>> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> >> >> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org> >> >> You could send this patch as a separate one. > > In fact I did that almost a year ago: > https://lore.kernel.org/u-boot/20220421175202.2614945-1-ralph.siemsen@linaro.org/T/#u Hmmm, Tom (+Cc) pointed out the patch does not do anything, but that is not correct, is it ? If I look at 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") , this extra Kconfig symbol just makes that functionality available outside of SPL (i.e. in normal U-Boot), while before this change the functionality was only available in SPL. Right ? (so yeah, I think this patch should go in, and could go in separately) But please correct me if I'm wrong.
On Mon, Apr 17, 2023 at 4:21 PM Marek Vasut <marek.vasut@mailbox.org> wrote: > > On 4/17/23 20:26, Ralph Siemsen wrote: > > On Mon, Apr 17, 2023 at 07:04:15PM +0200, Marek Vasut wrote: > >> You could send this patch as a separate one. > > > > In fact I did that almost a year ago: > > https://lore.kernel.org/u-boot/20220421175202.2614945-1-ralph.siemsen@linaro.org/T/#u > > Hmmm, Tom (+Cc) pointed out the patch does not do anything, but that is > not correct, is it ? If I look at 2564fce7eea3 ("sunxi: move Cortex > SMPEN setting into start.S") , this extra Kconfig symbol just makes that > functionality available outside of SPL (i.e. in normal U-Boot), while > before this change the functionality was only available in SPL. Right ? Correct, my patch makes the symbol available outside of SPL. I think Tom's objection was to adding the symbol without any users. This is rectified by patch 07 ("ARM: rzn1: basic support"), Ralph
On 4/18/23 16:32, Ralph Siemsen wrote: > On Mon, Apr 17, 2023 at 4:21 PM Marek Vasut <marek.vasut@mailbox.org> wrote: >> >> On 4/17/23 20:26, Ralph Siemsen wrote: >>> On Mon, Apr 17, 2023 at 07:04:15PM +0200, Marek Vasut wrote: >>>> You could send this patch as a separate one. >>> >>> In fact I did that almost a year ago: >>> https://lore.kernel.org/u-boot/20220421175202.2614945-1-ralph.siemsen@linaro.org/T/#u >> >> Hmmm, Tom (+Cc) pointed out the patch does not do anything, but that is >> not correct, is it ? If I look at 2564fce7eea3 ("sunxi: move Cortex >> SMPEN setting into start.S") , this extra Kconfig symbol just makes that >> functionality available outside of SPL (i.e. in normal U-Boot), while >> before this change the functionality was only available in SPL. Right ? > > Correct, my patch makes the symbol available outside of SPL. > > I think Tom's objection was to adding the symbol without any users. > This is rectified by patch 07 ("ARM: rzn1: basic support"), ACK
diff --git a/arch/arm/cpu/armv7/Kconfig b/arch/arm/cpu/armv7/Kconfig index f1e4e26b8f..e33e53636a 100644 --- a/arch/arm/cpu/armv7/Kconfig +++ b/arch/arm/cpu/armv7/Kconfig @@ -107,6 +107,11 @@ config ARMV7_LPAE Say Y here to use the long descriptor page table format. This is required if U-Boot runs in HYP mode. +config ARMV7_SET_CORTEX_SMPEN + bool + help + Enable the ARM Cortex ACTLR.SMP enable bit in U-boot. + config SPL_ARMV7_SET_CORTEX_SMPEN bool help
Commit 2564fce7eea3 ("sunxi: move Cortex SMPEN setting into start.S") added SPL_ARMV7_SET_CORTEX_SMPEN to enable setting SMP bit. For platforms not using SPL boot, add the corresponding non-SPL config, so that CONFIG_IS_ENABLED(ARMV7_SET_CORTEX_SMPEN) works as expected. Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> --- This will be used by the following commit that adds ARCH_RZN1. (no changes since v1) arch/arm/cpu/armv7/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)