From patchwork Tue Feb 7 16:20:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Liu X-Patchwork-Id: 651265 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp2965849pva; Tue, 7 Feb 2023 08:21:02 -0800 (PST) X-Google-Smtp-Source: AK7set/CCIngHsSdGDFHmthRPjjRPoYVP6lbB/q5CI8PC3wiNfV1ujsO+dJ38iXmGbFhjznRqz1U X-Received: by 2002:a4a:850d:0:b0:4fa:d6a1:fc3c with SMTP id k13-20020a4a850d000000b004fad6a1fc3cmr1754508ooh.0.1675786862447; Tue, 07 Feb 2023 08:21:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675786862; cv=none; d=google.com; s=arc-20160816; b=r6SY3jYdXGBEIMU8c5ggwz4jjKThKubGjDizJMFXDrpURVDd+X4gG2nJPaIe7MU+st zCdUQmJfEJEz6wYX8gLiNSAli2bixepPyPH2gOCY4VuWBzGEROMg2aI1VbuDoswi0J4r rUt+Vtwpk1VaFH6ICe/aeYr4AhWdSrIXqEqW4jihfvS9exfpS3yR7GPzpQNX72yV08EZ Td7bhl5+VOHh2XEQbCRBT3waFc6rLd9nFNq+qyWAW6qZkrmo8ejFVXrt9uwCFtSemHnm tt4MMQlTyCkex8PSrS1pN1zNI6K8w5PUWwiUdtmOM1Dz7a19eu3QfNwDRup1kZtTagc2 +yzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BmrN5jXMiSepa2dbMHxu2cuzXVQqppRip1SBhY7bF5A=; b=QKSyGBDEBrA14ZDRP1PDd2CItjELkxSOopIeRUh4akL5XGBHu1HTL8sVek+dmhCDx1 UmgBpTalbY4SV6BQ4bsX6rCnmf5GCLG4x/51ZXO3QwSwBIdoquPbEXENtBMXy/9GGwN5 QAuZhbQ2x+wCabeNzxR/ngU4N/CdNwE0k5oR9FyzPbHLCYoQiPyIdv9GtY5mAp03c6ZN vuYpAbNP+1oCFuy6tsgpWXufz0MQeskGEXvThX7alGSbYBwfX3p+vEdss2+XFBBJee3u eWReyNUcnyaqcyWMtvcyH4hIbyKLicczAQEpfd1/Dyc5kXYEFbAYe0Y9SmzZ2k81arqu TZPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vhmyS8o8; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id x28-20020a4a621c000000b0051745819a2asi16309555ooc.72.2023.02.07.08.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:21:02 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vhmyS8o8; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1817885E39; Tue, 7 Feb 2023 17:20:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="vhmyS8o8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BAF6F85D9E; Tue, 7 Feb 2023 17:20:34 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B1A5485E34 for ; Tue, 7 Feb 2023 17:20:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=paul.liu@linaro.org Received: by mail-pf1-x42f.google.com with SMTP id n2so11126028pfo.3 for ; Tue, 07 Feb 2023 08:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BmrN5jXMiSepa2dbMHxu2cuzXVQqppRip1SBhY7bF5A=; b=vhmyS8o8kmCQglhJczDBY6NIm6h7X4yWIt4slXmJDJEJgPoKUki31HrleCvPbmc/XO Ahwdm++I4EMC90JOCFwdJGpnkeQms4rKZrGXz7HmExbllGzaxrX2Sdi/pR2hOldpApTY j2rywetSUdHdX2C2v7K1a8uzFIzsihSPvF40kCvcwzxLdxjy39A/ZhB8mi9CVbX4W122 QMrXIlpIGspevOGDGhXO381GshwtIfMwYqg1EvFvjRpHHS/O/S6E3PooyMN/y+KcTPwj 0IPW/HQaMAEw1Ap2iqcrpj1TflMc3yGVXk28kM9gxht4m8Bt5Kr8PTZVx8Sq5eXF2xjr 4XJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BmrN5jXMiSepa2dbMHxu2cuzXVQqppRip1SBhY7bF5A=; b=l/tOCe1sQZU1MzWDX1AE/nV5pbOSswq8nDnqp1ACgrmABNFcslqAy3sLaVBCQTv9Nb fM/c+tx1BfORFWULwFIoMm1hPWGMGDtHjepzFZbHPVuO5vw6/1HFlcIu8boa/nrlk5B/ o+oAK1/MKFVnBL/EOUnHgYK5AaT4obH+nADkNt3w8ErMR+6OWdepNfFQPw12ZQ3aRVA/ DacvG2hJtcXkKZbsb/lgZhfzT6nEWCWLo8d2ocAaR7qJ9Un+2lh5AmXlQy38JhjLKttT rqQ2GJM4oFQzmv93Tzh1Wx2Xpx+E1QNIddCvWnJJhQ+KOEa9gEsW84S8F79rCsWNVF6d jUZQ== X-Gm-Message-State: AO0yUKX1kHFA7CYWWW1MGtGu9wbHQdx3L3KJOi7IuLqRnJF98W4mK5ET rif6agf95yjkJj8eP19Y8q6cFbOwox7U7dgP X-Received: by 2002:aa7:9aef:0:b0:594:251f:ffe1 with SMTP id y15-20020aa79aef000000b00594251fffe1mr4067450pfp.19.1675786828692; Tue, 07 Feb 2023 08:20:28 -0800 (PST) Received: from localhost ([111.184.129.17]) by smtp.gmail.com with ESMTPSA id e16-20020a62ee10000000b0058bca264253sm1973185pfi.126.2023.02.07.08.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 08:20:28 -0800 (PST) From: "Ying-Chun Liu (PaulLiu)" To: u-boot@lists.denx.de Cc: "Ying-Chun Liu (PaulLiu)" , =?utf-8?q?Pierre-Cl?= =?utf-8?q?=C3=A9ment_Tosi?= , Tom Rini Subject: [PATCH 2/2] arm64: Initialize TLB memory if CMO_BY_VA_ONLY Date: Wed, 8 Feb 2023 00:20:14 +0800 Message-Id: <20230207162014.58664-3-paul.liu@linaro.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230207162014.58664-1-paul.liu@linaro.org> References: <20230207162014.58664-1-paul.liu@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Memory used to hold the page tables is allocated from the top of RAM with no prior initialization and could therefore hold invalid data. As invalidate_dcache_all() will be called before the MMU has been initialized and as that function relies indirectly on the page tables when using CMO_BY_VA_ONLY, these must be in a valid state from their allocation. Signed-off-by: Ying-Chun Liu (PaulLiu) Signed-off-by: Pierre-Clément Tosi Cc: Tom Rini --- arch/arm/lib/cache.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c index 1a589c7e2a..7a16015867 100644 --- a/arch/arm/lib/cache.c +++ b/arch/arm/lib/cache.c @@ -159,6 +159,15 @@ __weak int arm_reserve_mmu(void) */ gd->arch.tlb_allocated = gd->arch.tlb_addr; #endif + + if (IS_ENABLED(CONFIG_CMO_BY_VA_ONLY)) { + /* + * As invalidate_dcache_all() will be called before + * mmu_setup(), we should make sure that the PTs are + * already in a valid state. + */ + memset((void *)gd->arch.tlb_addr, 0, gd->arch.tlb_size); + } #endif return 0;