From patchwork Tue Jan 10 19:23:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Poulain X-Patchwork-Id: 640890 Delivered-To: patch@linaro.org Received: by 2002:a17:522:f3c4:b0:4b4:3859:abed with SMTP id in4csp2879699pvb; Tue, 10 Jan 2023 11:23:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXtog/YgrXr9u4cEgwQRgfPlDNZDXk673wuRtbi8+a3JBM25WKZXE5qnwqx8twlYDZ1Ebx73 X-Received: by 2002:a05:6808:dc6:b0:35a:26c:1843 with SMTP id g6-20020a0568080dc600b0035a026c1843mr27991320oic.36.1673378612680; Tue, 10 Jan 2023 11:23:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673378612; cv=none; d=google.com; s=arc-20160816; b=RT/9s+2r0nTtWYm5kcqezyGkozhSDi9vHrXoUd05a5ieWyH8GIpxGV/SVCHKh7SJot d/soWcRqxbySc7U7ILAUn4G9DH4fPLtGXzXQslbdy7+w4ekaFquMw0//mcrjiF5IjKtu LlHlQJFvr5cjM9qb6L1E5OCwGBM0f0MMJJXbeSPH8XCWKahqifywg5ARJcHpzByB5Qq6 +WC4T7SOAtIWv82meNWO0pv8+PfEPS6DSVIkyL8b0n3fdTWJ31XXm0Ur8mTkfcxqxn+1 zfCq4vYfVJb4a+Wyf0b/83EctLuiaEe2oz+rvIKl1TFjQwFEmWf6XWvdKFzYO3O2HQhh Qv8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=v8VHeb83n6biSo6Ch1Oqm8Tk3tVdXIhVR0cBQmOfJ7I=; b=OfQSPZVZ43pNAja0g1ZiG2vI2upde9NtIAOptQTl1tkRvmaqQ0HEs+0xRiMZPCUkdf ix+kWJnZL1wpuls9d7MGedHpu4AGEenWV77qkJwerrEoQ7VQ/TPIWXSL6T4DY2bW/tLb nzR09Qdo+nHuTNzDku05QIo5aDn7+lPlCLHBr+zCUs6cs3uUQqdbNvn73ZMQI6KX9RtP bOavhSC5aT2J3BZqgOia+xiUU0jLXjUhh2ki9sztFh95tSZp97WqOs1o6K64EuiEwOAT glMGtC/FNv5zQNe6D7fgGNBBv3J3ei7rQGolDsOe48GqVU7S+JE/0iJwgctzCwuAxF+V tP4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x5b6ic05; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id w15-20020a056808018f00b0035e56c9ad9dsi10787829oic.35.2023.01.10.11.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 11:23:32 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=x5b6ic05; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D82BD85615; Tue, 10 Jan 2023 20:23:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="x5b6ic05"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2C0385689; Tue, 10 Jan 2023 20:23:28 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D029785615 for ; Tue, 10 Jan 2023 20:23:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=loic.poulain@linaro.org Received: by mail-wm1-x335.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so10904300wms.4 for ; Tue, 10 Jan 2023 11:23:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=v8VHeb83n6biSo6Ch1Oqm8Tk3tVdXIhVR0cBQmOfJ7I=; b=x5b6ic05OF2K7Qhyhij/l4K8RoDIvDBiP9YmmgShz8WKuMN+/EbxHXY1abYrfWsMrD RKwwa4SZiheeYPhq5ZQ+jgpHkRAVxg0kyN5HD3kwO1RpTVtG4g2NmY8R3t+f6MD8YhZ3 ynyPp+Fp2zpCY8yQgLudv9b4/d/tLeSni7NP26bBfxOGscprqtVRxvLHdLOAhCtYYToO T/VxKfYC0t23RHJLjDYwEtkscxSHrLkDAU2Tsu3Qg8mXlBJECrLsjQsgbSThMgrh+a5V 0DL1HthNf9eZRB72wV0fPAfr1NikuxpaBksiGfe3U0pmmR42ajDJZezcAqAFWDo8rHbo fcUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v8VHeb83n6biSo6Ch1Oqm8Tk3tVdXIhVR0cBQmOfJ7I=; b=2xxmdccpKsp8hx38ddAv5EdMDIYbwRBWZl9VagFAZQNaOaQQBq5LswEYqpYNUQfvh7 u+mM8/xtloEqdDZ+MGv1nyOSmVkk+o4W5vbzX1oXaQ/V65rmQnnqIUUcYf2XTVGMaYvz eBVIHXTH/XB5WQBh/NHcKUsXWpYz6TiMMvwimi+Cj8DqFlaeWTxzqaMV8kw0dXKHbOOj IRRkC+Tt3uyX7xr3lP25yldP+alv8XzMHsg95z1NxDR2ebeVKl25bFdxHjB4Jn6xEe7R NTwbFyvkrijFCM3O6ULLWHacUxQJ1BkjP1ccYf6jm1OakigeI+52ejTGqlXtD9XLyfbx K2ng== X-Gm-Message-State: AFqh2kq5XR/fhJR+G0j0rcjPH5uWhmNlJNqTBWxTp3awkXuuxVLSeEPw lFGyJMr6vJm7rGXWMWBkpVM8Eg== X-Received: by 2002:a05:600c:4e47:b0:3d9:e9ef:fa08 with SMTP id e7-20020a05600c4e4700b003d9e9effa08mr8686134wmq.3.1673378606365; Tue, 10 Jan 2023 11:23:26 -0800 (PST) Received: from loic-ThinkPad-T470p.. ([2a01:e0a:82c:5f0:a2ad:457f:18a:ffcb]) by smtp.gmail.com with ESMTPSA id l27-20020a05600c2cdb00b003a84375d0d1sm22366087wmc.44.2023.01.10.11.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 11:23:25 -0800 (PST) From: Loic Poulain To: sbabic@denx.de, festevam@gmail.com Cc: uboot-imx@nxp.com, u-boot@lists.denx.de, LW@karo-electronics.de, Loic Poulain Subject: [PATCH v2 1/2] serial: mxc: Speed-up character transmission Date: Tue, 10 Jan 2023 20:23:21 +0100 Message-Id: <20230110192322.1874021-1-loic.poulain@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Instead of waiting for empty FIFO condition before writing a character, wait for non-full FIFO condition. This helps in saving several tens of milliseconds during boot (depending verbosity). Signed-off-by: Loic Poulain --- v2: Add 2/2 fixing transfert abort & char corruption drivers/serial/serial_mxc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 82c0d84628..f8c49865be 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -223,11 +223,11 @@ static void mxc_serial_putc(const char c) if (c == '\n') serial_putc('\r'); - writel(c, &mxc_base->txd); - /* wait for transmitter to be ready */ - while (!(readl(&mxc_base->ts) & UTS_TXEMPTY)) + while (readl(&mxc_base->ts) & UTS_TXFULL) schedule(); + + writel(c, &mxc_base->txd); } /* Test whether a character is in the RX buffer */ @@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev, const char ch) struct mxc_serial_plat *plat = dev_get_plat(dev); struct mxc_uart *const uart = plat->reg; - if (!(readl(&uart->ts) & UTS_TXEMPTY)) + if (readl(&uart->ts) & UTS_TXFULL) return -EAGAIN; writel(ch, &uart->txd);