From patchwork Mon Nov 28 12:45:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahisa Kojima X-Patchwork-Id: 628983 Delivered-To: patch@linaro.org Received: by 2002:a17:522:c983:b0:460:3032:e3c4 with SMTP id kr3csp2912683pvb; Mon, 28 Nov 2022 04:45:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf77aD99BcCr3OmNz0RL1sqg5jV4BO/hh/SMkSvRC7jis49RbCESCaLfGpqIXKfWAb2Dx1i3 X-Received: by 2002:a02:7409:0:b0:375:4727:8625 with SMTP id o9-20020a027409000000b0037547278625mr15051148jac.300.1669639530702; Mon, 28 Nov 2022 04:45:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669639530; cv=none; d=google.com; s=arc-20160816; b=Dnd425gmL6Uf1LNiGY2IKO8ngarUJHgwomhFYxEcIXo3szhHhprcwm6gr43K9OsBNH RBr0UA6NoZUti+vEy+4NtyNk3/0ps/jZYR3Ds+wZL7qCAp+sb9R+jhvwrMn8gdKxM1eI qGnc1G3RTcTnyGn/TIp9dG4Zpw8r/B7Je/vMstBSLZ8zIKtcZa+4oYZsKrQgqzWdu9MW Yn8n4itYlCPEeaCH53erxqt/aklmx8gAKkEwdihJPbW/vQLaSoBOdjJ6UeAz6TotzbUp vvFfJtl3Ln4oo8n1XUDCPfH7o5Tc0u4bund3wr8e1qcWfiN1FwvyqXJP7oGBtghtG1tW S1Eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=AYLv2DdFWoM7dDTfVFGLmo64B4+CdFRlEGO2AbinN3c=; b=xH9W6Mado1rkq6dp1KX0ryJaHN0mnLpg7xNl56G+J5uwpLY/pNK8Tfu1XBx7nw0eHL UbPiP+FNF4H5IK2Rd5VaQB3cbwc4617EDsW6uLTm7RpQIqLGwxwoEiEsatontLorFxfk ks1HPv1m4n0u1u0NqFR8L02RJ/9xUI8d+Xf48CQD3JgbEXgIt6vbQGBYXAnQUZwYMp7h lRoXcNkvEyj1FrIlC5mLhJUh9XVOY6vCJzfEEHf/oKNUhwq7GRYpNkUQYT+owPoFP+nH 9XRjQcG5qiivgbq8Yfzvl6AM+oQ1AoUwqovQaIqV07ieOwMk0iLQibu7igfZxVHTiWaP wWFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="JJmw/70O"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id t6-20020a02c906000000b00374fe355993si8398792jao.157.2022.11.28.04.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 04:45:30 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="JJmw/70O"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B04AD85243; Mon, 28 Nov 2022 13:45:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JJmw/70O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BA10A8525A; Mon, 28 Nov 2022 13:45:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B35B58524F for ; Mon, 28 Nov 2022 13:45:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=masahisa.kojima@linaro.org Received: by mail-pl1-x62e.google.com with SMTP id g10so10011904plo.11 for ; Mon, 28 Nov 2022 04:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=AYLv2DdFWoM7dDTfVFGLmo64B4+CdFRlEGO2AbinN3c=; b=JJmw/70OVra27M+6SNOE9BZRA1/fNVhSVyakxQcH/ESJcZ6N4583knVd12OXI1AzMj BNSfZlUDEO4yoAzIIKE40c6M6pZV70twiAVbnkqrH9OnDgClwliaQq0Ztsjtrgn+ETtM vA822qOZpK0sk0WMZjV0qXwGO69wLCcmsaumyYMj+9ZKaGe4Lx1uo1tb9APNe/EQVPUJ 2vZvM4GfY10bkSqHPU9Ub1OTkWuUA9HVVwDykok/ytwar0lBF0CUerC/PNC955I960lD lWMpDYPvnbKhVIctKQZB647btvQofPLiWeojSjJaG8D/yW620Iv/yHlNDDEc0mL9UQqh 1w+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AYLv2DdFWoM7dDTfVFGLmo64B4+CdFRlEGO2AbinN3c=; b=c5p54ahy2e9dnZwocG+lslC9CUOUqvmzXECRydNeSydjRvvzAHDvnUpQUAlxhoC4OZ RhtsNP7jKp5puCYY2jzqTzCOpCdpTQiYIOpXUXKE6C/hyBm4+0KQqUg2//HP8xOjcu15 ZrkSkkoZhm/46JTztSe/X9IOxEhveWBMW62f4tY/vU5d2/ySSjQKjZVo2Pzo4ivZ93CQ FqO3dNUstrFKRKlfys2kdkbm6CFOGeWK6e4+VztRSlW7XzjAh7OA/JlCHlimaNVL9UzC +fvFJIoDyMjasKaxZlUrV/wMpp25BqldpOKZZ5JMVXg1PwlFmg2a8944+cbMxanLh29L 54pg== X-Gm-Message-State: ANoB5pnnKxeDwbH7wiQ0jxvpZCPmxf/NwuoZhHxk9DNPiBBqNGYK24Ps AJH18X4OCOtcMjM9CnlaHVEMuVwrBXAJUA== X-Received: by 2002:a17:90b:394c:b0:213:1935:9744 with SMTP id oe12-20020a17090b394c00b0021319359744mr54431424pjb.207.1669639503695; Mon, 28 Nov 2022 04:45:03 -0800 (PST) Received: from localhost.localdomain ([240d:1a:cf7:5800:82fa:5bff:fe4b:26b1]) by smtp.gmail.com with ESMTPSA id w27-20020a63475b000000b0047681fa88d1sm3925303pgk.53.2022.11.28.04.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 04:45:02 -0800 (PST) From: Masahisa Kojima To: u-boot@lists.denx.de Cc: Heinrich Schuchardt , Ilias Apalodimas , Jerome Forissier , Masahisa Kojima Subject: [PATCH v2 1/5] eficonfig: fix going one directory up issue Date: Mon, 28 Nov 2022 21:45:05 +0900 Message-Id: <20221128124509.6939-2-masahisa.kojima@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221128124509.6939-1-masahisa.kojima@linaro.org> References: <20221128124509.6939-1-masahisa.kojima@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The directory name in eficonfig menu entry contains the '\' separator. strcmp() argument ".." is wrong and one directory up handling does not work correctly. strcmp() argument must include '\' separator. Signed-off-by: Masahisa Kojima Reviewed-by: Ilias Apalodimas --- No change since v1 cmd/eficonfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index 97d35597a2..5529edc85e 100644 --- a/cmd/eficonfig.c +++ b/cmd/eficonfig.c @@ -488,7 +488,7 @@ static efi_status_t eficonfig_file_selected(void *data) if (!info) return EFI_INVALID_PARAMETER; - if (!strcmp(info->file_name, "..")) { + if (!strcmp(info->file_name, "..\\")) { struct eficonfig_filepath_info *iter; struct list_head *pos, *n; int is_last;