diff mbox series

[3/3] EFI: Update the documentation to reflect the correct value of OsIndications

Message ID 20220531071535.219661-4-sughosh.ganu@linaro.org
State Superseded
Headers show
Series EFI: Miscellaneous capsule update fixes | expand

Commit Message

Sughosh Ganu May 31, 2022, 7:15 a.m. UTC
The OsIndications is a 64 bit variable, and the current code expects
the value of the variable to be 64 bit. Update the documentation to
reflect this fact.

Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
---
 doc/develop/uefi/uefi.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heinrich Schuchardt June 1, 2022, 6:15 a.m. UTC | #1
On 5/31/22 09:15, Sughosh Ganu wrote:
> The OsIndications is a 64 bit variable, and the current code expects
> the value of the variable to be 64 bit. Update the documentation to
> reflect this fact.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
>   doc/develop/uefi/uefi.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/develop/uefi/uefi.rst b/doc/develop/uefi/uefi.rst
> index 753a4e5e29..941e427093 100644
> --- a/doc/develop/uefi/uefi.rst
> +++ b/doc/develop/uefi/uefi.rst
> @@ -326,7 +326,7 @@ bit in OsIndications variable with
>
>   .. code-block:: console
>
> -    => setenv -e -nv -bs -rt -v OsIndications =0x04
> +    => setenv -e -nv -bs -rt -v OsIndications =0x0000000000000004
>
>   Since U-boot doesn't currently support SetVariable at runtime, its value
>   won't be taken over across the reboot. If this is the case, you can skip
Ilias Apalodimas June 1, 2022, 8:24 a.m. UTC | #2
On Wed, 1 Jun 2022 at 09:15, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 5/31/22 09:15, Sughosh Ganu wrote:
> > The OsIndications is a 64 bit variable, and the current code expects
> > the value of the variable to be 64 bit. Update the documentation to
> > reflect this fact.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> > ---
> >   doc/develop/uefi/uefi.rst | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/develop/uefi/uefi.rst b/doc/develop/uefi/uefi.rst
> > index 753a4e5e29..941e427093 100644
> > --- a/doc/develop/uefi/uefi.rst
> > +++ b/doc/develop/uefi/uefi.rst
> > @@ -326,7 +326,7 @@ bit in OsIndications variable with
> >
> >   .. code-block:: console
> >
> > -    => setenv -e -nv -bs -rt -v OsIndications =0x04
> > +    => setenv -e -nv -bs -rt -v OsIndications =0x0000000000000004
> >
> >   Since U-boot doesn't currently support SetVariable at runtime, its value
> >   won't be taken over across the reboot. If this is the case, you can skip
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/doc/develop/uefi/uefi.rst b/doc/develop/uefi/uefi.rst
index 753a4e5e29..941e427093 100644
--- a/doc/develop/uefi/uefi.rst
+++ b/doc/develop/uefi/uefi.rst
@@ -326,7 +326,7 @@  bit in OsIndications variable with
 
 .. code-block:: console
 
-    => setenv -e -nv -bs -rt -v OsIndications =0x04
+    => setenv -e -nv -bs -rt -v OsIndications =0x0000000000000004
 
 Since U-boot doesn't currently support SetVariable at runtime, its value
 won't be taken over across the reboot. If this is the case, you can skip