From patchwork Tue Nov 9 16:08:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 518044 Delivered-To: patch@linaro.org Received: by 2002:ad5:5208:0:0:0:0:0 with SMTP id p8csp1899663iml; Tue, 9 Nov 2021 08:09:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwI40B+h5H/wTSU2VDtkBA0xRtpajhT1WqFZywAPDu5uC/Tf1lUHvkMvImpcar3nJn3LUsB X-Received: by 2002:aa7:d3cf:: with SMTP id o15mr11947290edr.265.1636474161839; Tue, 09 Nov 2021 08:09:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636474161; cv=none; d=google.com; s=arc-20160816; b=cPTKWqM8sr5kQrmnzspLiusHyCKtaPqWSnNhIXhnV4IYiaO1ek94w+mOcpQ1KALaxs FWw+vjh2bFc6pxeWzYW/i/pv4gu+1KKw2LJ22BeWP3nQ3K+3zM1zoUDk/7Gg4I+xO132 7NhlZMgMoHjox12Exqa8Wy0n2Xj3LeIJAmj35u/XWMOOhMqBZNEkZhb3yxgHe5eLhbZk hbxGw3QMtgWEX1QtbktShfzMahDlV3tbQD/ey1C53ghB7XSdPLRtTrQdFNoe0X9sT5b+ x5wMq3a/ywN9Z+llzK52xtoArZ+aBhdGlJYJfwRWXmhQkoodkkdjeLJdAnrJlYx8X3Ib tdGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=qmpMmoGfdtcoNhoda3QOnbh+KNWhg0bhC0uDARsb4no=; b=IiL5lazVmvZeBilHrMcTtoISKPUhVB1FYg1gw+Nh6A5VZEdUXpLkOlTXzJoLRx6lwo lGJkYLdHskeWebpvZuIpX4NyljW4ePBY+i8FcxblkiQFZnSaDEiLID3NmBhnot2pBNRg Wq0OEM8KZr8eI8CPhtDgtGMpclzKWD4wpaYxVIGN9hkiwIVFK0zEjT6CKYo06ukKkLGS ctNH682Bp1BY7DjWpxyY4rk/8bw7+EIVsRw/evUtiFWlQ+F4+JFWtT7JHF/UExj9qpvt blJQjQH4v4UwDSB6qE2vFsORFETiQb7Dk1/rUB3MODwq0p4dh7VRcTGuVfVjpmAZkJig bdLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p6oEcpiZ; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id dd9si37987759ejc.754.2021.11.09.08.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 08:09:21 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p6oEcpiZ; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B381183964; Tue, 9 Nov 2021 17:09:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="p6oEcpiZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9B5FE8393E; Tue, 9 Nov 2021 17:09:10 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 534B68394D for ; Tue, 9 Nov 2021 17:09:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=etienne.carriere@linaro.org Received: by mail-wr1-x42b.google.com with SMTP id w29so22331850wra.12 for ; Tue, 09 Nov 2021 08:09:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qmpMmoGfdtcoNhoda3QOnbh+KNWhg0bhC0uDARsb4no=; b=p6oEcpiZN8zlNXA694itAp0jzzCDtafkc+ptDxzzzEnCPOiOEvbtDAas4hCA97Wwhu XcMiKJ1hmb0XXPcnxrX/pby8ph0nu4Zo88BixrtUevfgtR9nIOA9eH2kluVgZQFBr7yB OtlYAbWdjb/AEsh1RM02sFaku1W6zvdHI+6JPwvGQTrMo5X+WkdyJEsIetiV1uX5LIup 0kboHpabRIRG3/1r9TnrS24/zXgBSYQYATFBe2aqUNMXX20w2vu4c4n+W6ikFwMfm50i 4rJwF+xuSz9bAHei3wLJP7oSb3hmL05+0gj370OoIhrVLrLjOZfksfkRgKgaiIlg4P+b Zpaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qmpMmoGfdtcoNhoda3QOnbh+KNWhg0bhC0uDARsb4no=; b=gVqE2RStg0eQmFqIR7jB5OZpEj/FhZ45qrj/tVrfIQQV/5suD4ivz4IFt5aXKoyrIa bljnCcYjJmRkVolHyUZ/iLRmVvaThsywgfHeU6OlWy3ArKfNGSS1BCjEHo3R10bIbcmb vS1zxacbuFg93GVAsvOrpnuqiX/Hh/eU5VrCeysqCEeqLn9mjpd2hxPD/uiMZCTIPnZY U6emP+cDl0/P+feglgDcOjxLKPyBNZwDxDp4Sd+gqmoANDJuCz7TxZxn86YYjfaGBymV LgkiAxiuKWnr9Quckn0vtsReG08J8IgVEYbo5WwgZS/4ujtOWUodtckLhxp7m9thYm94 eqgQ== X-Gm-Message-State: AOAM531MtuXCIk3Z6Uj1rpI/wWkAN4FP4fxeDNtCXAvVyNLSdPVDQK9V Sa1CrjbN7fXrKnYG4a2SALJ7UU7EPVyGiImw X-Received: by 2002:a5d:48cf:: with SMTP id p15mr5623306wrs.277.1636474144552; Tue, 09 Nov 2021 08:09:04 -0800 (PST) Received: from lmecxl0524.lme.st.com ([2a04:cec0:10ec:fe30:ed93:5b26:60a4:aace]) by smtp.gmail.com with ESMTPSA id e18sm20130236wrs.48.2021.11.09.08.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 08:09:04 -0800 (PST) From: Etienne Carriere To: u-boot@lists.denx.de Cc: Etienne Carriere , Jens Wiklander Subject: [PATCH v2 2/5] tee: optee: remove unused duplicated login Id macros Date: Tue, 9 Nov 2021 17:08:21 +0100 Message-Id: <20211109160824.18268-2-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211109160824.18268-1-etienne.carriere@linaro.org> References: <20211109160824.18268-1-etienne.carriere@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID macros are already defined tee.h. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere --- Changes since v1: - Apply review tags Added info for v1: This change was previously discussed in the U-Boot ML, latest is "[PATCH v2 2/2] tee: optee: support session login as REE kernel", at: https://patchwork.ozlabs.org/project/uboot/patch/20210519142613.7668-2-etienne.carriere@linaro.org/ Changes since this v2 post: - Remove sanitation of the login Id passed to OP-TEE as secure world - Rephrase header line since this change now simply remove duplicated macros. - Update OPTEE_MSG_CMD_OPEN_SESSION inline description comment with a reference to TEE_LOGIN_* macros. --- drivers/tee/optee/optee_msg.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/tee/optee/optee_msg.h b/drivers/tee/optee/optee_msg.h index 8d40ce60c2..a8ef926a48 100644 --- a/drivers/tee/optee/optee_msg.h +++ b/drivers/tee/optee/optee_msg.h @@ -86,16 +86,6 @@ #define OPTEE_MSG_ATTR_CACHE_MASK GENMASK(2, 0) #define OPTEE_MSG_ATTR_CACHE_PREDEFINED 0 -/* - * Same values as TEE_LOGIN_* from TEE Internal API - */ -#define OPTEE_MSG_LOGIN_PUBLIC 0x00000000 -#define OPTEE_MSG_LOGIN_USER 0x00000001 -#define OPTEE_MSG_LOGIN_GROUP 0x00000002 -#define OPTEE_MSG_LOGIN_APPLICATION 0x00000004 -#define OPTEE_MSG_LOGIN_APPLICATION_USER 0x00000005 -#define OPTEE_MSG_LOGIN_APPLICATION_GROUP 0x00000006 - /* * Page size used in non-contiguous buffer entries */ @@ -279,7 +269,7 @@ struct optee_msg_arg { * parameters to pass the following information: * param[0].u.value.a-b uuid of Trusted Application * param[1].u.value.a-b uuid of Client - * param[1].u.value.c Login class of client OPTEE_MSG_LOGIN_* + * param[1].u.value.c Login class of client TEE_LOGIN_* * * OPTEE_MSG_CMD_INVOKE_COMMAND invokes a command a previously opened * session to a Trusted Application. struct optee_msg_arg::func is Trusted