From patchwork Mon Oct 4 03:44:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AKASHI Takahiro X-Patchwork-Id: 515143 Delivered-To: patch@linaro.org Received: by 2002:ac0:890a:0:0:0:0:0 with SMTP id 10csp1062586imy; Sun, 3 Oct 2021 20:47:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZP8W4ZSkyQkwmniiU8xUsFCjUNh0HW6F8U5W/pRb/vbFV2HTttyqgGQJGSmRRmoqeWzsg X-Received: by 2002:a17:907:97d2:: with SMTP id js18mr14107803ejc.191.1633319276736; Sun, 03 Oct 2021 20:47:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633319276; cv=none; d=google.com; s=arc-20160816; b=oAJoyJgnU1baS3scyfic6WPVANGzcY4Ualwr1lmmYa8PipZDDRME0VwaxUZK4jcjtF 5iuZwDuET5gAy/Q5+VruU7pX8aVP+/YMdd3aTkLpwtQHo48MjQbTRpe9IyRQ/i7bQTfU MWHLffmHJDgIWx0Abclza+dZkrPL3Unj72xX2OfRiGSB2LQR6auCowOZiGcoAceoWzqs V1ZZpOzceQPhjq8grxVjmyGnFqzA4bMbwXKoEpWLnfwg4c1whGLdPc9vb4sbPLvBP92E a55IE+qObFiS/mx6TdrEfFivFoKDAfN8g1Ky6eaU0FhSv7GxAAanwdPhqHnQuQ4OpCDO 4lVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ljBbc9yy6BIAE/d1lliVlMaJO1EJHQ1AhZFnjPHH/kI=; b=M2tx2CCTUrZyImXtcFPVICOzBNPjhb5FZkrTgj+Tnxdn5g5wxz0uoVHtW4FpRdDs0E l6d9p+CR6ztf/BFDZ4V5DYlUc64A9f1mmXm+hlyRiI8gZCL0EQhAUIS2o48UaHyILlnH jbEKwkJW0JsybSizwVklicU8+42kcBraijSHFVFgugzmdbIVQhvt/XvDGKehO5dpiptZ i8E9RMIK7EkQ/B4TcUpmKl8K5K5MOBxaatxorPNSp00Gg2tcSnuNBCaiexWMeoa3142E zYInMJzRXxecwIklMmYO9pk97vos8fPTsp5tgooD6xtQtXC+II2uZodynuMhe4NsZKi4 pEKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iB6scrkn; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id q6si8812740edd.80.2021.10.03.20.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 20:47:56 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iB6scrkn; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B10E8359B; Mon, 4 Oct 2021 05:46:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iB6scrkn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6E94A83575; Mon, 4 Oct 2021 05:46:20 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8457283571 for ; Mon, 4 Oct 2021 05:46:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1031.google.com with SMTP id kk10so1290306pjb.1 for ; Sun, 03 Oct 2021 20:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ljBbc9yy6BIAE/d1lliVlMaJO1EJHQ1AhZFnjPHH/kI=; b=iB6scrknsb+R2JZfGfqwAlIethPWIJb8f4tWhW64WmZf5AvJ92uweDEJgUxn6qMMmE pktxXvYoTfwtQ4IlTtkylsqoBt9bJdGcD5lgD5SGz4RxkDuDVL+hZrVmRh3RS2Mg2NLG YEsPq7RNtE5WTYhDHTrQNPTari2CKkHdRwTxXFryw1nDM9EdDGtXsGEwN9lIx6rMFjLl 0Zeb0edh8W3RH1CtwPoUjcfNwtWtL9cRwKpu2Q1hy8u8JqWYZdmgyHPEUNOmditORKA2 qdu/A1HIfhCGdHmuRrBDUHzxtE382DT2gQrWnAdbOnWwbrvQzfBeuJ8GvNYoqKO1M690 +rhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ljBbc9yy6BIAE/d1lliVlMaJO1EJHQ1AhZFnjPHH/kI=; b=WCZ3xu9S/fqdiRKhHUMxJf7g0Xnj8qmaACN83HLpZKq+UlxD7WURNL369PTr4vimGo LiEbZFxxjGGi9rEfhlvKoovqV6oNVj2HJjXio/bwNu3MRWnS522LS5dfBTVEZyhf4KLY lZ2mev/nN5XZ/w1CBlPyeC2nqtRomb9UF/v9p8iTTvaQVdt5vQg62rXUlZLrGsUOrYoh XsyygAxoEYXmmuvTqwcTfYBygnU0XZwMQJXnHjFBpRLZkE13gBxhaRUJH0ZagRUnnhNn 0y/43x5R24WyT5aIPdWWhBberXXFQFkPtmZJN3N6wsYrLA6mccbgm0ZHM25YRYee9bR7 uGkQ== X-Gm-Message-State: AOAM5306y//83ezOkoyqt8hA43t2zuc8Vog7zfebNb9ldBbnNqf3RVCx gMUCCLZ8H4FC/0prfAZ2QcPeOw== X-Received: by 2002:a17:90a:e7c8:: with SMTP id kb8mr1287188pjb.95.1633319167847; Sun, 03 Oct 2021 20:46:07 -0700 (PDT) Received: from localhost.localdomain (61-205-96-147m5.grp4.mineo.jp. [61.205.96.147]) by smtp.gmail.com with ESMTPSA id a11sm11863515pgj.75.2021.10.03.20.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 20:46:07 -0700 (PDT) From: AKASHI Takahiro To: xypron.glpk@gmx.de, agraf@csgraf.de, sjg@chromium.org, ilias.apalodimas@linaro.org Cc: u-boot@lists.denx.de, AKASHI Takahiro Subject: [resent RFC 14/22] efi_loader: disk: a helper function to create efi_disk objects from udevice Date: Mon, 4 Oct 2021 12:44:22 +0900 Message-Id: <20211004034430.41355-15-takahiro.akashi@linaro.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211004034430.41355-1-takahiro.akashi@linaro.org> References: <20211004034430.41355-1-takahiro.akashi@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Add efi_disk_create() function. Any UEFI handle created by efi_disk_create() can be treated as a efi_disk object, the udevice is either a UCLASS_BLK (a whole raw disk) or UCLASS_PARTITION (a disk partition). So this function is expected to be called every time such an udevice is detected and activated through a device model's "probe" interface. Signed-off-by: AKASHI Takahiro --- include/efi_loader.h | 2 + lib/efi_loader/efi_disk.c | 92 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 94 insertions(+) -- 2.33.0 diff --git a/include/efi_loader.h b/include/efi_loader.h index c440962fe522..751fde7fb153 100644 --- a/include/efi_loader.h +++ b/include/efi_loader.h @@ -517,6 +517,8 @@ efi_status_t EFIAPI efi_convert_pointer(efi_uintn_t debug_disposition, void efi_carve_out_dt_rsv(void *fdt); /* Called by bootefi to make console interface available */ efi_status_t efi_console_register(void); +/* Called when a block devices has been probed */ +int efi_disk_create(struct udevice *dev); /* Called by bootefi to make all disk storage accessible as EFI objects */ efi_status_t efi_disk_register(void); /* Called by efi_init_obj_list() to install EFI_RNG_PROTOCOL */ diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index cd5528046251..3fae40e034fb 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -484,6 +485,7 @@ error: return ret; } +#ifndef CONFIG_BLK /** * efi_disk_create_partitions() - create handles and protocols for partitions * @@ -531,6 +533,96 @@ int efi_disk_create_partitions(efi_handle_t parent, struct blk_desc *desc, return disks; } +#endif /* CONFIG_BLK */ + +/* + * Create a handle for a whole raw disk + * + * @dev uclass device + * @return 0 on success, -1 otherwise + */ +static int efi_disk_create_raw(struct udevice *dev) +{ + struct efi_disk_obj *disk; + struct blk_desc *desc; + const char *if_typename; + int diskid; + efi_status_t ret; + + desc = dev_get_uclass_plat(dev); + if_typename = blk_get_if_type_name(desc->if_type); + diskid = desc->devnum; + + ret = efi_disk_add_dev(NULL, NULL, if_typename, desc, + diskid, NULL, 0, &disk); + if (ret != EFI_SUCCESS) { + log_err("Adding disk %s%d failed\n", if_typename, diskid); + return -1; + } + disk->dev = dev; + dev->efi_obj = &disk->header; + + return 0; +} + +/* + * Create a handle for a disk partition + * + * @dev uclass device + * @return 0 on success, -1 otherwise + */ +static int efi_disk_create_part(struct udevice *dev) +{ + efi_handle_t parent; + struct blk_desc *desc; + const char *if_typename; + struct disk_part *part_data; + struct disk_partition *info; + unsigned int part; + int diskid; + struct efi_device_path *dp = NULL; + struct efi_disk_obj *disk; + efi_status_t ret; + + parent = dev->parent->efi_obj; + desc = dev_get_uclass_plat(dev->parent); + if_typename = blk_get_if_type_name(desc->if_type); + diskid = desc->devnum; + + part_data = dev_get_uclass_plat(dev); + part = part_data->partnum; + info = &part_data->gpt_part_info; + + /* TODO: should not use desc? */ + dp = efi_dp_from_part(desc, 0); + + ret = efi_disk_add_dev(parent, dp, if_typename, desc, diskid, + info, part, &disk); + if (ret != EFI_SUCCESS) { + log_err("Adding partition %s%d:%x failed\n", + if_typename, diskid, part); + return -1; + } + disk->dev = dev; + dev->efi_obj = &disk->header; + + return 0; +} + +int efi_disk_create(struct udevice *dev) +{ + enum uclass_id id; + + id = device_get_uclass_id(dev); + + if (id == UCLASS_BLK) + return efi_disk_create_raw(dev); + + if (id == UCLASS_PARTITION) + return efi_disk_create_part(dev); + + return -1; +} /** * efi_disk_register() - register block devices