diff mbox series

[v3,1/6] disk: dos: rename write_mbr_partition to write_mbr_sector

Message ID 20201223125515.28865-2-m.szyprowski@samsung.com
State Accepted
Commit 92f1c89d0a90ee39fce53ca6054223bf6b422cfb
Headers show
Series Add MBR partition table creation and verify command | expand

Commit Message

Marek Szyprowski Dec. 23, 2020, 12:55 p.m. UTC 
write_mbr_partition() function name is a bit misleading, so rename it to
write_mbr_sector(). This is a preparation for adding code for writing a
complete MBR partition layout.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 disk/part_dos.c           | 2 +-
 drivers/fastboot/fb_mmc.c | 2 +-
 include/part.h            | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.17.1

Comments

Tom Rini Jan. 16, 2021, 4:25 p.m. UTC | #1 
On Wed, Dec 23, 2020 at 01:55:10PM +0100, Marek Szyprowski wrote:

> write_mbr_partition() function name is a bit misleading, so rename it to

> write_mbr_sector(). This is a preparation for adding code for writing a

> complete MBR partition layout.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox series

Patch

diff --git a/disk/part_dos.c b/disk/part_dos.c
index 04f53106f7..ef706fb59c 100644
--- a/disk/part_dos.c
+++ b/disk/part_dos.c
@@ -329,7 +329,7 @@  int is_valid_dos_buf(void *buf)
 	return test_block_type(buf) == DOS_MBR ? 0 : -1;
 }
 
-int write_mbr_partition(struct blk_desc *dev_desc, void *buf)
+int write_mbr_sector(struct blk_desc *dev_desc, void *buf)
 {
 	if (is_valid_dos_buf(buf))
 		return -1;
diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
index ae8e8e512f..4e26cef941 100644
--- a/drivers/fastboot/fb_mmc.c
+++ b/drivers/fastboot/fb_mmc.c
@@ -508,7 +508,7 @@  void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
 			fastboot_fail("invalid MBR partition", response);
 			return;
 		}
-		if (write_mbr_partition(dev_desc, download_buffer)) {
+		if (write_mbr_sector(dev_desc, download_buffer)) {
 			printf("%s: writing MBR partition failed\n", __func__);
 			fastboot_fail("writing MBR partition failed",
 				      response);
diff --git a/include/part.h b/include/part.h
index 55be724d20..67b8b2a5cc 100644
--- a/include/part.h
+++ b/include/part.h
@@ -465,14 +465,14 @@  int get_disk_guid(struct blk_desc *dev_desc, char *guid);
 int is_valid_dos_buf(void *buf);
 
 /**
- * write_mbr_partition() - write DOS MBR
+ * write_mbr_sector() - write DOS MBR
  *
  * @param dev_desc - block device descriptor
  * @param buf - buffer which contains the MBR
  *
  * @return - '0' on success, otherwise error
  */
-int write_mbr_partition(struct blk_desc *dev_desc, void *buf);
+int write_mbr_sector(struct blk_desc *dev_desc, void *buf);
 
 #endif