From patchwork Wed May 27 06:41:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ovidiu Panait X-Patchwork-Id: 246655 List-Id: U-Boot discussion From: ovidiu.panait at windriver.com (Ovidiu Panait) Date: Wed, 27 May 2020 09:41:39 +0300 Subject: [PATCH 4/5] pinctrl: bcm283x: Fix return value check for dev_read_addr_ptr In-Reply-To: <20200527064140.21391-1-ovidiu.panait@windriver.com> References: <20200527064140.21391-1-ovidiu.panait@windriver.com> Message-ID: <20200527064140.21391-4-ovidiu.panait@windriver.com> dev_read_addr_ptr returns NULL on failure, so add the proper check. Signed-off-by: Ovidiu Panait --- drivers/pinctrl/broadcom/pinctrl-bcm283x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c index 9ab0baee33..49791c5962 100644 --- a/drivers/pinctrl/broadcom/pinctrl-bcm283x.c +++ b/drivers/pinctrl/broadcom/pinctrl-bcm283x.c @@ -111,7 +111,7 @@ int bcm283x_pinctl_ofdata_to_platdata(struct udevice *dev) priv = dev_get_priv(dev); priv->base_reg = dev_read_addr_ptr(dev); - if (priv->base_reg == (void *)FDT_ADDR_T_NONE) { + if (!priv->base_reg) { debug("%s: Failed to get base address\n", __func__); return -EINVAL; }