Message ID | 20200504231732.98778-17-sjg@chromium.org |
---|---|
State | Superseded |
Headers | show |
Series | Tidy up the 'bd' command. | expand |
On Tue, May 5, 2020 at 7:19 AM Simon Glass <sjg at chromium.org> wrote: > > These config options have not been migrated to Kconfig. This should be > handled using driver model, iterating over the available Ethernet devices. > For now, remove the code. > > Signed-off-by: Simon Glass <sjg at chromium.org> > --- > > cmd/bdinfo.c | 15 --------------- > 1 file changed, 15 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
On 05.05.20 01:17, Simon Glass wrote: > These config options have not been migrated to Kconfig. This should be > handled using driver model, iterating over the available Ethernet devices. > For now, remove the code. > > Signed-off-by: Simon Glass <sjg at chromium.org> Reviewed-by: Stefan Roese <sr at denx.de> Thanks, Stefan > --- > > cmd/bdinfo.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c > index d0afef5b5e..6fa8b32389 100644 > --- a/cmd/bdinfo.c > +++ b/cmd/bdinfo.c > @@ -86,21 +86,6 @@ static void print_eth_ip_addr(void) > { > #if defined(CONFIG_CMD_NET) > print_eth(0); > -#if defined(CONFIG_HAS_ETH1) > - print_eth(1); > -#endif > -#if defined(CONFIG_HAS_ETH2) > - print_eth(2); > -#endif > -#if defined(CONFIG_HAS_ETH3) > - print_eth(3); > -#endif > -#if defined(CONFIG_HAS_ETH4) > - print_eth(4); > -#endif > -#if defined(CONFIG_HAS_ETH5) > - print_eth(5); > -#endif > printf("IP addr = %s\n", env_get("ipaddr")); > #endif > } > Viele Gr??e, Stefan
diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c index d0afef5b5e..6fa8b32389 100644 --- a/cmd/bdinfo.c +++ b/cmd/bdinfo.c @@ -86,21 +86,6 @@ static void print_eth_ip_addr(void) { #if defined(CONFIG_CMD_NET) print_eth(0); -#if defined(CONFIG_HAS_ETH1) - print_eth(1); -#endif -#if defined(CONFIG_HAS_ETH2) - print_eth(2); -#endif -#if defined(CONFIG_HAS_ETH3) - print_eth(3); -#endif -#if defined(CONFIG_HAS_ETH4) - print_eth(4); -#endif -#if defined(CONFIG_HAS_ETH5) - print_eth(5); -#endif printf("IP addr = %s\n", env_get("ipaddr")); #endif }
These config options have not been migrated to Kconfig. This should be handled using driver model, iterating over the available Ethernet devices. For now, remove the code. Signed-off-by: Simon Glass <sjg at chromium.org> --- cmd/bdinfo.c | 15 --------------- 1 file changed, 15 deletions(-)