diff mbox series

[V2,3/6] power: imx8-power-domain: Set DM_FLAG_DEFAULT_PD_CTRL_OFF flag

Message ID 20200504131654.17085-3-peng.fan@nxp.com
State New
Headers show
Series [V2,1/6] dt-bindings: imx_rsrc: add SC_R_NONE | expand

Commit Message

Peng Fan May 4, 2020, 1:16 p.m. UTC 
From: Ye Li <ye.li at nxp.com>

If without this flag, calling dev_power_domain_ctrl will iteratively remove
the power domain device will causes iteratively power off parent PD. This is
not expected by imx8-power-domain-legacy driver. Power off parent PD is
controlled by the driver internally.

So set DM_FLAG_DEFAULT_PD_CTRL_OFF to avoid such issue

Signed-off-by: Ye Li <ye.li at nxp.com>
Signed-off-by: Peng Fan <peng.fan at nxp.com>
---
 drivers/power/domain/imx8-power-domain-legacy.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Babic May 11, 2020, 10:16 a.m. UTC | #1 
> From: Ye Li <ye.li at nxp.com>
> If without this flag, calling dev_power_domain_ctrl will iteratively remove
> the power domain device will causes iteratively power off parent PD. This is
> not expected by imx8-power-domain-legacy driver. Power off parent PD is
> controlled by the driver internally.
> So set DM_FLAG_DEFAULT_PD_CTRL_OFF to avoid such issue
> Signed-off-by: Ye Li <ye.li at nxp.com>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/drivers/power/domain/imx8-power-domain-legacy.c b/drivers/power/domain/imx8-power-domain-legacy.c
index 2c479744d3..e6e619358c 100644
--- a/drivers/power/domain/imx8-power-domain-legacy.c
+++ b/drivers/power/domain/imx8-power-domain-legacy.c
@@ -341,4 +341,5 @@  U_BOOT_DRIVER(imx8_power_domain) = {
 	.platdata_auto_alloc_size = sizeof(struct imx8_power_domain_platdata),
 	.priv_auto_alloc_size = sizeof(struct imx8_power_domain_priv),
 	.ops = &imx8_power_domain_ops,
+	.flags	= DM_FLAG_DEFAULT_PD_CTRL_OFF,
 };