From patchwork Mon Apr 27 00:08:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Roederer X-Patchwork-Id: 238566 List-Id: U-Boot discussion From: devel-sven at geroedel.de (Sven Roederer) Date: Mon, 27 Apr 2020 02:08:39 +0200 Subject: [PATCH 2/2] tools/fit-image: print a warning when cmd-line for dtc might be truncated In-Reply-To: <20200427000839.26473-1-devel-sven@geroedel.de> References: <20200427000839.26473-1-devel-sven@geroedel.de> Message-ID: <20200427000839.26473-3-devel-sven@geroedel.de> Signed-off-by: Sven Roederer --- tools/fit_image.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/fit_image.c b/tools/fit_image.c index 4aeabbcfe9..88ff093d05 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -17,6 +17,7 @@ #include "fit_common.h" #include "mkimage.h" #include +#include #include #include #include @@ -744,6 +745,9 @@ static int fit_handle_file(struct image_tool_params *params) snprintf(cmd, sizeof(cmd), "cp \"%s\" \"%s\"", params->imagefile, tmpfile); } + if (strlen(cmd) >= MKIMAGE_MAX_DTC_CMDLINE_LEN - 1) { + fprintf(stderr, "WARNING: command-line for FIT creation might be truncated and will probably fail.\n"); + } if (*cmd && system(cmd) == -1) { fprintf (stderr, "%s: system(%s) failed: %s\n",