| Message ID | 20200422170908.19435-2-ioana.ciornei@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | boards: lx2160aqds: transition to CONFIG_DM_ETH | expand |
>-----Original Message----- >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Ioana Ciornei >Sent: Wednesday, April 22, 2020 10:39 PM >To: Priyanka Jain <priyanka.jain at nxp.com>; u-boot at lists.denx.de >Cc: Alexandru Marginean <alexandru.marginean at nxp.com>; Madalin Bucur ><madalin.bucur at nxp.com>; Florin Laurentiu Chiculita ><florinlaurentiu.chiculita at nxp.com>; Razvan Ionut Cirjan ><razvanionut.cirjan at nxp.com>; Ioana Ciornei <ioana.ciornei at nxp.com> >Subject: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes Instead of "any missing" , please provide details on what you are adding. May be something like "Add dpmac1-2, dpmac5-16 nodes" > >Add the remaining DPMAC nodes in the LX2160A base dtsi. Similar comment here. Provide details of remaining. >These will be later used on the LX2160AQDS specific DTS. > >Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com> >--- > arch/arm/dts/fsl-lx2160a.dtsi | 86 ++++++++++++++++++++++++++++++++++- > 1 file changed, 85 insertions(+), 1 deletion(-) > >diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi >index 17ecdc569b37..9499fb9a3779 100644 >--- a/arch/arm/dts/fsl-lx2160a.dtsi >+++ b/arch/arm/dts/fsl-lx2160a.dtsi >@@ -2,7 +2,7 @@ > /* > * NXP lx2160a SOC common device tree source > * >- * Copyright 2018 NXP >+ * Copyright 2018, 2020 NXP Copyright 2018-2020 NXP > * > */ > <snip> Priyanka
> -----Original Message----- > From: Priyanka Jain (OSS) <priyanka.jain at oss.nxp.com> > Sent: Friday, April 24, 2020 11:18 AM > To: Ioana Ciornei <ioana.ciornei at nxp.com>; u-boot at lists.denx.de > Cc: Alexandru Marginean <alexandru.marginean at nxp.com>; Madalin Bucur > <madalin.bucur at nxp.com>; Florin Laurentiu Chiculita > <florinlaurentiu.chiculita at nxp.com>; Razvan Ionut Cirjan > <razvanionut.cirjan at nxp.com> > Subject: RE: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes > > >-----Original Message----- > >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Ioana Ciornei > >Sent: Wednesday, April 22, 2020 10:39 PM > >To: Priyanka Jain <priyanka.jain at nxp.com>; u-boot at lists.denx.de > >Cc: Alexandru Marginean <alexandru.marginean at nxp.com>; Madalin Bucur > ><madalin.bucur at nxp.com>; Florin Laurentiu Chiculita > ><florinlaurentiu.chiculita at nxp.com>; Razvan Ionut Cirjan > ><razvanionut.cirjan at nxp.com>; Ioana Ciornei <ioana.ciornei at nxp.com> > >Subject: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes > Instead of "any missing" , please provide details on what you are adding. > May be something like "Add dpmac1-2, dpmac5-16 nodes" > > > >Add the remaining DPMAC nodes in the LX2160A base dtsi. > Similar comment here. Provide details of remaining. > >These will be later used on the LX2160AQDS specific DTS. > > > >Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com> > >--- > > arch/arm/dts/fsl-lx2160a.dtsi | 86 ++++++++++++++++++++++++++++++++++- > > 1 file changed, 85 insertions(+), 1 deletion(-) > > > >diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl- > lx2160a.dtsi > >index 17ecdc569b37..9499fb9a3779 100644 > >--- a/arch/arm/dts/fsl-lx2160a.dtsi > >+++ b/arch/arm/dts/fsl-lx2160a.dtsi > >@@ -2,7 +2,7 @@ > > /* > > * NXP lx2160a SOC common device tree source > > * > >- * Copyright 2018 NXP > >+ * Copyright 2018, 2020 NXP > Copyright 2018-2020 NXP Were changes made in 2019 too? Otherwise, "2018,2020" is correct > > * > > */ > > > <snip> > Priyanka
> Subject: RE: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes > > > -----Original Message----- > > From: Priyanka Jain (OSS) <priyanka.jain at oss.nxp.com> > > Sent: Friday, April 24, 2020 11:18 AM > > To: Ioana Ciornei <ioana.ciornei at nxp.com>; u-boot at lists.denx.de > > Cc: Alexandru Marginean <alexandru.marginean at nxp.com>; Madalin Bucur > > <madalin.bucur at nxp.com>; Florin Laurentiu Chiculita > > <florinlaurentiu.chiculita at nxp.com>; Razvan Ionut Cirjan > > <razvanionut.cirjan at nxp.com> > > Subject: RE: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac > > nodes > > > > >-----Original Message----- > > >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Ioana > > >Ciornei > > >Sent: Wednesday, April 22, 2020 10:39 PM > > >To: Priyanka Jain <priyanka.jain at nxp.com>; u-boot at lists.denx.de > > >Cc: Alexandru Marginean <alexandru.marginean at nxp.com>; Madalin Bucur > > ><madalin.bucur at nxp.com>; Florin Laurentiu Chiculita > > ><florinlaurentiu.chiculita at nxp.com>; Razvan Ionut Cirjan > > ><razvanionut.cirjan at nxp.com>; Ioana Ciornei <ioana.ciornei at nxp.com> > > >Subject: [PATCH 1/6] arm: dts: lx2160a: add any missing dpmac nodes > > Instead of "any missing" , please provide details on what you are adding. > > May be something like "Add dpmac1-2, dpmac5-16 nodes" > > > > > >Add the remaining DPMAC nodes in the LX2160A base dtsi. > > Similar comment here. Provide details of remaining. > > >These will be later used on the LX2160AQDS specific DTS. > > > > > >Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com> > > >--- > > > arch/arm/dts/fsl-lx2160a.dtsi | 86 > > >++++++++++++++++++++++++++++++++++- > > > 1 file changed, 85 insertions(+), 1 deletion(-) > > > > > >diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl- > > lx2160a.dtsi > > >index 17ecdc569b37..9499fb9a3779 100644 > > >--- a/arch/arm/dts/fsl-lx2160a.dtsi > > >+++ b/arch/arm/dts/fsl-lx2160a.dtsi > > >@@ -2,7 +2,7 @@ > > > /* > > > * NXP lx2160a SOC common device tree source > > > * > > >- * Copyright 2018 NXP > > >+ * Copyright 2018, 2020 NXP > > Copyright 2018-2020 NXP > > Were changes made in 2019 too? > Otherwise, "2018,2020" is correct It seems there we're changes made in 2019 also. I'll update the Copyright in v2. Ioana > > > > * > > > */ > > > > > <snip> > > Priyanka
diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi index 17ecdc569b37..9499fb9a3779 100644 --- a/arch/arm/dts/fsl-lx2160a.dtsi +++ b/arch/arm/dts/fsl-lx2160a.dtsi @@ -2,7 +2,7 @@ /* * NXP lx2160a SOC common device tree source * - * Copyright 2018 NXP + * Copyright 2018, 2020 NXP * */ @@ -383,6 +383,18 @@ #address-cells = <1>; #size-cells = <0>; + dpmac1: dpmac at 1 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x1>; + status = "disabled"; + }; + + dpmac2: dpmac at 2 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x2>; + status = "disabled"; + }; + dpmac3: dpmac at 3 { compatible = "fsl,qoriq-mc-dpmac"; reg = <0x3>; @@ -395,6 +407,78 @@ status = "disabled"; }; + dpmac5: dpmac at 5 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x5>; + status = "disabled"; + }; + + dpmac6: dpmac at 6 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x6>; + status = "disabled"; + }; + + dpmac7: dpmac at 7 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x7>; + status = "disabled"; + }; + + dpmac8: dpmac at 8 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x8>; + status = "disabled"; + }; + + dpmac9: dpmac at 9 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x9>; + status = "disabled"; + }; + + dpmac10: dpmac at a { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0xa>; + status = "disabled"; + }; + + dpmac11: dpmac at b { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0xb>; + status = "disabled"; + }; + + dpmac12: dpmac at c { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0xc>; + status = "disabled"; + }; + + dpmac13: dpmac at d { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0xd>; + status = "disabled"; + }; + + dpmac14: dpmac at e { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0xe>; + status = "disabled"; + }; + + dpmac15: dpmac at f { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0xf>; + status = "disabled"; + }; + + dpmac16: dpmac at 10 { + compatible = "fsl,qoriq-mc-dpmac"; + reg = <0x10>; + status = "disabled"; + }; + dpmac17: dpmac at 11 { compatible = "fsl,qoriq-mc-dpmac"; reg = <0x11>;
Add the remaining DPMAC nodes in the LX2160A base dtsi. These will be later used on the LX2160AQDS specific DTS. Signed-off-by: Ioana Ciornei <ioana.ciornei at nxp.com> --- arch/arm/dts/fsl-lx2160a.dtsi | 86 ++++++++++++++++++++++++++++++++++- 1 file changed, 85 insertions(+), 1 deletion(-)