From patchwork Thu Apr 16 03:06:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 237816 List-Id: U-Boot discussion From: sjg at chromium.org (Simon Glass) Date: Wed, 15 Apr 2020 21:06:22 -0600 Subject: [PATCH] travis: Correct error checking when building boards Message-ID: <20200416030623.154639-1-sjg@chromium.org> At present if buildman reports an error, the travis build still succeeds. This is because the travis script does not stop when it sees errors; nor does it automatically return the exit code. Also the current error checking never triggers since 'ret' is not set. Fix this by setting 'ret' correctly. Signed-off-by: Simon Glass Reported-by: Michal Simek --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b3253da13c3..e5b2b5e335e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -208,7 +208,7 @@ script: # # Build a selection of boards if TEST_PY_BD is empty - if [[ "${BUILDMAN}" != "" ]]; then - tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE}; + tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?; if [[ $ret -ne 0 ]]; then tools/buildman/buildman -seP ${BUILDMAN}; exit $ret;