From patchwork Tue Mar 31 05:34:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayagonda Kokatanur X-Patchwork-Id: 244630 List-Id: U-Boot discussion From: rayagonda.kokatanur at broadcom.com (Rayagonda Kokatanur) Date: Tue, 31 Mar 2020 11:04:03 +0530 Subject: [PATCH v1 1/4] drivers: mmc: iproc_sdhci: fix possible memory leak In-Reply-To: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> References: <20200331053406.23063-1-rayagonda.kokatanur@broadcom.com> Message-ID: <20200331053406.23063-2-rayagonda.kokatanur@broadcom.com> From: Bharat Kumar Reddy Gooty Free the pointer variable 'iproc_sdhci' upon failure to fix possible memory leak. Signed-off-by: Bharat Kumar Reddy Gooty Signed-off-by: Rayagonda Kokatanur --- drivers/mmc/iproc_sdhci.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/iproc_sdhci.c b/drivers/mmc/iproc_sdhci.c index 831dd32eb7..36ecdba5c6 100644 --- a/drivers/mmc/iproc_sdhci.c +++ b/drivers/mmc/iproc_sdhci.c @@ -176,8 +176,7 @@ static int iproc_sdhci_probe(struct udevice *dev) u32 f_min_max[2]; int ret; - iproc_host = (struct sdhci_iproc_host *) - malloc(sizeof(struct sdhci_iproc_host)); + iproc_host = malloc(sizeof(struct sdhci_iproc_host)); if (!iproc_host) { printf("%s: sdhci host malloc fail!\n", __func__); return -ENOMEM; @@ -198,6 +197,7 @@ static int iproc_sdhci_probe(struct udevice *dev) "clock-freq-min-max", f_min_max, 2); if (ret) { printf("sdhci: clock-freq-min-max not found\n"); + free(iproc_host); return ret; } host->max_clk = f_min_max[1]; @@ -212,8 +212,10 @@ static int iproc_sdhci_probe(struct udevice *dev) ret = sdhci_setup_cfg(&plat->cfg, &iproc_host->host, f_min_max[1], f_min_max[0]); - if (ret) + if (ret) { + free(iproc_host); return ret; + } iproc_host->host.mmc = &plat->mmc; iproc_host->host.mmc->dev = dev;