diff mbox series

[1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7

Message ID 20200326210044.418526-1-marex@denx.de
State Superseded
Headers show
Series [1/2] ARM: dts: stm32: Add alternate pinmux for SDMMC2 pins 4-7 | expand

Commit Message

Marek Vasut March 26, 2020, 9 p.m. UTC
Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.

Signed-off-by: Marek Vasut <marex at denx.de>
Cc: Patrick Delaunay <patrick.delaunay at st.com>
Cc: Patrice Chotard <patrice.chotard at st.com>
---
 arch/arm/dts/stm32mp157-pinctrl.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Patrice CHOTARD March 30, 2020, 10:48 a.m. UTC | #1
Hi Marek

On 3/26/20 10:00 PM, Marek Vasut wrote:
> Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Patrick Delaunay <patrick.delaunay at st.com>
> Cc: Patrice Chotard <patrice.chotard at st.com>
> ---
>  arch/arm/dts/stm32mp157-pinctrl.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/dts/stm32mp157-pinctrl.dtsi b/arch/arm/dts/stm32mp157-pinctrl.dtsi
> index 81a363d93d..e25c44760e 100644
> --- a/arch/arm/dts/stm32mp157-pinctrl.dtsi
> +++ b/arch/arm/dts/stm32mp157-pinctrl.dtsi
> @@ -907,6 +907,27 @@
>  				};
>  			};
>  
> +			sdmmc2_d47_pins_b: sdmmc2-d47-1 {
> +				pins {
> +					pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
> +						 <STM32_PINMUX('A', 15, AF10)>, /* SDMMC2_D5 */
> +						 <STM32_PINMUX('C', 6, AF9)>, /* SDMMC2_D6 */
> +						 <STM32_PINMUX('C', 7, AF9)>; /* SDMMC2_D7 */
> +					slew-rate = <1>;
> +					drive-push-pull;
> +					bias-pull-up;
> +				};
> +			};
> +
> +			sdmmc2_d47_sleep_pins_b: sdmmc2-d47-sleep-1 {
> +				pins {
> +					pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
> +						 <STM32_PINMUX('A', 15, ANALOG)>, /* SDMMC2_D5 */
> +						 <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
> +						 <STM32_PINMUX('C', 7, ANALOG)>; /* SDMMC2_D7 */
> +				};
> +			};
> +
>  			spdifrx_pins_a: spdifrx-0 {
>  				pins {
>  					pinmux = <STM32_PINMUX('G', 12, AF8)>; /* SPDIF_IN1 */

Reviewed-by: Patrice Chotard <patrice.chotard at st.com>

Thanks
Marek Vasut March 30, 2020, 10:59 a.m. UTC | #2
On 3/30/20 12:48 PM, Patrice CHOTARD wrote:
> Hi Marek

Hi,

> On 3/26/20 10:00 PM, Marek Vasut wrote:
>> Add another mux option for SDMMC2 pins 4..7, this is used on AV96 board.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay at st.com>
>> Cc: Patrice Chotard <patrice.chotard at st.com>
>> ---
>>  arch/arm/dts/stm32mp157-pinctrl.dtsi | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm/dts/stm32mp157-pinctrl.dtsi b/arch/arm/dts/stm32mp157-pinctrl.dtsi
>> index 81a363d93d..e25c44760e 100644
>> --- a/arch/arm/dts/stm32mp157-pinctrl.dtsi
>> +++ b/arch/arm/dts/stm32mp157-pinctrl.dtsi
>> @@ -907,6 +907,27 @@
>>  				};
>>  			};
>>  
>> +			sdmmc2_d47_pins_b: sdmmc2-d47-1 {
>> +				pins {
>> +					pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
>> +						 <STM32_PINMUX('A', 15, AF10)>, /* SDMMC2_D5 */
>> +						 <STM32_PINMUX('C', 6, AF9)>, /* SDMMC2_D6 */
>> +						 <STM32_PINMUX('C', 7, AF9)>; /* SDMMC2_D7 */
>> +					slew-rate = <1>;
>> +					drive-push-pull;
>> +					bias-pull-up;
>> +				};
>> +			};
>> +

Actually, this one is wrong, the AFs are wrong. Lemme send a V2.
The rest of the patches should be OK. Sorry for the mess up.
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32mp157-pinctrl.dtsi b/arch/arm/dts/stm32mp157-pinctrl.dtsi
index 81a363d93d..e25c44760e 100644
--- a/arch/arm/dts/stm32mp157-pinctrl.dtsi
+++ b/arch/arm/dts/stm32mp157-pinctrl.dtsi
@@ -907,6 +907,27 @@ 
 				};
 			};
 
+			sdmmc2_d47_pins_b: sdmmc2-d47-1 {
+				pins {
+					pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */
+						 <STM32_PINMUX('A', 15, AF10)>, /* SDMMC2_D5 */
+						 <STM32_PINMUX('C', 6, AF9)>, /* SDMMC2_D6 */
+						 <STM32_PINMUX('C', 7, AF9)>; /* SDMMC2_D7 */
+					slew-rate = <1>;
+					drive-push-pull;
+					bias-pull-up;
+				};
+			};
+
+			sdmmc2_d47_sleep_pins_b: sdmmc2-d47-sleep-1 {
+				pins {
+					pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */
+						 <STM32_PINMUX('A', 15, ANALOG)>, /* SDMMC2_D5 */
+						 <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */
+						 <STM32_PINMUX('C', 7, ANALOG)>; /* SDMMC2_D7 */
+				};
+			};
+
 			spdifrx_pins_a: spdifrx-0 {
 				pins {
 					pinmux = <STM32_PINMUX('G', 12, AF8)>; /* SPDIF_IN1 */