From patchwork Mon Mar 23 20:15:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pratyush Yadav X-Patchwork-Id: 244160 List-Id: U-Boot discussion From: p.yadav at ti.com (Pratyush Yadav) Date: Tue, 24 Mar 2020 01:45:04 +0530 Subject: [PATCH v2 02/16] spi: spi-mem: allow specifying a command's extension In-Reply-To: <20200323201519.20341-1-p.yadav@ti.com> References: <20200323201519.20341-1-p.yadav@ti.com> Message-ID: <20200323201519.20341-3-p.yadav@ti.com> In xSPI mode, flashes expect 2-byte opcodes. The second byte is called the "command extension". There can be 3 types of extensions in xSPI: repeat, invert, and hex. When the extension type is "repeat", the same opcode is sent twice. When it is "invert", the second byte is the inverse of the opcode. When it is "hex" an additional opcode byte based is sent with the command whose value can be anything. So, make opcode a 16-bit value and add a 'nbytes', similar to how multiple address widths are handled. Signed-off-by: Pratyush Yadav --- include/spi-mem.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/spi-mem.h b/include/spi-mem.h index fc39d08c3c..c55b98fe3e 100644 --- a/include/spi-mem.h +++ b/include/spi-mem.h @@ -70,6 +70,8 @@ enum spi_mem_data_dir { /** * struct spi_mem_op - describes a SPI memory operation + * @cmd.nbytes: number of opcode bytes (only 1 or 2 are valid). The opcode is + * sent MSB-first. * @cmd.buswidth: number of IO lines used to transmit the command * @cmd.opcode: operation opcode * @cmd.dtr: whether the command opcode should be sent in DTR mode or not @@ -93,9 +95,10 @@ enum spi_mem_data_dir { */ struct spi_mem_op { struct { + u8 nbytes; u8 buswidth; - u8 opcode; u8 dtr : 1; + u16 opcode; } cmd; struct {