diff mbox series

[4/4] rv1108: Fix boot regression

Message ID 20200313174248.925841-5-otavio@ossystems.com.br
State Accepted
Commit 99f946976e185f9c4d94edce6bb123c9c341913a
Headers show
Series Fixes for rv1108 and rv1108-elgin-r1 | expand

Commit Message

Otavio Salvador March 13, 2020, 5:42 p.m. UTC
Since commit 79030a486128 ("rockchip: Add Single boot image
(with binman, pad_cat)") the following boot regression is seen:

U-Boot 2020.04-rc3-00050-gd16e18ca6c-dirty (Mar 09 2020 - 11:40:07 -0300)

Model: Elgin RV1108 R1 board
DRAM:  128 MiB
initcall sequence 67fd12a0 failed at call 6000b927 (err=-22)

This happens because the above commit missed to include the
"rockchip-u-boot.dtsi" for rv1108, so include this file
like it done for other Rockchip SoC dtsi's.

Fixes: 79030a486128 ("rockchip: Add Single boot image (with binman, pad_cat)")
Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
---

 arch/arm/dts/rv1108-u-boot.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 arch/arm/dts/rv1108-u-boot.dtsi

Comments

Kever Yang March 18, 2020, 1:52 a.m. UTC | #1
On 2020/3/14 ??1:42, Otavio Salvador wrote:
> Since commit 79030a486128 ("rockchip: Add Single boot image
> (with binman, pad_cat)") the following boot regression is seen:
>
> U-Boot 2020.04-rc3-00050-gd16e18ca6c-dirty (Mar 09 2020 - 11:40:07 -0300)
>
> Model: Elgin RV1108 R1 board
> DRAM:  128 MiB
> initcall sequence 67fd12a0 failed at call 6000b927 (err=-22)
>
> This happens because the above commit missed to include the
> "rockchip-u-boot.dtsi" for rv1108, so include this file
> like it done for other Rockchip SoC dtsi's.
>
> Fixes: 79030a486128 ("rockchip: Add Single boot image (with binman, pad_cat)")
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>


Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>
>   arch/arm/dts/rv1108-u-boot.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)
>   create mode 100644 arch/arm/dts/rv1108-u-boot.dtsi
>
> diff --git a/arch/arm/dts/rv1108-u-boot.dtsi b/arch/arm/dts/rv1108-u-boot.dtsi
> new file mode 100644
> index 0000000000..41ac054b81
> --- /dev/null
> +++ b/arch/arm/dts/rv1108-u-boot.dtsi
> @@ -0,0 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Jagan Teki <jagan at amarulasolutions.com>
> + */
> +
> +#include "rockchip-u-boot.dtsi"
Otavio Salvador March 26, 2020, 12:17 p.m. UTC | #2
Ping?

On Tue, Mar 17, 2020 at 10:52 PM Kever Yang <kever.yang at rock-chips.com> wrote:
>
>
> On 2020/3/14 ??1:42, Otavio Salvador wrote:
> > Since commit 79030a486128 ("rockchip: Add Single boot image
> > (with binman, pad_cat)") the following boot regression is seen:
> >
> > U-Boot 2020.04-rc3-00050-gd16e18ca6c-dirty (Mar 09 2020 - 11:40:07 -0300)
> >
> > Model: Elgin RV1108 R1 board
> > DRAM:  128 MiB
> > initcall sequence 67fd12a0 failed at call 6000b927 (err=-22)
> >
> > This happens because the above commit missed to include the
> > "rockchip-u-boot.dtsi" for rv1108, so include this file
> > like it done for other Rockchip SoC dtsi's.
> >
> > Fixes: 79030a486128 ("rockchip: Add Single boot image (with binman, pad_cat)")
> > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>
>
> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
>
> Thanks,
> - Kever
> > ---
> >
> >   arch/arm/dts/rv1108-u-boot.dtsi | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >   create mode 100644 arch/arm/dts/rv1108-u-boot.dtsi
> >
> > diff --git a/arch/arm/dts/rv1108-u-boot.dtsi b/arch/arm/dts/rv1108-u-boot.dtsi
> > new file mode 100644
> > index 0000000000..41ac054b81
> > --- /dev/null
> > +++ b/arch/arm/dts/rv1108-u-boot.dtsi
> > @@ -0,0 +1,6 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2019 Jagan Teki <jagan at amarulasolutions.com>
> > + */
> > +
> > +#include "rockchip-u-boot.dtsi"
>
>
diff mbox series

Patch

diff --git a/arch/arm/dts/rv1108-u-boot.dtsi b/arch/arm/dts/rv1108-u-boot.dtsi
new file mode 100644
index 0000000000..41ac054b81
--- /dev/null
+++ b/arch/arm/dts/rv1108-u-boot.dtsi
@@ -0,0 +1,6 @@ 
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Jagan Teki <jagan at amarulasolutions.com>
+ */
+
+#include "rockchip-u-boot.dtsi"