diff mbox series

[3/4] elgin-rv1108: Avoid adc_channel_single_shot error

Message ID 20200313174248.925841-4-otavio@ossystems.com.br
State Accepted
Commit 2dcbeb3568e568846d572d8329442f41b4f60a53
Headers show
Series Fixes for rv1108 and rv1108-elgin-r1 | expand

Commit Message

Otavio Salvador March 13, 2020, 5:42 p.m. UTC
Currently the following error message is seen during boot:

U-Boot 2020.01-08751-g55759ae141 (Mar 09 2020 - 14:44:52 -0300)

Model: Elgin RV1108 R1 board
DRAM:  128 MiB
APLL: 600000000 DPLL:1200000000 GPLL:1188000000
ACLK_BUS: 148500000 ACLK_PERI:148500000 HCLK_PERI:148500000 PCLK_PERI:74250000
MMC:   dwmmc at 30110000: 0
Loading Environment from MMC... OK
In:    serial at 10210000
Out:   serial at 10210000
Err:   serial at 10210000
Model: Elgin RV1108 R1 board
rockchip_dnl_key_pressed: adc_channel_single_shot fail!
....

Since the elgin-rv1108 does not use ADC to read the download
key status, select CONFIG_ROCKCHIP_BOOT_MODE_REG=0 to avoid
such error.

Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
---

 configs/elgin-rv1108_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kever Yang March 18, 2020, 1:52 a.m. UTC | #1
On 2020/3/14 ??1:42, Otavio Salvador wrote:
> Currently the following error message is seen during boot:
>
> U-Boot 2020.01-08751-g55759ae141 (Mar 09 2020 - 14:44:52 -0300)
>
> Model: Elgin RV1108 R1 board
> DRAM:  128 MiB
> APLL: 600000000 DPLL:1200000000 GPLL:1188000000
> ACLK_BUS: 148500000 ACLK_PERI:148500000 HCLK_PERI:148500000 PCLK_PERI:74250000
> MMC:   dwmmc at 30110000: 0
> Loading Environment from MMC... OK
> In:    serial at 10210000
> Out:   serial at 10210000
> Err:   serial at 10210000
> Model: Elgin RV1108 R1 board
> rockchip_dnl_key_pressed: adc_channel_single_shot fail!
> ....
>
> Since the elgin-rv1108 does not use ADC to read the download
> key status, select CONFIG_ROCKCHIP_BOOT_MODE_REG=0 to avoid
> such error.
>
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>


Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>
>   configs/elgin-rv1108_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configs/elgin-rv1108_defconfig b/configs/elgin-rv1108_defconfig
> index 80d53f3c10..b6682994f5 100644
> --- a/configs/elgin-rv1108_defconfig
> +++ b/configs/elgin-rv1108_defconfig
> @@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x60000000
>   CONFIG_ENV_OFFSET=0x3F8000
>   CONFIG_ROCKCHIP_RV1108=y
>   CONFIG_TARGET_ELGIN_RV1108=y
> +CONFIG_ROCKCHIP_BOOT_MODE_REG=0
>   CONFIG_NR_DRAM_BANKS=1
>   CONFIG_DEBUG_UART_BASE=0x10210000
>   CONFIG_DEBUG_UART_CLOCK=24000000
Otavio Salvador March 26, 2020, 12:18 p.m. UTC | #2
Ping?

On Tue, Mar 17, 2020 at 10:52 PM Kever Yang <kever.yang at rock-chips.com> wrote:
>
>
> On 2020/3/14 ??1:42, Otavio Salvador wrote:
> > Currently the following error message is seen during boot:
> >
> > U-Boot 2020.01-08751-g55759ae141 (Mar 09 2020 - 14:44:52 -0300)
> >
> > Model: Elgin RV1108 R1 board
> > DRAM:  128 MiB
> > APLL: 600000000 DPLL:1200000000 GPLL:1188000000
> > ACLK_BUS: 148500000 ACLK_PERI:148500000 HCLK_PERI:148500000 PCLK_PERI:74250000
> > MMC:   dwmmc at 30110000: 0
> > Loading Environment from MMC... OK
> > In:    serial at 10210000
> > Out:   serial at 10210000
> > Err:   serial at 10210000
> > Model: Elgin RV1108 R1 board
> > rockchip_dnl_key_pressed: adc_channel_single_shot fail!
> > ....
> >
> > Since the elgin-rv1108 does not use ADC to read the download
> > key status, select CONFIG_ROCKCHIP_BOOT_MODE_REG=0 to avoid
> > such error.
> >
> > Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>
>
> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
>
> Thanks,
> - Kever
> > ---
> >
> >   configs/elgin-rv1108_defconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/elgin-rv1108_defconfig b/configs/elgin-rv1108_defconfig
> > index 80d53f3c10..b6682994f5 100644
> > --- a/configs/elgin-rv1108_defconfig
> > +++ b/configs/elgin-rv1108_defconfig
> > @@ -4,6 +4,7 @@ CONFIG_SYS_TEXT_BASE=0x60000000
> >   CONFIG_ENV_OFFSET=0x3F8000
> >   CONFIG_ROCKCHIP_RV1108=y
> >   CONFIG_TARGET_ELGIN_RV1108=y
> > +CONFIG_ROCKCHIP_BOOT_MODE_REG=0
> >   CONFIG_NR_DRAM_BANKS=1
> >   CONFIG_DEBUG_UART_BASE=0x10210000
> >   CONFIG_DEBUG_UART_CLOCK=24000000
>
>
diff mbox series

Patch

diff --git a/configs/elgin-rv1108_defconfig b/configs/elgin-rv1108_defconfig
index 80d53f3c10..b6682994f5 100644
--- a/configs/elgin-rv1108_defconfig
+++ b/configs/elgin-rv1108_defconfig
@@ -4,6 +4,7 @@  CONFIG_SYS_TEXT_BASE=0x60000000
 CONFIG_ENV_OFFSET=0x3F8000
 CONFIG_ROCKCHIP_RV1108=y
 CONFIG_TARGET_ELGIN_RV1108=y
+CONFIG_ROCKCHIP_BOOT_MODE_REG=0
 CONFIG_NR_DRAM_BANKS=1
 CONFIG_DEBUG_UART_BASE=0x10210000
 CONFIG_DEBUG_UART_CLOCK=24000000