From patchwork Mon Jan 20 10:20:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 239799 List-Id: U-Boot discussion From: jh80.chung at samsung.com (Jaehoon Chung) Date: Mon, 20 Jan 2020 19:20:28 +0900 Subject: [RFC 3/4] mmc: bcm2835_sdhci: set SDHCI_QUIRK_BROKEN_SDMA flag In-Reply-To: <20200120102029.14264-1-jh80.chung@samsung.com> References: <20200120102029.14264-1-jh80.chung@samsung.com> Message-ID: <20200120102029.14264-4-jh80.chung@samsung.com> RPI4 is used device-tree that taken from firmware. mmcnr at 73e00000 is enabled on device-tree, so it's probed on u-boot side. Because it's for SDIO interface, it doesn't need to probe. When SDMA is enabled, mmcnr's probe is always failed. Below log is unnecessary : sdhci_setup_cfg: Your controller doesn't support SDMA!! mmcnr at 7e30000 - probe failed: -22 Signed-off-by: Jaehoon Chung --- drivers/mmc/bcm2835_sdhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/bcm2835_sdhci.c b/drivers/mmc/bcm2835_sdhci.c index 222ba22d66..f763c9a36e 100644 --- a/drivers/mmc/bcm2835_sdhci.c +++ b/drivers/mmc/bcm2835_sdhci.c @@ -216,7 +216,8 @@ static int bcm2835_sdhci_probe(struct udevice *dev) host->name = dev->name; host->ioaddr = (void *)base; host->quirks = SDHCI_QUIRK_BROKEN_VOLTAGE | SDHCI_QUIRK_BROKEN_R1B | - SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_NO_HISPD_BIT; + SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_NO_HISPD_BIT | + SDHCI_QUIRK_BROKEN_SDMA; host->max_clk = emmc_freq; host->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; host->ops = &bcm2835_ops;