| Message ID | 20200110073513.19472-4-wolfgang.wallner@br-automation.com |
|---|---|
| State | Accepted |
| Commit | ea86e725d4c363232047126f1c84b03f13de7840 |
| Headers | show |
| Series | gpio: intel_gpio: Fix Intel gpio driver | expand |
On Fri, 10 Jan 2020 at 00:35, Wolfgang Wallner <wolfgang.wallner at br-automation.com> wrote: > > Fix the following in intel_gpio_get_value(): > > * The value of the register is contained in the variable 'reg', not in > 'mode'. The variable 'mode' contains only the configuration whether > the gpio is currently an input or an output. > > * The correct bitmasks for the input and output value are > PAD_CFG0_RX_STATE and PAD_CFG0_TX_STATE. > Use them instead of the currently used PAD_CFG0_RX_STATE_BIT and > PAD_CFG0_TX_STATE_BIT. > > Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com> > > --- > > drivers/gpio/intel_gpio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg at chromium.org>
diff --git a/drivers/gpio/intel_gpio.c b/drivers/gpio/intel_gpio.c index ec1a315ae2..ef47b92ca4 100644 --- a/drivers/gpio/intel_gpio.c +++ b/drivers/gpio/intel_gpio.c @@ -59,9 +59,9 @@ static int intel_gpio_get_value(struct udevice *dev, uint offset) if (!mode) { rx_tx = reg & (PAD_CFG0_TX_DISABLE | PAD_CFG0_RX_DISABLE); if (rx_tx == PAD_CFG0_TX_DISABLE) - return mode & PAD_CFG0_RX_STATE_BIT ? 1 : 0; + return reg & PAD_CFG0_RX_STATE ? 1 : 0; else if (rx_tx == PAD_CFG0_RX_DISABLE) - return mode & PAD_CFG0_TX_STATE_BIT ? 1 : 0; + return reg & PAD_CFG0_TX_STATE ? 1 : 0; } return 0;
Fix the following in intel_gpio_get_value(): * The value of the register is contained in the variable 'reg', not in 'mode'. The variable 'mode' contains only the configuration whether the gpio is currently an input or an output. * The correct bitmasks for the input and output value are PAD_CFG0_RX_STATE and PAD_CFG0_TX_STATE. Use them instead of the currently used PAD_CFG0_RX_STATE_BIT and PAD_CFG0_TX_STATE_BIT. Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com> --- drivers/gpio/intel_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)