| Message ID | 20200110073513.19472-3-wolfgang.wallner@br-automation.com |
|---|---|
| State | Accepted |
| Commit | 28c626804dee51dd89a5a400e0cb663ee9cc77ed |
| Headers | show |
| Series | gpio: intel_gpio: Fix Intel gpio driver | expand |
On Fri, 10 Jan 2020 at 00:35, Wolfgang Wallner <wolfgang.wallner at br-automation.com> wrote: > > Add missing 'PAD_CFG0_TX_STATE' to the clear mask for pcr_clrsetbits32(). > Otherwise this bit cannot be cleared again after it has been set once. > > Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com> > --- > > drivers/gpio/intel_gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg at chromium.org>
diff --git a/drivers/gpio/intel_gpio.c b/drivers/gpio/intel_gpio.c index db63115628..ec1a315ae2 100644 --- a/drivers/gpio/intel_gpio.c +++ b/drivers/gpio/intel_gpio.c @@ -41,7 +41,7 @@ static int intel_gpio_direction_output(struct udevice *dev, uint offset, pcr_clrsetbits32(pinctrl, config_offset, PAD_CFG0_MODE_MASK | PAD_CFG0_RX_STATE | - PAD_CFG0_TX_DISABLE, + PAD_CFG0_TX_DISABLE | PAD_CFG0_TX_STATE, PAD_CFG0_MODE_GPIO | PAD_CFG0_RX_DISABLE | (value ? PAD_CFG0_TX_STATE : 0));
Add missing 'PAD_CFG0_TX_STATE' to the clear mask for pcr_clrsetbits32(). Otherwise this bit cannot be cleared again after it has been set once. Signed-off-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com> --- drivers/gpio/intel_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)