From patchwork Thu Jan 9 18:28:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 239336 List-Id: U-Boot discussion From: festevam at gmail.com (Fabio Estevam) Date: Thu, 9 Jan 2020 15:28:02 -0300 Subject: [PATCH] net: eth-uclass: Do not return error when no MAC is found Message-ID: <20200109182802.26121-1-festevam@gmail.com> On some i.MX8QXP MEK boards with no MAC address stored, the following hang is seen: Error: ethernet at 5b040000 address not set. (Board hangs) One way to avoid this issue is to select CONFIG_NET_RANDOM_ETHADDR, so that a random MAC is provided and boot proceeds, but the lack of MAC should not hang the entire system. Fix the hang by removing the propagation of error when no MAC is found. In this case there are already messages indicating that something is not correct: Error: ethernet at 5b040000 address not set. Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value eth0: ethernet at 5b040000 Error: ethernet at 5b040000 address 00:00:00:00:00:00 illegal value Signed-off-by: Fabio Estevam Acked-by: Joe Hershberger --- net/eth-uclass.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/eth-uclass.c b/net/eth-uclass.c index ed81cbd537..bc2b0aac00 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -554,7 +554,6 @@ static int eth_post_probe(struct udevice *dev) #else printf("\nError: %s address not set.\n", dev->name); - return -EINVAL; #endif }