Message ID | 20200103152643.v2.3.I8ae988bc25a8b9ae27d647c4b50a05c1f630e0bb@changeid |
---|---|
State | Superseded |
Headers | show |
Series | i2c: designware_ic2: Improvements to timing and general cleanup | expand |
Reviewed-by: Jun Chen <ptchentw at gmail.com> Simon Glass <sjg at chromium.org> 於 2020年1月4日 週六 上午6:27寫道: > We use struct clk here so really should include this header file to avoid > build errors. Also switch the order of clk.h in the C file to match the > required code style. > > Signed-off-by: Simon Glass <sjg at chromium.org> > Reviewed-by: Ley Foon Tan <ley.foon.tan at intel.com> > --- > > Changes in v2: None > > drivers/i2c/designware_i2c.c | 2 +- > drivers/i2c/designware_i2c.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c > index b8cdd1c661..138fc72561 100644 > --- a/drivers/i2c/designware_i2c.c > +++ b/drivers/i2c/designware_i2c.c > @@ -4,8 +4,8 @@ > * Vipin Kumar, ST Micoelectronics, vipin.kumar at st.com. > */ > > -#include <clk.h> > #include <common.h> > +#include <clk.h> > #include <dm.h> > #include <i2c.h> > #include <pci.h> > diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h > index 0eb28191d2..39e62bcf51 100644 > --- a/drivers/i2c/designware_i2c.h > +++ b/drivers/i2c/designware_i2c.h > @@ -7,6 +7,7 @@ > #ifndef __DW_I2C_H_ > #define __DW_I2C_H_ > > +#include <clk.h> > #include <reset.h> > > struct i2c_regs { > -- > 2.24.1.735.g03f4e72817-goog > >
Hello Simon, Am 03.01.2020 um 23:26 schrieb Simon Glass: > We use struct clk here so really should include this header file to avoid > build errors. Also switch the order of clk.h in the C file to match the > required code style. > > Signed-off-by: Simon Glass <sjg at chromium.org> > Reviewed-by: Ley Foon Tan <ley.foon.tan at intel.com> > --- > > Changes in v2: None > > drivers/i2c/designware_i2c.c | 2 +- > drivers/i2c/designware_i2c.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Heiko Schocher <hs at denx.de> bye, Heiko
diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c index b8cdd1c661..138fc72561 100644 --- a/drivers/i2c/designware_i2c.c +++ b/drivers/i2c/designware_i2c.c @@ -4,8 +4,8 @@ * Vipin Kumar, ST Micoelectronics, vipin.kumar at st.com. */ -#include <clk.h> #include <common.h> +#include <clk.h> #include <dm.h> #include <i2c.h> #include <pci.h> diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h index 0eb28191d2..39e62bcf51 100644 --- a/drivers/i2c/designware_i2c.h +++ b/drivers/i2c/designware_i2c.h @@ -7,6 +7,7 @@ #ifndef __DW_I2C_H_ #define __DW_I2C_H_ +#include <clk.h> #include <reset.h> struct i2c_regs {