From patchwork Fri Oct 19 12:43:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 149283 Delivered-To: patch@linaro.org Received: by 2002:a2e:8595:0:0:0:0:0 with SMTP id b21-v6csp3258905lji; Fri, 19 Oct 2018 05:43:44 -0700 (PDT) X-Google-Smtp-Source: ACcGV60/iDfMyeCe9khODdLF/1WyENzn4UptCiCV5tydPKWSdauJpO0gGvASEzJDNndW1dc+n3xO X-Received: by 2002:a50:fa96:: with SMTP id w22-v6mr5840910edr.59.1539953024836; Fri, 19 Oct 2018 05:43:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539953024; cv=none; d=google.com; s=arc-20160816; b=VVG8mAvoliEPTpnkQvz9dYoJ8QsnVE/RHtA7tahY7UDO2Y73HMntl/I0UItOUNwsJH lWy/MrcF8lVzNTB579AimY5qZXUgcpfWueWE/lTlPOqSWi/SRa9/9SB41IygwLwsBJeB P8zW5qaQSaUT69MmS9KhhAUUQegZF2M7fE89bGmxIX+lvf+jApfvUmzyZ+29UWIymCbj yHVItcZwjTmVKHS7ISl29gnhh6fIS5SE7s/N01Rf/L8sT51j4E/7v1//uhY0ngHp/r4M rHm4uav9brQrsPrSCCS5iPq3jLDJ6lqlOLEe7OLcLARq7DK5rAJwV0Q4PFcnL1BXBPIZ y0HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from; bh=ev/5kifFQXul0B0pXlrV303tcEpV0bihcUkAW8qoiDs=; b=fIzRsl+j9vV7shZKyLQ7EcHof/5tfkevDEbFcBLu/c/MisFMxavFVh3IDZfzawGwbK fuUh2xuU+70leuDFRJTzYR1SUsGA0wZWWLUg6nGTL/GiwN8vT5GLhHJA9MjBLGD6V6Je 50ocDIoRuohR1mWnJ5j5ry5OEb7yQPVYrCa605HzpcnEbHtrb08IcMRobndTKee/7gsH GHiynuNsZDM0nbNR7OLZhQRQh06VA/NP+dg9EMAC0IuPnSpsAdw7MVezcP2Hlw8Bhz1b YqPJICBbgUMSZAGp7ktyDlbrSfcbRarFIKAXdgrd+iffiogkVmidlHRiDoK754n/a7WL U51Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id h6-v6si216892edn.332.2018.10.19.05.43.44; Fri, 19 Oct 2018 05:43:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id 3C66AC21D8A; Fri, 19 Oct 2018 12:43:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id CE21DC21C27; Fri, 19 Oct 2018 12:43:39 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id C1D8EC21C27; Fri, 19 Oct 2018 12:43:38 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by lists.denx.de (Postfix) with ESMTPS id 7BA73C21BE5 for ; Fri, 19 Oct 2018 12:43:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0F69EACE1; Fri, 19 Oct 2018 12:43:38 +0000 (UTC) From: Alexander Graf To: u-boot@lists.denx.de Date: Fri, 19 Oct 2018 14:43:35 +0200 Message-Id: <20181019124335.56725-1-agraf@suse.de> X-Mailer: git-send-email 2.12.3 Cc: Marek Vasut Subject: [U-Boot] [PATCH] usb: Do not compile USB_STORAGE with !BLK && !DM_USB X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The USB storage driver does not compile when CONFIG_BLK is set, but DM_USB is not set, as we're missing the DM device links for CONFIG_BLK enabled code paths. So far it looks like nobody fell into this trap, because no board enabled CONFIG_BLK and CONFIG_USB_STORAGE while not enabling CONFIG_DM_USB, but we should still reflect that dependency properly in Kconfig so that implicit enabling of CONFIG_USB_STORAGE works. Signed-off-by: Alexander Graf --- drivers/usb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index 4fbe172e05..297dda1511 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -65,6 +65,7 @@ comment "USB peripherals" config USB_STORAGE bool "USB Mass Storage support" + depends on DM_USB || !BLK ---help--- Say Y here if you want to connect USB mass storage devices to your board's USB port.