From patchwork Tue Jun 19 11:47:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 139107 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp5104013lji; Tue, 19 Jun 2018 04:47:11 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIOb2Lgx73sKGE0oMSpdACwjKolERG2lG14vByH/QzcpvM71iCst/UT7A7MK48lGTEGYAwV X-Received: by 2002:a50:a0e2:: with SMTP id 89-v6mr14632552edo.292.1529408831786; Tue, 19 Jun 2018 04:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529408831; cv=none; d=google.com; s=arc-20160816; b=lP4v7zCI4YokgbHuk1bfu+SLvvOKmMMZT1g9yZRWZ63IYIoMZJCH9qGkc3iZhRt9SF Zy2crQnawGTNI54OrrxO5vgTpdGVrWM/JYexgTvSrBzk+0Thnd0oOi/6tzJC62cD19l9 h7jFvs6gUIePBm2WiEGhM9rESJYDeAMyScelPsVwwaQRLNUCR5rLfKkEYcFBjMLy5Y01 R+G6vildQUZ/mBqm4eO1ueL1d20wDaIt0kt5tAZRKVdwXwZBicCpShzoJGw/a3OFrsLm KERmXiSpzlRgojN7jtna2CKjnR5roO6P07vlsj5FX1Q0bI6zkoe4GE9POeS5HxWKH0uv 8LZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from :arc-authentication-results; bh=QcHc35x1d8Vy1/bz4YaT+PeodGr8b8T0IyCIcwsopOk=; b=lwWOOZ+G7KzPrdykwmcBnb0kfFC0DGfMIMADltxzn2X2Pe4b25iS8Xh4sX36OYegQ8 hbwOQTXwMKFTXcn6n42l3qJeNrFxN6SQVo6CENXLcdzfQ18/11kH9lMlZE99PTDXolw2 QG6poGOw28h0iphwLJPEHuNF2lJr+0rqbVbqTfa+/mFqcciF3mnzo23Te0Kvc8dQNvV6 DxgpQiwBHejxXB72j9BSpuA5+a7uleYOlw/cr1ZNWpETcUlFz6WhfOXr0IaV8JFkLJ/G xIvGWefOoctdYwAU5mkSXtPuFv2II7ZgoIOo0QZaulDUzTqHXjjTnhSe16T6Zm5hfmft Bk1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id x5-v6si9633438edr.425.2018.06.19.04.47.11; Tue, 19 Jun 2018 04:47:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id F38D1C21F6A; Tue, 19 Jun 2018 11:47:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2700FC21CB1; Tue, 19 Jun 2018 11:47:04 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 635CEC21CB1; Tue, 19 Jun 2018 11:47:03 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by lists.denx.de (Postfix) with ESMTPS id 157E7C21C8B for ; Tue, 19 Jun 2018 11:47:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 93B5FAEE0; Tue, 19 Jun 2018 11:47:02 +0000 (UTC) From: Alexander Graf To: u-boot@lists.denx.de Date: Tue, 19 Jun 2018 13:47:01 +0200 Message-Id: <20180619114701.87820-1-agraf@suse.de> X-Mailer: git-send-email 2.12.3 Cc: Heinrich Schuchardt , Fabian Vogt Subject: [U-Boot] [PATCH] efi_loader: Fix GOP 32bpp exposure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" We store pixels as BGRA in memory, as can be seen from struct efi_gop_pixel. So we need to expose the same format to UEFI payloads to actually have them use the correct colors. Reported-by: Fabian Vogt Signed-off-by: Alexander Graf Tested-by: Peter Robinson Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_gop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c index 1afe8418e1..3a36bbcbfa 100644 --- a/lib/efi_loader/efi_gop.c +++ b/lib/efi_loader/efi_gop.c @@ -472,7 +472,7 @@ efi_status_t efi_gop_register(void) gopobj->info.version = 0; gopobj->info.width = col; gopobj->info.height = row; - gopobj->info.pixel_format = EFI_GOT_RGBA8; + gopobj->info.pixel_format = EFI_GOT_BGRA8; gopobj->info.pixels_per_scanline = col; gopobj->bpix = bpix;