From patchwork Thu Nov 16 09:22:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 119032 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5360631qgn; Thu, 16 Nov 2017 01:28:09 -0800 (PST) X-Google-Smtp-Source: AGs4zMZBct40Hr+P7LgQYuiCg99hyeVsk6tdkG5bLqsYqkUWHFX0VDZO8H+B1geQ0b3x1doqZ35/ X-Received: by 10.80.191.15 with SMTP id f15mr1847247edk.82.1510824489365; Thu, 16 Nov 2017 01:28:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510824489; cv=none; d=google.com; s=arc-20160816; b=rdH/J2yPYUb1LwbLpOsYzJEaYJVO2b1L/VQIUOKdDivPWn014Eur3C5OXzU2xcztF8 Tx/2JcVUscE15V+uKuNYq6y4vTHL9N5oLDvDMlmszDhksfYYuPsvkoFFX8IcoKq+3Bri ZCK8qHc9mGKwqx5iW1aaD/Swd12XyHhpx66WfAbyIynkwtdbiyVweAU1VnHiA67m1PDG +Yinpw84GnPWxr/FoKuiFcyfndgHzC+D6sHv+GujdbDNXUrfcaMnO4UeGh7vjvhglodl iwK0IFn9apmxhOqY0OKzKGoE+fcQ5yPEYQOwlBvwf/bLwMME5hVrnVI0gNpQ1dFeOm9u C8pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:message-id :date:to:from:arc-authentication-results; bh=FXHLx0bz2Rn82z5Ic61FG5lNWLSyWXsV8Hy5KMLY/+w=; b=FeJT2hFXGlTqeeLKdxsgZWDk+QAMph3csb2NrUOy2AzRZpKinr3QosZKTdi1jx/epw 2P+ppqMvmV5FpguEcd9OpAy9R+2ltilZYNruwMP4aFrRl/CwntGOlxJcQ6sDrlHM8MF9 qnSNeNGeD+PRd5v8UdPDzU/3w1QC+kSlyhBpYyGRh5kQHWgN/0oiiy3+LvLrNxxtQ6Wl fX5opetccNib/e05r/zBtwdj2BOCR9mbJMTFUGJpPmSn+KbY/1UNOMl17CCQB1JVBQhI ntX2Dwc97+PyS4qmtzKnJee5ys/rgRvuROuTybhyhRoa66T0uBLMTHTA/ix4txggp7fc E8JA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id k60si840954edc.530.2017.11.16.01.28.09; Thu, 16 Nov 2017 01:28:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id E5D00C21DA0; Thu, 16 Nov 2017 09:24:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4BA3FC21DC5; Thu, 16 Nov 2017 09:24:06 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 74753C21DC5; Thu, 16 Nov 2017 09:22:59 +0000 (UTC) Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by lists.denx.de (Postfix) with ESMTP id 90F9DC21DDD for ; Thu, 16 Nov 2017 09:22:55 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 863642055E; Thu, 16 Nov 2017 10:22:54 +0100 (CET) Received: from localhost (unknown [185.94.189.187]) by mail.free-electrons.com (Postfix) with ESMTPSA id DE12420DDE; Thu, 16 Nov 2017 10:22:39 +0100 (CET) From: Maxime Ripard To: Tom Rini Date: Thu, 16 Nov 2017 10:22:26 +0100 Message-Id: <20171116092231.27740-6-maxime.ripard@free-electrons.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171116092231.27740-1-maxime.ripard@free-electrons.com> References: <20171116092231.27740-1-maxime.ripard@free-electrons.com> Cc: Andre Przywara , agraf@suse.de, u-boot@lists.denx.de, Maxime Ripard , Jagan Teki Subject: [U-Boot] [RFC PATCH 05/10] env: Make the env save message a bit more explicit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Since we'll soon have support for multiple environments, the environment saving message might end up being printed multiple times if the higher priority environment cannot be used. That might confuse the user, so let's make it explicit if the operation failed or not. Signed-off-by: Maxime Ripard Reviewed-by: Lukasz Majewski --- env/env.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/env/env.c b/env/env.c index 673bfa6ba41b..1d13220aa79b 100644 --- a/env/env.c +++ b/env/env.c @@ -131,8 +131,9 @@ int env_save(void) if (!drv->save) continue; - printf("Saving Environment to %s...\n", drv->name); + printf("Saving Environment to %s... ", drv->name); ret = drv->save(); + printf("%s\n", ret ? "Failed" : "OK"); if (!ret) return 0;