From patchwork Tue Aug 23 06:08:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 74489 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1928450qga; Mon, 22 Aug 2016 23:07:10 -0700 (PDT) X-Received: by 10.28.127.138 with SMTP id a132mr17517192wmd.72.1471932430532; Mon, 22 Aug 2016 23:07:10 -0700 (PDT) Return-Path: Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id g1si19539780wmc.33.2016.08.22.23.07.09; Mon, 22 Aug 2016 23:07:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) client-ip=85.214.87.163; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@nifty.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 85.214.87.163 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D2EA44B811; Tue, 23 Aug 2016 08:07:08 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zdXIbzy8fdnG; Tue, 23 Aug 2016 08:07:08 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0DEF14B68A; Tue, 23 Aug 2016 08:07:08 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0FD074B68A for ; Tue, 23 Aug 2016 08:07:04 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9-HR5FK5drIA for ; Tue, 23 Aug 2016 08:07:03 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 IN_IX_MANITU=4.35 (only DNSBL check requested) Received: from conuserg-11.nifty.com (conuserg-11.nifty.com [210.131.2.78]) by theia.denx.de (Postfix) with ESMTPS id 49CC44B660 for ; Tue, 23 Aug 2016 08:07:00 +0200 (CEST) Received: from beagle.diag.org (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id u7N65xeU001412; Tue, 23 Aug 2016 15:06:00 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com u7N65xeU001412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1471932361; bh=pyq8fkwwW0glqt608h2pBe19EIWPrp4Rhd+KaO885Z8=; h=From:To:Cc:Subject:Date:From; b=hEUB/VfOAt/qO2eFoomv8wODBVtP6/JMqL0DO/xaS0cV9NtdtBnLtXsRdNF1raxbK OnJ1vO9ABnpeGEnyWamLAV7JXO9BwyFZMxRPKFSE0RiiUi4pImSLpPGIePJCH12zMi osYJ7aEI5zm0jrHIw5g1Jpg7QidbymdXm5+rzrNzLiK1V0l+WkGfty83zA5nqqc4qq tBS+oLeV+TtO4J9F5C63v56hMtiTfyVkiL6BOqapPOiSul2DJztmIrgUSQxwOK/GaP RyNv/14GxKeNfKwydKwEN3O4khAZcUNrOTNHhnF6lJyBx18c0FW+9Qw8u6LEFoxVXu hxJanjVbmMqzA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: u-boot@lists.denx.de Date: Tue, 23 Aug 2016 15:08:02 +0900 Message-Id: <1471932483-8573-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 1.9.1 Cc: Tom Rini , Michael van Slingerland , Christophe Ricard Subject: [U-Boot] [PATCH] common: show "Boot media" menu only for some TI and Freescale SoCs X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The CONFIG_"_BOOT does not control anything in common code; they are mostly used to enable a set of options in include/configs/.h, in other words, the behavior of these options are highly SoC specific. Actually, nothing happens for other SoCs than some TI, Freescale ones. This menu is weird in multiple ways: [1] These options, which make sense only for TI and Freescale boards, are visible to all. The menu was place in the common place perhaps because TI and Freescale just happened to use the same config names. [2] Multiple boot media can be enabled, and its behavior is probably undefined. This will be solved by changing "menu" to "choice". I leave this to somebody who has interest. [3] All boot media, some of them are not supported, are visible. In fact, I do not see any reference to CONFIG_ONENAND_BOOT, CONFIG_SATA_BOOT. This commit addresses [1]. Instead of pushing the menu away to SoC Kconfig files or somewhere, one alternative solution is to hide such a non-sense menu because it is misleading users of other boards. Signed-off-by: Masahiro Yamada --- This patch implies that I am opposed to the following patch: http://patchwork.ozlabs.org/patch/661514/ common/Kconfig | 5 +++++ 1 file changed, 5 insertions(+) -- 1.9.1 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot diff --git a/common/Kconfig b/common/Kconfig index 46e7173..8a56967 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -98,6 +98,11 @@ config BOOTSTAGE_STASH_SIZE endmenu menu "Boot media" + depends on TARGET_AM335X_EVM || TARGET_AM43XX_EVM || TARGET_BRPPT1 || \ + TARGET_LS1012AFRDM || TARGET_LS1012AQDS || \ + TARGET_LS1012ARDB || TARGET_LS1021AQDS || \ + TARGET_LS1021ATWR || TARGET_LS1043AQDS || \ + TARGET_LS1043ARDB || TARGET_LS2080AQDS config NOR_BOOT bool "Support for booting from NOR flash"